From: Rob Herring <robh@kernel.org>
To: Laura Nao <laura.nao@collabora.com>
Cc: srini@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
rafael@kernel.org, daniel.lezcano@linaro.org,
rui.zhang@intel.com, lukasz.luba@arm.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, wenst@chromium.org,
nfraprado@collabora.com, arnd@arndb.de, colin.i.king@gmail.com,
u.kleine-koenig@baylibre.com, andrew-ct.chen@mediatek.com,
lala.lin@mediatek.com, bchihi@baylibre.com,
frank-w@public-files.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, kernel@collabora.com
Subject: Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196
Date: Wed, 30 Jul 2025 18:54:51 -0500 [thread overview]
Message-ID: <20250730235451.GA1911689-robh@kernel.org> (raw)
In-Reply-To: <20250730152128.311109-10-laura.nao@collabora.com>
On Wed, Jul 30, 2025 at 05:21:28PM +0200, Laura Nao wrote:
> The MT8196 eFuse layout is compatible with MT8186 and shares the same
> decoding scheme for the gpu-speedbin cell.
>
> Signed-off-by: Laura Nao <laura.nao@collabora.com>
> ---
> Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index 4dc0d42df3e6..455b96c1e1f4 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -25,6 +25,7 @@ properties:
> compatible:
> oneOf:
> - items:
> + - const: mediatek,mt8196-efuse
> - const: mediatek,mt8188-efuse
> - const: mediatek,mt8186-efuse
You just broke mt8188 as it had 2 entries and now has 3. I think
(based on the commit msg) you want to change 8188 entry to an enum with
mediatek,mt8196-efuse and mediatek,mt8188-efuse.
> - const: mediatek,mt8186-efuse
> --
> 2.39.5
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Laura Nao <laura.nao@collabora.com>
Cc: andrew-ct.chen@mediatek.com, lala.lin@mediatek.com,
rafael@kernel.org, kernel@collabora.com, bchihi@baylibre.com,
nfraprado@collabora.com, daniel.lezcano@linaro.org,
wenst@chromium.org, rui.zhang@intel.com, colin.i.king@gmail.com,
devicetree@vger.kernel.org, conor+dt@kernel.org, arnd@arndb.de,
linux-pm@vger.kernel.org, u.kleine-koenig@baylibre.com,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com,
linux-kernel@vger.kernel.org, srini@kernel.org,
linux-mediatek@lists.infradead.org, krzk+dt@kernel.org,
lukasz.luba@arm.com
Subject: Re: [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196
Date: Wed, 30 Jul 2025 18:54:51 -0500 [thread overview]
Message-ID: <20250730235451.GA1911689-robh@kernel.org> (raw)
In-Reply-To: <20250730152128.311109-10-laura.nao@collabora.com>
On Wed, Jul 30, 2025 at 05:21:28PM +0200, Laura Nao wrote:
> The MT8196 eFuse layout is compatible with MT8186 and shares the same
> decoding scheme for the gpu-speedbin cell.
>
> Signed-off-by: Laura Nao <laura.nao@collabora.com>
> ---
> Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index 4dc0d42df3e6..455b96c1e1f4 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -25,6 +25,7 @@ properties:
> compatible:
> oneOf:
> - items:
> + - const: mediatek,mt8196-efuse
> - const: mediatek,mt8188-efuse
> - const: mediatek,mt8186-efuse
You just broke mt8188 as it had 2 entries and now has 3. I think
(based on the commit msg) you want to change 8188 entry to an enum with
mediatek,mt8196-efuse and mediatek,mt8188-efuse.
> - const: mediatek,mt8186-efuse
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-07-30 23:58 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 15:21 [PATCH v2 0/9] Add thermal sensor driver support for Mediatek MT8196 Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-30 15:21 ` [PATCH v2 1/9] dt-bindings: thermal: mediatek: Add LVTS thermal controller support for MT8196 Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 7:31 ` AngeloGioacchino Del Regno
2025-07-31 7:31 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 2/9] thermal/drivers/mediatek/lvts: Make number of calibration offsets configurable Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 3:10 ` Fei Shao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 3/9] thermal/drivers/mediatek/lvts: Guard against zero temp_factor in lvts_raw_to_temp Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 3:46 ` Fei Shao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 4/9] thermal: mediatek: lvts: Add platform ops to support alternative conversion logic Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 4:03 ` Fei Shao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 5/9] thermal/drivers/mediatek/lvts: Add lvts_temp_to_raw variant Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 4:06 ` Fei Shao
2025-07-31 9:10 ` Chen-Yu Tsai
2025-07-31 9:10 ` Chen-Yu Tsai
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 6/9] thermal/drivers/mediatek/lvts: Add support for ATP mode Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-31 4:25 ` Fei Shao
2025-07-31 10:14 ` Laura Nao
2025-08-01 4:44 ` Fei Shao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 7/9] thermal/drivers/mediatek/lvts: Support MSR offset for 16-bit calibration data Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 8/9] thermal/drivers/mediatek/lvts_thermal: Add MT8196 support Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-08-01 7:28 ` AngeloGioacchino Del Regno
2025-07-30 15:21 ` [PATCH v2 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196 Laura Nao
2025-07-30 15:21 ` Laura Nao
2025-07-30 23:54 ` Rob Herring [this message]
2025-07-30 23:54 ` Rob Herring
2025-07-31 10:26 ` Laura Nao
2025-07-31 10:26 ` Laura Nao
2025-08-03 8:18 ` Krzysztof Kozlowski
2025-08-03 8:18 ` Krzysztof Kozlowski
2025-07-31 7:26 ` AngeloGioacchino Del Regno
2025-07-31 7:26 ` AngeloGioacchino Del Regno
2025-07-31 7:28 ` AngeloGioacchino Del Regno
2025-07-31 7:28 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730235451.GA1911689-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=bchihi@baylibre.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=lala.lin@mediatek.com \
--cc=laura.nao@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=srini@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.