* Re: [PATCH] usb: atm: Fix kernel coding style
2025-07-31 1:41 [PATCH] usb: atm: Fix kernel coding style Li Jun
@ 2025-07-31 4:18 ` Greg KH
2025-07-31 11:58 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-07-31 4:18 UTC (permalink / raw)
To: Li Jun; +Cc: mingo, tglx, nathan, n.zhandarovich, linux-usb
On Thu, Jul 31, 2025 at 09:41:34AM +0800, Li Jun wrote:
> These changes just fix Linux Kernel Coding Style, no functuional
> improve.
>
> -Space prohibited after that open parenthesis '(',
> -Macros with complex values should be enclosed in parentheses.
>
> Signed-off-by: Li Jun <lijun01@kylinos.cn>
> ---
> drivers/usb/atm/cxacru.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/atm/cxacru.c b/drivers/usb/atm/cxacru.c
> index 68a8e9de8b4f..57d59fff8142 100644
> --- a/drivers/usb/atm/cxacru.c
> +++ b/drivers/usb/atm/cxacru.c
> @@ -196,13 +196,13 @@ static void cxacru_poll_status(struct work_struct *work);
>
> /* Card info exported through sysfs */
> #define CXACRU__ATTR_INIT(_name) \
> -static DEVICE_ATTR_RO(_name)
> +(static DEVICE_ATTR_RO(_name))
>
> #define CXACRU_CMD_INIT(_name) \
> -static DEVICE_ATTR_RW(_name)
> +(static DEVICE_ATTR_RW(_name))
>
> #define CXACRU_SET_INIT(_name) \
> -static DEVICE_ATTR_WO(_name)
> +(static DEVICE_ATTR_WO(_name))
>
> #define CXACRU_ATTR_INIT(_value, _type, _name) \
> static ssize_t _name##_show(struct device *dev, \
> @@ -513,7 +513,7 @@ CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_RATE, u32, downstream_rate); \
> CXACRU_ATTR_##_action(CXINF_UPSTREAM_RATE, u32, upstream_rate); \
> CXACRU_ATTR_##_action(CXINF_LINK_STATUS, LINK, link_status); \
> CXACRU_ATTR_##_action(CXINF_LINE_STATUS, LINE, line_status); \
> -CXACRU__ATTR_##_action( mac_address); \
> +CXACRU__ATTR_##_action(mac_address); \
> CXACRU_ATTR_##_action(CXINF_UPSTREAM_SNR_MARGIN, dB, upstream_snr_margin); \
> CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_SNR_MARGIN, dB, downstream_snr_margin); \
> CXACRU_ATTR_##_action(CXINF_UPSTREAM_ATTENUATION, dB, upstream_attenuation); \
> @@ -533,8 +533,8 @@ CXACRU_ATTR_##_action(CXINF_MODULATION, MODU, modulation); \
> CXACRU_ATTR_##_action(CXINF_ADSL_HEADEND, u32, adsl_headend); \
> CXACRU_ATTR_##_action(CXINF_ADSL_HEADEND_ENVIRONMENT, u32, adsl_headend_environment); \
> CXACRU_ATTR_##_action(CXINF_CONTROLLER_VERSION, u32, adsl_controller_version); \
> -CXACRU_CMD_##_action( adsl_state); \
> -CXACRU_SET_##_action( adsl_config);
> +CXACRU_CMD_##_action(adsl_state); \
> +CXACRU_SET_##_action(adsl_config);
>
> CXACRU_ALL_FILES(INIT);
>
> --
> 2.25.1
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: atm: Fix kernel coding style
2025-07-31 1:41 [PATCH] usb: atm: Fix kernel coding style Li Jun
2025-07-31 4:18 ` Greg KH
@ 2025-07-31 11:58 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2025-07-31 11:58 UTC (permalink / raw)
To: Li Jun, gregkh, mingo, tglx, nathan, n.zhandarovich, linux-usb
Cc: llvm, oe-kbuild-all
Hi Li,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus linus/master v6.16 next-20250731]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-Jun/usb-atm-Fix-kernel-coding-style/20250731-094241
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20250731014134.535119-1-lijun01%40kylinos.cn
patch subject: [PATCH] usb: atm: Fix kernel coding style
config: i386-buildonly-randconfig-003-20250731 (https://download.01.org/0day-ci/archive/20250731/202507311928.0ny4leMQ-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250731/202507311928.0ny4leMQ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507311928.0ny4leMQ-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:511:35: note: expanded from macro 'CXACRU_ALL_FILES'
511 | #define CXACRU_ALL_FILES(_action) \
| ^
<scratch space>:27:1: note: expanded from here
27 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:511:35: note: expanded from macro 'CXACRU_ALL_FILES'
511 | #define CXACRU_ALL_FILES(_action) \
| ^
<scratch space>:27:1: note: expanded from here
27 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:511:35: note: expanded from macro 'CXACRU_ALL_FILES'
511 | #define CXACRU_ALL_FILES(_action) \
| ^
<scratch space>:27:1: note: expanded from here
27 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:512:80: note: expanded from macro 'CXACRU_ALL_FILES'
512 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_RATE, u32, downstream_rate); \
| ^
<scratch space>:37:1: note: expanded from here
37 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:512:80: note: expanded from macro 'CXACRU_ALL_FILES'
512 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_RATE, u32, downstream_rate); \
| ^
<scratch space>:37:1: note: expanded from here
37 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:512:80: note: expanded from macro 'CXACRU_ALL_FILES'
512 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_RATE, u32, downstream_rate); \
| ^
<scratch space>:37:1: note: expanded from here
37 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:513:78: note: expanded from macro 'CXACRU_ALL_FILES'
513 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_RATE, u32, upstream_rate); \
| ^
<scratch space>:47:1: note: expanded from here
47 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:513:78: note: expanded from macro 'CXACRU_ALL_FILES'
513 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_RATE, u32, upstream_rate); \
| ^
<scratch space>:47:1: note: expanded from here
47 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:513:78: note: expanded from macro 'CXACRU_ALL_FILES'
513 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_RATE, u32, upstream_rate); \
| ^
<scratch space>:47:1: note: expanded from here
47 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:514:76: note: expanded from macro 'CXACRU_ALL_FILES'
514 | CXACRU_ATTR_##_action(CXINF_LINK_STATUS, LINK, link_status); \
| ^
<scratch space>:57:1: note: expanded from here
57 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:514:76: note: expanded from macro 'CXACRU_ALL_FILES'
514 | CXACRU_ATTR_##_action(CXINF_LINK_STATUS, LINK, link_status); \
| ^
<scratch space>:57:1: note: expanded from here
57 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:514:76: note: expanded from macro 'CXACRU_ALL_FILES'
514 | CXACRU_ATTR_##_action(CXINF_LINK_STATUS, LINK, link_status); \
| ^
<scratch space>:57:1: note: expanded from here
57 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:515:76: note: expanded from macro 'CXACRU_ALL_FILES'
515 | CXACRU_ATTR_##_action(CXINF_LINE_STATUS, LINE, line_status); \
| ^
<scratch space>:67:1: note: expanded from here
67 | CXACRU__ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro 'CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:515:76: note: expanded from macro 'CXACRU_ALL_FILES'
515 | CXACRU_ATTR_##_action(CXINF_LINE_STATUS, LINE, line_status); \
| ^
<scratch space>:67:1: note: expanded from here
67 | CXACRU__ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro 'CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:515:76: note: expanded from macro 'CXACRU_ALL_FILES'
515 | CXACRU_ATTR_##_action(CXINF_LINE_STATUS, LINE, line_status); \
| ^
<scratch space>:67:1: note: expanded from here
67 | CXACRU__ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro 'CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:516:38: note: expanded from macro 'CXACRU_ALL_FILES'
516 | CXACRU__ATTR_##_action(mac_address); \
| ^
<scratch space>:71:1: note: expanded from here
71 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:516:38: note: expanded from macro 'CXACRU_ALL_FILES'
516 | CXACRU__ATTR_##_action(mac_address); \
| ^
<scratch space>:71:1: note: expanded from here
71 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:516:38: note: expanded from macro 'CXACRU_ALL_FILES'
516 | CXACRU__ATTR_##_action(mac_address); \
| ^
<scratch space>:71:1: note: expanded from here
71 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:517:84: note: expanded from macro 'CXACRU_ALL_FILES'
517 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_SNR_MARGIN, dB, upstream_snr_margin); \
| ^
<scratch space>:81:1: note: expanded from here
81 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:517:84: note: expanded from macro 'CXACRU_ALL_FILES'
517 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_SNR_MARGIN, dB, upstream_snr_margin); \
| ^
<scratch space>:81:1: note: expanded from here
81 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:517:84: note: expanded from macro 'CXACRU_ALL_FILES'
517 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_SNR_MARGIN, dB, upstream_snr_margin); \
| ^
<scratch space>:81:1: note: expanded from here
81 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:518:86: note: expanded from macro 'CXACRU_ALL_FILES'
518 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_SNR_MARGIN, dB, downstream_snr_margin); \
| ^
<scratch space>:91:1: note: expanded from here
91 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:518:86: note: expanded from macro 'CXACRU_ALL_FILES'
518 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_SNR_MARGIN, dB, downstream_snr_margin); \
| ^
<scratch space>:91:1: note: expanded from here
91 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:518:86: note: expanded from macro 'CXACRU_ALL_FILES'
518 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_SNR_MARGIN, dB, downstream_snr_margin); \
| ^
<scratch space>:91:1: note: expanded from here
91 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:519:85: note: expanded from macro 'CXACRU_ALL_FILES'
519 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_ATTENUATION, dB, upstream_attenuation); \
| ^
<scratch space>:101:1: note: expanded from here
101 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected ')'
drivers/usb/atm/cxacru.c:519:85: note: expanded from macro 'CXACRU_ALL_FILES'
519 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_ATTENUATION, dB, upstream_attenuation); \
| ^
<scratch space>:101:1: note: expanded from here
101 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
drivers/usb/atm/cxacru.c:539:1: note: to match this '('
drivers/usb/atm/cxacru.c:519:85: note: expanded from macro 'CXACRU_ALL_FILES'
519 | CXACRU_ATTR_##_action(CXINF_UPSTREAM_ATTENUATION, dB, upstream_attenuation); \
| ^
<scratch space>:101:1: note: expanded from here
101 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:198:34: note: expanded from macro '\
CXACRU__ATTR_INIT'
198 | #define CXACRU__ATTR_INIT(_name) \
| ^
>> drivers/usb/atm/cxacru.c:539:1: error: expected identifier or '('
539 | CXACRU_ALL_FILES(INIT);
| ^
drivers/usb/atm/cxacru.c:520:87: note: expanded from macro 'CXACRU_ALL_FILES'
520 | CXACRU_ATTR_##_action(CXINF_DOWNSTREAM_ATTENUATION, dB, downstream_attenuation); \
| ^
<scratch space>:111:1: note: expanded from here
111 | CXACRU_ATTR_INIT
| ^
drivers/usb/atm/cxacru.c:218:3: note: expanded from macro 'CXACRU_ATTR_INIT'
218 | } \
| ^
drivers/usb/atm/cxacru.c:199:2: note: expanded from macro '\
CXACRU__ATTR_INIT'
199 | (static DEVICE_ATTR_RO(_name))
| ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +539 drivers/usb/atm/cxacru.c
fa70fe44aba95c Simon Arlott 2007-03-06 538
fa70fe44aba95c Simon Arlott 2007-03-06 @539 CXACRU_ALL_FILES(INIT);
fa70fe44aba95c Simon Arlott 2007-03-06 540
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread