All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "D. Wythe" <alibuda@linux.alibaba.com>,
	ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
	martin.lau@linux.dev, pabeni@redhat.com, song@kernel.org,
	sdf@google.com, haoluo@google.com, yhs@fb.com,
	edumazet@google.com, john.fastabend@gmail.com,
	kpsingh@kernel.org, jolsa@kernel.org, Mahanta.Jambigi@ibm.com,
	Sidraya.Jayagond@ibm.com, wenjia@linux.ibm.com,
	wintera@linux.ibm.com, dust.li@linux.alibaba.com,
	tonylu@linux.alibaba.com, guwen@linux.alibaba.com
Cc: oe-kbuild-all@lists.linux.dev, bpf@vger.kernel.org,
	davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
	jaka@linux.ibm.com
Subject: Re: [PATCH bpf-next 3/5] net/smc: bpf: Introduce generic hook for handshake flow
Date: Fri, 1 Aug 2025 03:55:24 +0800	[thread overview]
Message-ID: <202508010316.wuSPjSOr-lkp@intel.com> (raw)
In-Reply-To: <20250731084240.86550-4-alibuda@linux.alibaba.com>

Hi Wythe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/bpf-export-necessary-sympols-for-modules-with-struct_ops/20250731-164431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20250731084240.86550-4-alibuda%40linux.alibaba.com
patch subject: [PATCH bpf-next 3/5] net/smc: bpf: Introduce generic hook for handshake flow
config: arm-randconfig-003-20250801 (https://download.01.org/0day-ci/archive/20250801/202508010316.wuSPjSOr-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250801/202508010316.wuSPjSOr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508010316.wuSPjSOr-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv4/tcp_output.c: In function 'smc_set_option':
>> net/ipv4/tcp_output.c:773:15: warning: unused variable 'sk' [-Wunused-variable]
     773 |  struct sock *sk = &tp->inet_conn.icsk_inet.sk;
         |               ^~
   net/ipv4/tcp_output.c: In function 'smc_set_option_cond':
   net/ipv4/tcp_output.c:794:21: warning: unused variable 'sk' [-Wunused-variable]
     794 |  const struct sock *sk = &tp->inet_conn.icsk_inet.sk;
         |                     ^~


vim +/sk +773 net/ipv4/tcp_output.c

   767	
   768	static void smc_set_option(struct tcp_sock *tp,
   769				   struct tcp_out_options *opts,
   770				   unsigned int *remaining)
   771	{
   772	#if IS_ENABLED(CONFIG_SMC)
 > 773		struct sock *sk = &tp->inet_conn.icsk_inet.sk;
   774		if (static_branch_unlikely(&tcp_have_smc)) {
   775			if (tp->syn_smc) {
   776				tp->syn_smc = !!smc_call_hsbpf(1, sk, syn_option, tp);
   777				/* re-check syn_smc */
   778				if (tp->syn_smc &&
   779				    *remaining >= TCPOLEN_EXP_SMC_BASE_ALIGNED) {
   780					opts->options |= OPTION_SMC;
   781					*remaining -= TCPOLEN_EXP_SMC_BASE_ALIGNED;
   782				}
   783			}
   784		}
   785	#endif
   786	}
   787	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-07-31 19:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  8:42 [PATCH bpf-next 0/5] net/smc: Introduce smc_hs_ctrl D. Wythe
2025-07-31  8:42 ` [PATCH bpf-next 1/5] bpf: export necessary sympols for modules with struct_ops D. Wythe
2025-07-31 12:53   ` Alexandra Winter
2025-08-11  2:23     ` D. Wythe
2025-07-31  8:42 ` [PATCH bpf-next 2/5] net/smc: fix UAF on smcsk after smc_listen_out() D. Wythe
2025-07-31 12:57   ` Alexandra Winter
2025-08-11  1:54     ` D. Wythe
2025-08-11  9:24       ` Alexandra Winter
2025-08-11 15:33         ` Jakub Kicinski
2025-08-18  5:39           ` D. Wythe
2025-07-31  8:42 ` [PATCH bpf-next 3/5] net/smc: bpf: Introduce generic hook for handshake flow D. Wythe
2025-07-31 19:55   ` kernel test robot [this message]
2025-07-31  8:42 ` [PATCH bpf-next 4/5] libbpf: fix error when st-prefix_ops and ops from differ btf D. Wythe
2025-07-31  8:42 ` [PATCH bpf-next 5/5] bpf/selftests: add selftest for bpf_smc_hs_ctrl D. Wythe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202508010316.wuSPjSOr-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Mahanta.Jambigi@ibm.com \
    --cc=Sidraya.Jayagond@ibm.com \
    --cc=alibuda@linux.alibaba.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dust.li@linux.alibaba.com \
    --cc=edumazet@google.com \
    --cc=guwen@linux.alibaba.com \
    --cc=haoluo@google.com \
    --cc=jaka@linux.ibm.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=tonylu@linux.alibaba.com \
    --cc=wenjia@linux.ibm.com \
    --cc=wintera@linux.ibm.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.