Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250731125109.147422-1-biju.das.jz@bp.renesas.com>
References: <20250731125109.147422-1-biju.das.jz@bp.renesas.com>
TO: Biju <biju.das.au@gmail.com>
TO: Geert Uytterhoeven <geert+renesas@glider.be>
TO: Magnus Damm <magnus.damm@gmail.com>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
CC: Biju Das <biju.das.jz@bp.renesas.com>
CC: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
CC: linux-renesas-soc@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org

Hi Biju,

kernel test robot noticed the following build warnings:

[auto build test WARNING on geert-renesas-devel/next]
[also build test WARNING on linus/master v6.16 next-20250801]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biju/arm64-dts-renesas-rzg2lc-smarc-Fix-typo-for-deleting-node/20250731-205310
base:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
patch link:    https://lore.kernel.org/r/20250731125109.147422-1-biju.das.jz%40bp.renesas.com
patch subject: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: arm64-randconfig-051-20250801 (https://download.01.org/0day-ci/archive/20250802/202508021004.ITT3mtc4-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 15.1.0
dtschema version: 2025.6.2.dev4+g8f79ddd
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250802/202508021004.ITT3mtc4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202508021004.ITT3mtc4-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
   arch/arm64/boot/dts/renesas/r9a07g044.dtsi:827.12-835.7: Warning (graph_child_address): /soc/video@10830000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
   arch/arm64/boot/dts/renesas/r9a07g044.dtsi:837.12-846.7: Warning (graph_child_address): /soc/video@10830000/ports/port@1: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
   arch/arm64/boot/dts/renesas/r9a07g044.dtsi:872.12-881.7: Warning (graph_child_address): /soc/csi2@10830400/ports/port@1: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary
>> arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dtb: can@10050000 (renesas,r9a07g044-canfd): 'channel0' is a required property
   	from schema $id: http://devicetree.org/schemas/net/can/renesas,rcar-canfd.yaml#
--
>> arch/arm64/boot/dts/renesas/r9a07g044c2-smarc-cru-csi-ov5645.dtb: can@10050000 (renesas,r9a07g044-canfd): 'channel0' is a required property
   	from schema $id: http://devicetree.org/schemas/net/can/renesas,rcar-canfd.yaml#

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Fix typo for deleting node 'channel@0'->'channel0'.

Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD channel 1")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
index 345b779e4f60..382f6271cb29 100644
--- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
@@ -48,7 +48,7 @@ sound_card {
 #if (SW_SCIF_CAN || SW_RSPI_CAN)
 &canfd {
 	pinctrl-0 = <&can1_pins>;
-	/delete-node/ channel@0;
+	/delete-node/ channel0;
 };
 #else
 &canfd {
-- 
2.43.0

Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Rob Herring (Arm)]

On Thu, 31 Jul 2025 13:51:06 +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Fix typo for deleting node 'channel@0'->'channel0'.
> 
> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD channel 1")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: attempting to guess base-commit...
 Base: tags/next-20250729 (exact match)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/renesas/' for 20250731125109.147422-1-biju.das.jz@bp.renesas.com:

arch/arm64/boot/dts/renesas/r9a07g044c2-smarc.dtb: can@10050000 (renesas,r9a07g044-canfd): 'channel0' is a required property
	from schema $id: http://devicetree.org/schemas/net/can/renesas,rcar-canfd.yaml#

Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Geert Uytterhoeven]

Hi Biju,

On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@gmail.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Fix typo for deleting node 'channel@0'->'channel0'.
>
> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD channel 1")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> @@ -48,7 +48,7 @@ sound_card {
>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
>  &canfd {
>         pinctrl-0 = <&can1_pins>;
> -       /delete-node/ channel@0;
> +       /delete-node/ channel0;

As pointed out by Rob's bot, you must not delete this node.
Instead, set channel0's status to disabled.

>  };
>  #else
>  &canfd {

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Biju Das]

Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 01 August 2025 08:30
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
> 
> Hi Biju,
> 
> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@gmail.com> wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Fix typo for deleting node 'channel@0'->'channel0'.
> >
> > Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
> > channel 1")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> > @@ -48,7 +48,7 @@ sound_card {
> >  #if (SW_SCIF_CAN || SW_RSPI_CAN)
> >  &canfd {
> >         pinctrl-0 = <&can1_pins>;
> > -       /delete-node/ channel@0;
> > +       /delete-node/ channel0;
> 
> As pointed out by Rob's bot, you must not delete this node.
> Instead, set channel0's status to disabled.

OK. Will fix this in next version.

Cheers,
Biju

Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Krzysztof Kozlowski]

On 01/08/2025 10:11, Biju Das wrote:
> Hi Geert,
> 
> Thanks for the feedback.
> 
>> -----Original Message-----
>> From: Geert Uytterhoeven <geert@linux-m68k.org>
>> Sent: 01 August 2025 08:30
>> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
>>
>> Hi Biju,
>>
>> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@gmail.com> wrote:
>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>
>>> Fix typo for deleting node 'channel@0'->'channel0'.
>>>
>>> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable CANFD
>>> channel 1")
>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>
>> Thanks for your patch!
>>
>>> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
>>> @@ -48,7 +48,7 @@ sound_card {
>>>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
>>>  &canfd {
>>>         pinctrl-0 = <&can1_pins>;
>>> -       /delete-node/ channel@0;
>>> +       /delete-node/ channel0;
>>
>> As pointed out by Rob's bot, you must not delete this node.
>> Instead, set channel0's status to disabled.
> 
> OK. Will fix this in next version.

Please TEST your patch before sending it. This would avoid this entire
discussion.

Best regards,
Krzysztof

RE: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 01 August 2025 10:16
> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for deleting node
> 
> On 01/08/2025 10:11, Biju Das wrote:
> > Hi Geert,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Sent: 01 August 2025 08:30
> >> Subject: Re: [PATCH] arm64: dts: renesas: rzg2lc-smarc: Fix typo for
> >> deleting node
> >>
> >> Hi Biju,
> >>
> >> On Thu, 31 Jul 2025 at 14:51, Biju <biju.das.au@gmail.com> wrote:
> >>> From: Biju Das <biju.das.jz@bp.renesas.com>
> >>>
> >>> Fix typo for deleting node 'channel@0'->'channel0'.
> >>>
> >>> Fixes: 46da632734a5 ("arm64: dts: renesas: rzg2lc-smarc: Enable
> >>> CANFD channel 1")
> >>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>
> >> Thanks for your patch!
> >>
> >>> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> >>> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> >>> @@ -48,7 +48,7 @@ sound_card {
> >>>  #if (SW_SCIF_CAN || SW_RSPI_CAN)
> >>>  &canfd {
> >>>         pinctrl-0 = <&can1_pins>;
> >>> -       /delete-node/ channel@0;
> >>> +       /delete-node/ channel0;
> >>
> >> As pointed out by Rob's bot, you must not delete this node.
> >> Instead, set channel0's status to disabled.
> >
> > OK. Will fix this in next version.
> 
> Please TEST your patch before sending it. This would avoid this entire discussion.

Sorry for that. Will take care next time.

Cheers,
Biju