* [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
@ 2025-08-04 1:46 ` Jamin Lin via
0 siblings, 0 replies; 6+ messages in thread
From: Jamin Lin via @ 2025-08-04 1:46 UTC (permalink / raw)
To: Alistair Francis, Cédric Le Goater, Peter Maydell,
Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley,
open list:ASPEED BMCs, open list:All patches CC here
Cc: jamin_lin, troy_lee
On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
This issue is due to the aspeed_smc_read function, which checks for the
ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
feature flag, the read operation fails and returns -1.
To resolve this, add the WDT_CONTROL feature to AST1030's feature set
so that FMC_WDT2 can be correctly accessed by firmware.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/ssi/aspeed_smc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 614528b8ef..e33496f502 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -1857,7 +1857,8 @@ static void aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
asc->resets = aspeed_1030_fmc_resets;
asc->flash_window_base = 0x80000000;
asc->flash_window_size = 0x10000000;
- asc->features = ASPEED_SMC_FEATURE_DMA;
+ asc->features = ASPEED_SMC_FEATURE_DMA |
+ ASPEED_SMC_FEATURE_WDT_CONTROL;
asc->dma_flash_mask = 0x0FFFFFFC;
asc->dma_dram_mask = 0x000BFFFC;
asc->dma_start_length = 1;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
@ 2025-08-04 1:46 ` Jamin Lin via
0 siblings, 0 replies; 6+ messages in thread
From: Jamin Lin via @ 2025-08-04 1:46 UTC (permalink / raw)
To: Alistair Francis, Cédric Le Goater, Peter Maydell,
Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley,
open list:ASPEED BMCs, open list:All patches CC here
Cc: jamin_lin, troy_lee
On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
This issue is due to the aspeed_smc_read function, which checks for the
ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
feature flag, the read operation fails and returns -1.
To resolve this, add the WDT_CONTROL feature to AST1030's feature set
so that FMC_WDT2 can be correctly accessed by firmware.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/ssi/aspeed_smc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
index 614528b8ef..e33496f502 100644
--- a/hw/ssi/aspeed_smc.c
+++ b/hw/ssi/aspeed_smc.c
@@ -1857,7 +1857,8 @@ static void aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
asc->resets = aspeed_1030_fmc_resets;
asc->flash_window_base = 0x80000000;
asc->flash_window_size = 0x10000000;
- asc->features = ASPEED_SMC_FEATURE_DMA;
+ asc->features = ASPEED_SMC_FEATURE_DMA |
+ ASPEED_SMC_FEATURE_WDT_CONTROL;
asc->dma_flash_mask = 0x0FFFFFFC;
asc->dma_dram_mask = 0x000BFFFC;
asc->dma_start_length = 1;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
2025-08-04 1:46 ` Jamin Lin via
(?)
@ 2025-08-04 6:33 ` Cédric Le Goater
2025-08-04 6:41 ` Jamin Lin
-1 siblings, 1 reply; 6+ messages in thread
From: Cédric Le Goater @ 2025-08-04 6:33 UTC (permalink / raw)
To: Jamin Lin, Alistair Francis, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs,
open list:All patches CC here
Cc: troy_lee
Hello Jamin,
On 8/4/25 03:46, Jamin Lin wrote:
> On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
> This issue is due to the aspeed_smc_read function, which checks for the
> ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was missing this
> feature flag, the read operation fails and returns -1.
>
> To resolve this, add the WDT_CONTROL feature to AST1030's feature set
> so that FMC_WDT2 can be correctly accessed by firmware.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
> hw/ssi/aspeed_smc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c
> index 614528b8ef..e33496f502 100644
> --- a/hw/ssi/aspeed_smc.c
> +++ b/hw/ssi/aspeed_smc.c
> @@ -1857,7 +1857,8 @@ static void aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
> asc->resets = aspeed_1030_fmc_resets;
> asc->flash_window_base = 0x80000000;
> asc->flash_window_size = 0x10000000;
> - asc->features = ASPEED_SMC_FEATURE_DMA;
> + asc->features = ASPEED_SMC_FEATURE_DMA |
> + ASPEED_SMC_FEATURE_WDT_CONTROL;
> asc->dma_flash_mask = 0x0FFFFFFC;
> asc->dma_dram_mask = 0x000BFFFC;
> asc->dma_start_length = 1;
Could you add a Fixes tag please ?
I plan to send a PR before -rc2 (Tuesday) with the vbootrom update.
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Thanks,
C.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
2025-08-04 6:33 ` Cédric Le Goater
@ 2025-08-04 6:41 ` Jamin Lin
2025-08-04 6:52 ` Cédric Le Goater
0 siblings, 1 reply; 6+ messages in thread
From: Jamin Lin @ 2025-08-04 6:41 UTC (permalink / raw)
To: Cédric Le Goater, Alistair Francis, Peter Maydell,
Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley,
open list:ASPEED BMCs, open list:All patches CC here
Cc: Troy Lee
Hi Cédric,
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Monday, August 4, 2025 2:33 PM
> To: Jamin Lin <jamin_lin@aspeedtech.com>; Alistair Francis
> <alistair@alistair23.me>; Peter Maydell <peter.maydell@linaro.org>; Steven
> Lee <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Andrew
> Jeffery <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; open
> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_lee@aspeedtech.com>
> Subject: Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register
> read on AST1030
>
> Hello Jamin,
>
> On 8/4/25 03:46, Jamin Lin wrote:
> > On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
> > This issue is due to the aspeed_smc_read function, which checks for
> > the ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was
> missing
> > this feature flag, the read operation fails and returns -1.
> >
> > To resolve this, add the WDT_CONTROL feature to AST1030's feature set
> > so that FMC_WDT2 can be correctly accessed by firmware.
> >
> > Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> > ---
> > hw/ssi/aspeed_smc.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index
> > 614528b8ef..e33496f502 100644
> > --- a/hw/ssi/aspeed_smc.c
> > +++ b/hw/ssi/aspeed_smc.c
> > @@ -1857,7 +1857,8 @@ static void
> aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
> > asc->resets = aspeed_1030_fmc_resets;
> > asc->flash_window_base = 0x80000000;
> > asc->flash_window_size = 0x10000000;
> > - asc->features = ASPEED_SMC_FEATURE_DMA;
> > + asc->features = ASPEED_SMC_FEATURE_DMA |
> > +
> ASPEED_SMC_FEATURE_WDT_CONTROL;
> > asc->dma_flash_mask = 0x0FFFFFFC;
> > asc->dma_dram_mask = 0x000BFFFC;
> > asc->dma_start_length = 1;
>
> Could you add a Fixes tag please ?
>
Fixes: 2850df6 ("aspeed/smc: Add AST1030 support ")
> I plan to send a PR before -rc2 (Tuesday) with the vbootrom update.
>
Okay. Thanks for review and help.
Jamin
> Reviewed-by: Cédric Le Goater <clg@redhat.com>
>
> Thanks,
>
> C.
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
2025-08-04 6:41 ` Jamin Lin
@ 2025-08-04 6:52 ` Cédric Le Goater
2025-08-04 6:55 ` Jamin Lin
0 siblings, 1 reply; 6+ messages in thread
From: Cédric Le Goater @ 2025-08-04 6:52 UTC (permalink / raw)
To: Jamin Lin, Alistair Francis, Peter Maydell, Steven Lee, Troy Lee,
Andrew Jeffery, Joel Stanley, open list:ASPEED BMCs,
open list:All patches CC here
Cc: Troy Lee
On 8/4/25 08:41, Jamin Lin wrote:
> Hi Cédric,
>
>> From: Cédric Le Goater <clg@kaod.org>
>> Sent: Monday, August 4, 2025 2:33 PM
>> To: Jamin Lin <jamin_lin@aspeedtech.com>; Alistair Francis
>> <alistair@alistair23.me>; Peter Maydell <peter.maydell@linaro.org>; Steven
>> Lee <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Andrew
>> Jeffery <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; open
>> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
>> <qemu-devel@nongnu.org>
>> Cc: Troy Lee <troy_lee@aspeedtech.com>
>> Subject: Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register
>> read on AST1030
>>
>> Hello Jamin,
>>
>> On 8/4/25 03:46, Jamin Lin wrote:
>>> On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
>>> This issue is due to the aspeed_smc_read function, which checks for
>>> the ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was
>> missing
>>> this feature flag, the read operation fails and returns -1.
>>>
>>> To resolve this, add the WDT_CONTROL feature to AST1030's feature set
>>> so that FMC_WDT2 can be correctly accessed by firmware.
>>>
>>> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
>>> ---
>>> hw/ssi/aspeed_smc.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index
>>> 614528b8ef..e33496f502 100644
>>> --- a/hw/ssi/aspeed_smc.c
>>> +++ b/hw/ssi/aspeed_smc.c
>>> @@ -1857,7 +1857,8 @@ static void
>> aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
>>> asc->resets = aspeed_1030_fmc_resets;
>>> asc->flash_window_base = 0x80000000;
>>> asc->flash_window_size = 0x10000000;
>>> - asc->features = ASPEED_SMC_FEATURE_DMA;
>>> + asc->features = ASPEED_SMC_FEATURE_DMA |
>>> +
>> ASPEED_SMC_FEATURE_WDT_CONTROL;
>>> asc->dma_flash_mask = 0x0FFFFFFC;
>>> asc->dma_dram_mask = 0x000BFFFC;
>>> asc->dma_start_length = 1;
>>
>> Could you add a Fixes tag please ?
>>
> Fixes: 2850df6 ("aspeed/smc: Add AST1030 support ")
The commit SHA id is a bit short. 12 is a minimum now.
Thanks,
C.
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030
2025-08-04 6:52 ` Cédric Le Goater
@ 2025-08-04 6:55 ` Jamin Lin
0 siblings, 0 replies; 6+ messages in thread
From: Jamin Lin @ 2025-08-04 6:55 UTC (permalink / raw)
To: Cédric Le Goater, Alistair Francis, Peter Maydell,
Steven Lee, Troy Lee, Andrew Jeffery, Joel Stanley,
open list:ASPEED BMCs, open list:All patches CC here
Cc: Troy Lee
Hi Cédric,
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Monday, August 4, 2025 2:52 PM
> To: Jamin Lin <jamin_lin@aspeedtech.com>; Alistair Francis
> <alistair@alistair23.me>; Peter Maydell <peter.maydell@linaro.org>; Steven
> Lee <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Andrew
> Jeffery <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; open
> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_lee@aspeedtech.com>
> Subject: Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register
> read on AST1030
>
> On 8/4/25 08:41, Jamin Lin wrote:
> > Hi Cédric,
> >
> >> From: Cédric Le Goater <clg@kaod.org>
> >> Sent: Monday, August 4, 2025 2:33 PM
> >> To: Jamin Lin <jamin_lin@aspeedtech.com>; Alistair Francis
> >> <alistair@alistair23.me>; Peter Maydell <peter.maydell@linaro.org>;
> >> Steven Lee <steven_lee@aspeedtech.com>; Troy Lee
> <leetroy@gmail.com>;
> >> Andrew Jeffery <andrew@codeconstruct.com.au>; Joel Stanley
> >> <joel@jms.id.au>; open list:ASPEED BMCs <qemu-arm@nongnu.org>; open
> >> list:All patches CC here <qemu-devel@nongnu.org>
> >> Cc: Troy Lee <troy_lee@aspeedtech.com>
> >> Subject: Re: [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2
> >> register read on AST1030
> >>
> >> Hello Jamin,
> >>
> >> On 8/4/25 03:46, Jamin Lin wrote:
> >>> On AST1030, reading the FMC_WDT2 register always returns 0xFFFFFFFF.
> >>> This issue is due to the aspeed_smc_read function, which checks for
> >>> the ASPEED_SMC_FEATURE_WDT_CONTROL feature. Since AST1030 was
> >> missing
> >>> this feature flag, the read operation fails and returns -1.
> >>>
> >>> To resolve this, add the WDT_CONTROL feature to AST1030's feature
> >>> set so that FMC_WDT2 can be correctly accessed by firmware.
> >>>
> >>> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> >>> ---
> >>> hw/ssi/aspeed_smc.c | 3 ++-
> >>> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index
> >>> 614528b8ef..e33496f502 100644
> >>> --- a/hw/ssi/aspeed_smc.c
> >>> +++ b/hw/ssi/aspeed_smc.c
> >>> @@ -1857,7 +1857,8 @@ static void
> >> aspeed_1030_fmc_class_init(ObjectClass *klass, const void *data)
> >>> asc->resets = aspeed_1030_fmc_resets;
> >>> asc->flash_window_base = 0x80000000;
> >>> asc->flash_window_size = 0x10000000;
> >>> - asc->features = ASPEED_SMC_FEATURE_DMA;
> >>> + asc->features = ASPEED_SMC_FEATURE_DMA |
> >>> +
> >> ASPEED_SMC_FEATURE_WDT_CONTROL;
> >>> asc->dma_flash_mask = 0x0FFFFFFC;
> >>> asc->dma_dram_mask = 0x000BFFFC;
> >>> asc->dma_start_length = 1;
> >>
> >> Could you add a Fixes tag please ?
> >>
> > Fixes: 2850df6 ("aspeed/smc: Add AST1030 support ")
>
> The commit SHA id is a bit short. 12 is a minimum now.
>
Update SHA id
Fixes: 2850df6a81bcdc2e063dfdd56751ee2d11c58030 ("aspeed/smc: Add AST1030 support ")
Thanks-Jamin
> Thanks,
>
> C.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-08-04 6:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-04 1:46 [PATCH v1] hw/ssi/aspeed_smc: Fix incorrect FMC_WDT2 register read on AST1030 Jamin Lin via
2025-08-04 1:46 ` Jamin Lin via
2025-08-04 6:33 ` Cédric Le Goater
2025-08-04 6:41 ` Jamin Lin
2025-08-04 6:52 ` Cédric Le Goater
2025-08-04 6:55 ` Jamin Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.