All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@meta.com>
To: <linux-block@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Cc: <snitzer@kernel.org>, <axboe@kernel.dk>, <dw@davidwei.uk>,
	<brauner@kernel.org>, Keith Busch <kbusch@kernel.org>,
	Hannes Reinecke <hare@suse.de>
Subject: [PATCHv2 1/7] block: check for valid bio while splitting
Date: Tue, 5 Aug 2025 07:11:17 -0700	[thread overview]
Message-ID: <20250805141123.332298-2-kbusch@meta.com> (raw)
In-Reply-To: <20250805141123.332298-1-kbusch@meta.com>

From: Keith Busch <kbusch@kernel.org>

We're already iterating every segment, so check these for a valid IO at
the same time.

Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
 block/blk-merge.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/block/blk-merge.c b/block/blk-merge.c
index 70d704615be52..81bdad915699a 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -298,6 +298,9 @@ int bio_split_rw_at(struct bio *bio, const struct queue_limits *lim,
 	unsigned nsegs = 0, bytes = 0;
 
 	bio_for_each_bvec(bv, bio, iter) {
+		if (bv.bv_offset & lim->dma_alignment)
+			return -EINVAL;
+
 		/*
 		 * If the queue doesn't support SG gaps and adding this
 		 * offset would create a gap, disallow it.
@@ -341,6 +344,8 @@ int bio_split_rw_at(struct bio *bio, const struct queue_limits *lim,
 	 * we do not use the full hardware limits.
 	 */
 	bytes = ALIGN_DOWN(bytes, bio_split_alignment(bio, lim));
+	if (!bytes)
+		return -EINVAL;
 
 	/*
 	 * Bio splitting may cause subtle trouble such as hang when doing sync
-- 
2.47.3


  reply	other threads:[~2025-08-05 14:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05 14:11 [PATCHv2 0/7] direct-io: even more flexible io vectors Keith Busch
2025-08-05 14:11 ` Keith Busch [this message]
2025-08-10 14:37   ` [PATCHv2 1/7] block: check for valid bio while splitting Christoph Hellwig
2025-08-10 15:39     ` Keith Busch
2025-08-10 17:14       ` Christoph Hellwig
2025-08-13 20:06   ` Keith Busch
2025-08-13 20:41     ` Bart Van Assche
2025-08-13 21:01       ` Keith Busch
2025-08-13 23:17         ` Bart Van Assche
2025-08-14  1:42         ` Damien Le Moal
2025-08-13 21:23     ` Martin K. Petersen
2025-08-13 21:52       ` Keith Busch
2025-08-18  4:49         ` Christoph Hellwig
2025-08-05 14:11 ` [PATCHv2 2/7] block: align the bio after building it Keith Busch
2025-08-06  6:07   ` Hannes Reinecke
2025-08-10 14:43   ` Christoph Hellwig
2025-08-05 14:11 ` [PATCHv2 3/7] block: simplify direct io validity check Keith Busch
2025-08-05 14:11 ` [PATCHv2 4/7] iomap: " Keith Busch
2025-08-06  6:07   ` Hannes Reinecke
2025-08-05 14:11 ` [PATCHv2 5/7] block: remove bdev_iter_is_aligned Keith Busch
2025-08-05 14:11 ` [PATCHv2 6/7] blk-integrity: use simpler alignment check Keith Busch
2025-08-05 14:11 ` [PATCHv2 7/7] iov_iter: remove iov_iter_is_aligned Keith Busch
2025-08-06  6:08   ` Hannes Reinecke
2025-08-06  3:03 ` [PATCHv2 0/7] direct-io: even more flexible io vectors Martin K. Petersen
2025-08-06 14:51 ` Christoph Hellwig
2025-08-07 23:20   ` Keith Busch
2025-08-11 10:32     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250805141123.332298-2-kbusch@meta.com \
    --to=kbusch@meta.com \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=dw@davidwei.uk \
    --cc=hare@suse.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.