From: Simon Horman <horms@kernel.org>
To: David Hill <dhill@redhat.com>
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Subject: Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit
Date: Tue, 5 Aug 2025 20:52:49 +0100 [thread overview]
Message-ID: <20250805195249.GB61519@horms.kernel.org> (raw)
In-Reply-To: <20250805134042.2604897-2-dhill@redhat.com>
On Tue, Aug 05, 2025 at 09:40:42AM -0400, David Hill wrote:
> When a VF reaches the limit introduced in this commit [1], the driver
> refuses to add any more MACs to the filter which changes the behavior
> from previous releases and might break some NFVs which sometimes add
> more VFs than the hardcoded limit of 18 and variable limit depending
> on the number of VFs created on a given PF. Disabling limit_mac_per_vf
> would revert to previous behavior.
>
> [1] commit cfb1d572c986 ("i40e: Add ensurance of MacVlan resources for every
> trusted VF")
>
> Signed-off-by: David Hill <dhill@redhat.com>
Hi David,
Unfortunately adding new module parameters to Ethernet drivers is discouraged.
I would suggest that devlink is an appropriate mechanism.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2025-08-05 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 13:40 [PATCH 1/2] PATCH: i40e Improve trusted VF MAC addresses logging when limit is reached David Hill
2025-08-05 13:40 ` [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit David Hill
2025-08-05 19:52 ` Simon Horman [this message]
2025-08-07 16:17 ` Jacob Keller
2025-08-08 13:01 ` Simon Horman
[not found] ` <CANQtZ2wffk6jUTTMYFgTYxWQBc=hmw7nAkbYB2kxt-1ihUP9Rw@mail.gmail.com>
2025-08-20 13:09 ` mohammad heib
2025-08-20 20:35 ` Jacob Keller
[not found] ` <24473594-c77d-44f5-9311-57d67c558cb7@redhat.com>
2025-08-21 15:30 ` Jacob Keller
2025-08-05 19:47 ` [PATCH 1/2] PATCH: i40e Improve trusted VF MAC addresses logging when limit is reached Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805195249.GB61519@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=dhill@redhat.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.