Re: [PATCH 2/2] PATCH: i40e Add module option to disable max VF limit

[Jacob Keller <jacob.e.keller@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1213 bytes --]



On 8/21/2025 2:58 AM, mohammad heib wrote:
> Hi
> i defiantly agree with you Jacob
> 
> maybe to avoid removing the params in the future we can implement it 
> this way:
> 
> Instead of a simple boolean parameter, we can introduce a *numeric 
> |max_mac_per_vf| parameter*.
> 
>   *
> 
>     If set to |0|, the driver behaves as legacy (no per-VF limit).
> 
>   *
> 
>     Any non-zero value enforces that maximum number of MACs per VF.
> 
> 
> 
> This design addresses concerns about removing a parameter in the future 
> because:
> 
>   * The parameter can *coexist with a future devlink resource-per-VF
>     implementation*.
>   * if a hierarchy of resources is added later, |max_mac_per_vf = 0|
>     could automatically defer to the resource values, while a non-zero
>     value can act as an override.
>   * This numeric parameter is more flexible than a boolean and easier to
>     extend or adjust at runtime (via devlink in the future).
> 
> I think this is a reasonable *short-term solution* that preserves 
> backward compatibility while allowing for a *long-term devlink 
> resource-based design*.
> 

This seems like a good approach to me.

Thanks,
Jake

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]