All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jialin Wang <wjl.linux@gmail.com>
To: Penglei Jiang <superman.xpt@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Jialin Wang <wjl.linux@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] proc: proc_maps_open allow proc_mem_open to return NULL
Date: Fri,  8 Aug 2025 00:54:55 +0800	[thread overview]
Message-ID: <20250807165455.73656-1-wjl.linux@gmail.com> (raw)

The commit 65c66047259f ("proc: fix the issue of proc_mem_open returning NULL")
breaks `perf record -g -p PID` when profiling a kernel thread.

The strace of `perf record -g -p $(pgrep kswapd0)` shows:

  openat(AT_FDCWD, "/proc/65/task/65/maps", O_RDONLY) = -1 ESRCH (No such process)

This patch partially reverts the commit to fix it.

Fixes: 65c66047259f ("proc: fix the issue of proc_mem_open returning NULL")
Signed-off-by: Jialin Wang <wjl.linux@gmail.com>
---
 fs/proc/task_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 3d6d8a9f13fc..7a7ce26106ac 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -340,8 +340,8 @@ static int proc_maps_open(struct inode *inode, struct file *file,
 
 	priv->inode = inode;
 	priv->mm = proc_mem_open(inode, PTRACE_MODE_READ);
-	if (IS_ERR_OR_NULL(priv->mm)) {
-		int err = priv->mm ? PTR_ERR(priv->mm) : -ESRCH;
+	if (IS_ERR(priv->mm)) {
+		int err = PTR_ERR(priv->mm);
 
 		seq_release_private(inode, file);
 		return err;
-- 
2.50.0


             reply	other threads:[~2025-08-07 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-07 16:54 Jialin Wang [this message]
2025-08-07 22:46 ` [PATCH] proc: proc_maps_open allow proc_mem_open to return NULL Andrew Morton
2025-08-08 12:53   ` [PATCH v2] " Jialin Wang
  -- strict thread matches above, loose matches on Subject: below --
2025-08-14 16:09 [PATCH] " Dennis Beier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250807165455.73656-1-wjl.linux@gmail.com \
    --to=wjl.linux@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=superman.xpt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.