* [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
@ 2025-08-08 3:59 Liao Yuanhong
2025-08-08 7:39 ` Tomi Valkeinen
2025-08-08 7:55 ` Luca Ceresoli
0 siblings, 2 replies; 3+ messages in thread
From: Liao Yuanhong @ 2025-08-08 3:59 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Aradhya Bhatia,
Dmitry Baryshkov, Tomi Valkeinen, Luca Ceresoli,
open list:DRM DRIVERS, open list
Cc: Liao Yuanhong
kzalloc() has already been initialized to full 0 space, there is no need to
use memset() to initialize again.
Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
---
Changes in v2:
Modify the subject prefix.
---
drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
index a57ca8c3bdae..590f7c75744e 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
@@ -1047,7 +1047,6 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge)
if (!dsi_state)
return NULL;
- memset(dsi_state, 0, sizeof(*dsi_state));
dsi_state->base.bridge = bridge;
return &dsi_state->base;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
2025-08-08 3:59 [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset Liao Yuanhong
@ 2025-08-08 7:39 ` Tomi Valkeinen
2025-08-08 7:55 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2025-08-08 7:39 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Aradhya Bhatia,
Dmitry Baryshkov, Luca Ceresoli, open list:DRM DRIVERS, open list
Hi,
On 08/08/2025 06:59, Liao Yuanhong wrote:
> kzalloc() has already been initialized to full 0 space, there is no need to
> use memset() to initialize again.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
> ---
> Changes in v2:
> Modify the subject prefix.
> ---
> drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> index a57ca8c3bdae..590f7c75744e 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
> @@ -1047,7 +1047,6 @@ cdns_dsi_bridge_atomic_reset(struct drm_bridge *bridge)
> if (!dsi_state)
> return NULL;
>
> - memset(dsi_state, 0, sizeof(*dsi_state));
> dsi_state->base.bridge = bridge;
>
> return &dsi_state->base;
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset
2025-08-08 3:59 [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset Liao Yuanhong
2025-08-08 7:39 ` Tomi Valkeinen
@ 2025-08-08 7:55 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2025-08-08 7:55 UTC (permalink / raw)
To: Liao Yuanhong
Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Aradhya Bhatia,
Dmitry Baryshkov, Tomi Valkeinen, open list:DRM DRIVERS,
open list
On Fri, 8 Aug 2025 11:59:37 +0800
Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
> kzalloc() has already been initialized to full 0 space, there is no need to
> use memset() to initialize again.
>
> Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-08 7:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-08 3:59 [PATCH v2] drm/bridge: cdns-dsi: Remove unnecessary memset Liao Yuanhong
2025-08-08 7:39 ` Tomi Valkeinen
2025-08-08 7:55 ` Luca Ceresoli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.