From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org, fsverity@lists.linux.dev
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v5 03/13] ext4: move crypt info pointer to fs-specific part of inode
Date: Sun, 10 Aug 2025 00:56:56 -0700 [thread overview]
Message-ID: <20250810075706.172910-4-ebiggers@kernel.org> (raw)
In-Reply-To: <20250810075706.172910-1-ebiggers@kernel.org>
Move the fscrypt_inode_info pointer into the filesystem-specific part of
the inode by adding the field ext4_inode_info::i_crypt_info and
configuring fscrypt_operations::inode_info_offs accordingly.
This is a prerequisite for a later commit that removes
inode::i_crypt_info, saving memory and improving cache efficiency with
filesystems that don't support fscrypt.
Co-developed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/ext4/crypto.c | 2 ++
fs/ext4/ext4.h | 4 ++++
fs/ext4/super.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index 0a056d97e6402..cf0a0970c0956 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -225,10 +225,12 @@ static bool ext4_has_stable_inodes(struct super_block *sb)
{
return ext4_has_feature_stable_inodes(sb);
}
const struct fscrypt_operations ext4_cryptops = {
+ .inode_info_offs = (int)offsetof(struct ext4_inode_info, i_crypt_info) -
+ (int)offsetof(struct ext4_inode_info, vfs_inode),
.needs_bounce_pages = 1,
.has_32bit_inodes = 1,
.supports_subblock_data_units = 1,
.legacy_key_prefix = "ext4:",
.get_context = ext4_get_context,
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 01a6e2de7fc3e..c897109dadb15 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1180,10 +1180,14 @@ struct ext4_inode_info {
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
kprojid_t i_projid;
+
+#ifdef CONFIG_FS_ENCRYPTION
+ struct fscrypt_inode_info *i_crypt_info;
+#endif
};
/*
* File system states
*/
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c7d39da7e733b..0c3059ecce37c 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1468,10 +1468,13 @@ static void init_once(void *foo)
INIT_LIST_HEAD(&ei->i_orphan);
init_rwsem(&ei->xattr_sem);
init_rwsem(&ei->i_data_sem);
inode_init_once(&ei->vfs_inode);
ext4_fc_init_inode(&ei->vfs_inode);
+#ifdef CONFIG_FS_ENCRYPTION
+ ei->i_crypt_info = NULL;
+#endif
}
static int __init init_inodecache(void)
{
ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
--
2.50.1
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-fscrypt@vger.kernel.org, fsverity@lists.linux.dev
Cc: Christian Brauner <brauner@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
Eric Biggers <ebiggers@kernel.org>,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: [f2fs-dev] [PATCH v5 03/13] ext4: move crypt info pointer to fs-specific part of inode
Date: Sun, 10 Aug 2025 00:56:56 -0700 [thread overview]
Message-ID: <20250810075706.172910-4-ebiggers@kernel.org> (raw)
In-Reply-To: <20250810075706.172910-1-ebiggers@kernel.org>
Move the fscrypt_inode_info pointer into the filesystem-specific part of
the inode by adding the field ext4_inode_info::i_crypt_info and
configuring fscrypt_operations::inode_info_offs accordingly.
This is a prerequisite for a later commit that removes
inode::i_crypt_info, saving memory and improving cache efficiency with
filesystems that don't support fscrypt.
Co-developed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/ext4/crypto.c | 2 ++
fs/ext4/ext4.h | 4 ++++
fs/ext4/super.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index 0a056d97e6402..cf0a0970c0956 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -225,10 +225,12 @@ static bool ext4_has_stable_inodes(struct super_block *sb)
{
return ext4_has_feature_stable_inodes(sb);
}
const struct fscrypt_operations ext4_cryptops = {
+ .inode_info_offs = (int)offsetof(struct ext4_inode_info, i_crypt_info) -
+ (int)offsetof(struct ext4_inode_info, vfs_inode),
.needs_bounce_pages = 1,
.has_32bit_inodes = 1,
.supports_subblock_data_units = 1,
.legacy_key_prefix = "ext4:",
.get_context = ext4_get_context,
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 01a6e2de7fc3e..c897109dadb15 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1180,10 +1180,14 @@ struct ext4_inode_info {
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
kprojid_t i_projid;
+
+#ifdef CONFIG_FS_ENCRYPTION
+ struct fscrypt_inode_info *i_crypt_info;
+#endif
};
/*
* File system states
*/
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c7d39da7e733b..0c3059ecce37c 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1468,10 +1468,13 @@ static void init_once(void *foo)
INIT_LIST_HEAD(&ei->i_orphan);
init_rwsem(&ei->xattr_sem);
init_rwsem(&ei->i_data_sem);
inode_init_once(&ei->vfs_inode);
ext4_fc_init_inode(&ei->vfs_inode);
+#ifdef CONFIG_FS_ENCRYPTION
+ ei->i_crypt_info = NULL;
+#endif
}
static int __init init_inodecache(void)
{
ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
--
2.50.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org, fsverity@lists.linux.dev
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-mtd@lists.infradead.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v5 03/13] ext4: move crypt info pointer to fs-specific part of inode
Date: Sun, 10 Aug 2025 00:56:56 -0700 [thread overview]
Message-ID: <20250810075706.172910-4-ebiggers@kernel.org> (raw)
In-Reply-To: <20250810075706.172910-1-ebiggers@kernel.org>
Move the fscrypt_inode_info pointer into the filesystem-specific part of
the inode by adding the field ext4_inode_info::i_crypt_info and
configuring fscrypt_operations::inode_info_offs accordingly.
This is a prerequisite for a later commit that removes
inode::i_crypt_info, saving memory and improving cache efficiency with
filesystems that don't support fscrypt.
Co-developed-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---
fs/ext4/crypto.c | 2 ++
fs/ext4/ext4.h | 4 ++++
fs/ext4/super.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/fs/ext4/crypto.c b/fs/ext4/crypto.c
index 0a056d97e6402..cf0a0970c0956 100644
--- a/fs/ext4/crypto.c
+++ b/fs/ext4/crypto.c
@@ -225,10 +225,12 @@ static bool ext4_has_stable_inodes(struct super_block *sb)
{
return ext4_has_feature_stable_inodes(sb);
}
const struct fscrypt_operations ext4_cryptops = {
+ .inode_info_offs = (int)offsetof(struct ext4_inode_info, i_crypt_info) -
+ (int)offsetof(struct ext4_inode_info, vfs_inode),
.needs_bounce_pages = 1,
.has_32bit_inodes = 1,
.supports_subblock_data_units = 1,
.legacy_key_prefix = "ext4:",
.get_context = ext4_get_context,
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 01a6e2de7fc3e..c897109dadb15 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -1180,10 +1180,14 @@ struct ext4_inode_info {
/* Precomputed uuid+inum+igen checksum for seeding inode checksums */
__u32 i_csum_seed;
kprojid_t i_projid;
+
+#ifdef CONFIG_FS_ENCRYPTION
+ struct fscrypt_inode_info *i_crypt_info;
+#endif
};
/*
* File system states
*/
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c7d39da7e733b..0c3059ecce37c 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1468,10 +1468,13 @@ static void init_once(void *foo)
INIT_LIST_HEAD(&ei->i_orphan);
init_rwsem(&ei->xattr_sem);
init_rwsem(&ei->i_data_sem);
inode_init_once(&ei->vfs_inode);
ext4_fc_init_inode(&ei->vfs_inode);
+#ifdef CONFIG_FS_ENCRYPTION
+ ei->i_crypt_info = NULL;
+#endif
}
static int __init init_inodecache(void)
{
ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
--
2.50.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2025-08-10 8:00 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 7:56 [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:56 ` [PATCH v5 01/13] fscrypt: replace raw loads of info pointer with helper function Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:56 ` [PATCH v5 02/13] fscrypt: add support for info in fs-specific part of inode Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:56 ` Eric Biggers [this message]
2025-08-10 7:56 ` [PATCH v5 03/13] ext4: move crypt info pointer to " Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-11 11:13 ` Theodore Ts'o
2025-08-11 11:13 ` Theodore Ts'o
2025-08-11 11:13 ` [f2fs-dev] " Theodore Ts'o
2025-08-10 7:56 ` [PATCH v5 04/13] f2fs: " Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:56 ` [PATCH v5 05/13] ubifs: " Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:56 ` [PATCH v5 06/13] ceph: " Eric Biggers
2025-08-10 7:56 ` Eric Biggers
2025-08-10 7:56 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 07/13] fs: remove inode::i_crypt_info Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 08/13] fsverity: add support for info in fs-specific part of inode Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 09/13] ext4: move verity info pointer to " Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-11 11:13 ` Theodore Ts'o
2025-08-11 11:13 ` Theodore Ts'o
2025-08-11 11:13 ` [f2fs-dev] " Theodore Ts'o
2025-08-10 7:57 ` [PATCH v5 10/13] f2fs: " Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 11/13] btrfs: " Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 12/13] fs: remove inode::i_verity_info Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 7:57 ` [PATCH v5 13/13] fsverity: check IS_VERITY() in fsverity_cleanup_inode() Eric Biggers
2025-08-10 7:57 ` Eric Biggers
2025-08-10 7:57 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 8:47 ` [PATCH v5 00/13] Move fscrypt and fsverity info out of struct inode Christian Brauner
2025-08-10 8:47 ` Christian Brauner
2025-08-10 8:47 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2025-08-10 9:03 ` Eric Biggers
2025-08-10 9:03 ` Eric Biggers
2025-08-10 9:03 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-11 13:17 ` Christian Brauner
2025-08-11 13:17 ` Christian Brauner
2025-08-11 13:17 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2025-08-11 13:34 ` Christian Brauner
2025-08-11 13:34 ` Christian Brauner
2025-08-11 13:34 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2025-08-11 16:39 ` Eric Biggers
2025-08-11 16:39 ` Eric Biggers
2025-08-11 16:39 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-15 14:28 ` Christian Brauner
2025-08-15 14:28 ` Christian Brauner
2025-08-15 14:28 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2025-08-10 14:49 ` Christoph Hellwig
2025-08-10 14:49 ` Christoph Hellwig
2025-08-10 14:49 ` [f2fs-dev] " Christoph Hellwig
2025-08-10 17:03 ` Eric Biggers
2025-08-10 17:03 ` Eric Biggers
2025-08-10 17:03 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2025-08-10 17:14 ` Christoph Hellwig
2025-08-10 17:14 ` Christoph Hellwig
2025-08-10 17:14 ` [f2fs-dev] " Christoph Hellwig
2025-08-11 13:35 ` Christian Brauner
2025-08-11 13:35 ` Christian Brauner
2025-08-11 13:35 ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250810075706.172910-4-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=brauner@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=fsverity@lists.linux.dev \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.