From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Bijan Tabatabai <bijan311@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, sj@kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
corbet@lwn.net, Bijan Tabatabai <bijantabatab@micron.com>
Subject: Re: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
Date: Mon, 11 Aug 2025 10:00:50 +0300 [thread overview]
Message-ID: <202508101330.XRQqvfiN-lkp@intel.com> (raw)
In-Reply-To: <20250805162022.4920-3-bijan311@gmail.com>
Hi Bijan,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Bijan-Tabatabai/mm-damon-core-Add-damos_destroy_dests/20250806-120845
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250805162022.4920-3-bijan311%40gmail.com
patch subject: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
config: microblaze-randconfig-r072-20250810 (https://download.01.org/0day-ci/archive/20250810/202508101330.XRQqvfiN-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202508101330.XRQqvfiN-lkp@intel.com/
smatch warnings:
mm/damon/sysfs-schemes.c:2605 damos_sysfs_set_schemes_dests() warn: iterator 'i' not incremented
vim +/i +2605 mm/damon/sysfs-schemes.c
8014d822c9939b Bijan Tabatabai 2025-08-05 2601 int damos_sysfs_set_schemes_dests(struct damon_sysfs_schemes *sysfs_schemes,
8014d822c9939b Bijan Tabatabai 2025-08-05 2602 struct damon_ctx *ctx)
8014d822c9939b Bijan Tabatabai 2025-08-05 2603 {
8014d822c9939b Bijan Tabatabai 2025-08-05 2604 struct damos *scheme;
8014d822c9939b Bijan Tabatabai 2025-08-05 @2605 int i = 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2606
8014d822c9939b Bijan Tabatabai 2025-08-05 2607 damon_for_each_scheme(scheme, ctx) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2608 struct damos_sysfs_dests *sysfs_dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2609 struct damos_migrate_dests dests = {};
8014d822c9939b Bijan Tabatabai 2025-08-05 2610 int err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2611
8014d822c9939b Bijan Tabatabai 2025-08-05 2612 /* user could have removed the scheme sysfs dir */
8014d822c9939b Bijan Tabatabai 2025-08-05 2613 if (i >= sysfs_schemes->nr)
i is always zero.
8014d822c9939b Bijan Tabatabai 2025-08-05 2614 break;
8014d822c9939b Bijan Tabatabai 2025-08-05 2615
8014d822c9939b Bijan Tabatabai 2025-08-05 2616 sysfs_dests = sysfs_schemes->schemes_arr[i]->dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2617 err = damos_sysfs_add_migrate_dest(&dests, sysfs_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2618 if (err) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2619 damos_destroy_dests(&dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2620 return err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2621 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2622
8014d822c9939b Bijan Tabatabai 2025-08-05 2623 damos_destroy_dests(&scheme->migrate_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2624 scheme->migrate_dests = dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2625 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2626
8014d822c9939b Bijan Tabatabai 2025-08-05 2627 return 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2628 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
Date: Sun, 10 Aug 2025 13:55:40 +0800 [thread overview]
Message-ID: <202508101330.XRQqvfiN-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250805162022.4920-3-bijan311@gmail.com>
References: <20250805162022.4920-3-bijan311@gmail.com>
TO: Bijan Tabatabai <bijan311@gmail.com>
TO: damon@lists.linux.dev
TO: linux-mm@kvack.org
TO: linux-kernel@vger.kernel.org
TO: linux-doc@vger.kernel.org
CC: sj@kernel.org
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Linux Memory Management List <linux-mm@kvack.org>
CC: corbet@lwn.net
CC: Bijan Tabatabai <bijantabatab@micron.com>
Hi Bijan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Bijan-Tabatabai/mm-damon-core-Add-damos_destroy_dests/20250806-120845
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20250805162022.4920-3-bijan311%40gmail.com
patch subject: [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: microblaze-randconfig-r072-20250810 (https://download.01.org/0day-ci/archive/20250810/202508101330.XRQqvfiN-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 8.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508101330.XRQqvfiN-lkp@intel.com/
smatch warnings:
mm/damon/sysfs-schemes.c:2605 damos_sysfs_set_schemes_dests() warn: iterator 'i' not incremented
vim +/i +2605 mm/damon/sysfs-schemes.c
9106d467533db0 SeongJae Park 2025-07-08 2600
8014d822c9939b Bijan Tabatabai 2025-08-05 2601 int damos_sysfs_set_schemes_dests(struct damon_sysfs_schemes *sysfs_schemes,
8014d822c9939b Bijan Tabatabai 2025-08-05 2602 struct damon_ctx *ctx)
8014d822c9939b Bijan Tabatabai 2025-08-05 2603 {
8014d822c9939b Bijan Tabatabai 2025-08-05 2604 struct damos *scheme;
8014d822c9939b Bijan Tabatabai 2025-08-05 @2605 int i = 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2606
8014d822c9939b Bijan Tabatabai 2025-08-05 2607 damon_for_each_scheme(scheme, ctx) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2608 struct damos_sysfs_dests *sysfs_dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2609 struct damos_migrate_dests dests = {};
8014d822c9939b Bijan Tabatabai 2025-08-05 2610 int err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2611
8014d822c9939b Bijan Tabatabai 2025-08-05 2612 /* user could have removed the scheme sysfs dir */
8014d822c9939b Bijan Tabatabai 2025-08-05 2613 if (i >= sysfs_schemes->nr)
8014d822c9939b Bijan Tabatabai 2025-08-05 2614 break;
8014d822c9939b Bijan Tabatabai 2025-08-05 2615
8014d822c9939b Bijan Tabatabai 2025-08-05 2616 sysfs_dests = sysfs_schemes->schemes_arr[i]->dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2617 err = damos_sysfs_add_migrate_dest(&dests, sysfs_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2618 if (err) {
8014d822c9939b Bijan Tabatabai 2025-08-05 2619 damos_destroy_dests(&dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2620 return err;
8014d822c9939b Bijan Tabatabai 2025-08-05 2621 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2622
8014d822c9939b Bijan Tabatabai 2025-08-05 2623 damos_destroy_dests(&scheme->migrate_dests);
8014d822c9939b Bijan Tabatabai 2025-08-05 2624 scheme->migrate_dests = dests;
8014d822c9939b Bijan Tabatabai 2025-08-05 2625 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2626
8014d822c9939b Bijan Tabatabai 2025-08-05 2627 return 0;
8014d822c9939b Bijan Tabatabai 2025-08-05 2628 }
8014d822c9939b Bijan Tabatabai 2025-08-05 2629
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next parent reply other threads:[~2025-08-11 7:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-10 5:55 kernel test robot [this message]
2025-08-11 7:00 ` [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests Dan Carpenter
2025-08-11 16:35 ` SeongJae Park
-- strict thread matches above, loose matches on Subject: below --
2025-08-05 16:20 [PATCH 0/5] mm/damon/sysfs: Add commands useful for using migration dests Bijan Tabatabai
2025-08-05 16:20 ` [PATCH 1/5] mm/damon/core: Add damos_destroy_dests() Bijan Tabatabai
2025-08-05 16:20 ` [PATCH 2/5] mm/damon/sysfs: Implement a command to only commit scheme dests Bijan Tabatabai
2025-08-05 16:20 ` [PATCH 3/5] mm/damon/sysfs: Implement a command to wait until schemes are applied Bijan Tabatabai
2025-08-05 16:20 ` [PATCH 4/5] Docs/ABI/damon: Document new DAMON commands Bijan Tabatabai
2025-08-05 16:20 ` [PATCH 5/5] Docs/admin-guide/mm/damon/usage: " Bijan Tabatabai
2025-08-06 0:40 ` [PATCH 0/5] mm/damon/sysfs: Add commands useful for using migration dests SeongJae Park
2025-08-06 1:27 ` Bijan Tabatabai
2025-08-06 4:15 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508101330.XRQqvfiN-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=bijan311@gmail.com \
--cc=bijantabatab@micron.com \
--cc=corbet@lwn.net \
--cc=damon@lists.linux.dev \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.