[PATCH] libfdt: Drop including string.h from libfdt_internal.h

[PATCH] libfdt: Drop including string.h from libfdt_internal.h

[Rob Herring (Arm)]

Commit 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()") added a
string.h include to libfdt_internal.h which introduces a libc dependency
which cannot be overridden. Environments without libc (e.g. Linux
kernel) use a custom libfdt_env.h. string.h is already indirectly
included in libfdt_env.h, so it can be dropped from libfdt_internal.h.

Fixes: 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 libfdt/libfdt_internal.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
index 773bba87bc6e..b60b5456f596 100644
--- a/libfdt/libfdt_internal.h
+++ b/libfdt/libfdt_internal.h
@@ -6,7 +6,6 @@
  * Copyright (C) 2006 David Gibson, IBM Corporation.
  */
 #include <fdt.h>
-#include <string.h>
 
 #define FDT_ALIGN(x, a)		(((x) + (a) - 1) & ~((a) - 1))
 #define FDT_TAGALIGN(x)		(FDT_ALIGN((x), FDT_TAGSIZE))
-- 
2.47.2

Re: [PATCH] libfdt: Drop including string.h from libfdt_internal.h

[Simon Glass]

On Mon, 11 Aug 2025 at 07:05, Rob Herring (Arm) <robh@kernel.org> wrote:
>
> Commit 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()") added a
> string.h include to libfdt_internal.h which introduces a libc dependency
> which cannot be overridden. Environments without libc (e.g. Linux
> kernel) use a custom libfdt_env.h. string.h is already indirectly
> included in libfdt_env.h, so it can be dropped from libfdt_internal.h.
>
> Fixes: 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  libfdt/libfdt_internal.h | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
> index 773bba87bc6e..b60b5456f596 100644
> --- a/libfdt/libfdt_internal.h
> +++ b/libfdt/libfdt_internal.h
> @@ -6,7 +6,6 @@
>   * Copyright (C) 2006 David Gibson, IBM Corporation.
>   */
>  #include <fdt.h>
> -#include <string.h>
>
>  #define FDT_ALIGN(x, a)                (((x) + (a) - 1) & ~((a) - 1))
>  #define FDT_TAGALIGN(x)                (FDT_ALIGN((x), FDT_TAGSIZE))
> --
> 2.47.2
>
>

Re: [PATCH] libfdt: Drop including string.h from libfdt_internal.h

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1335 bytes --]

On Mon, Aug 11, 2025 at 08:04:16AM -0500, Rob Herring (Arm) wrote:
> Commit 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()") added a
> string.h include to libfdt_internal.h which introduces a libc dependency
> which cannot be overridden. Environments without libc (e.g. Linux
> kernel) use a custom libfdt_env.h. string.h is already indirectly
> included in libfdt_env.h, so it can be dropped from libfdt_internal.h.
> 
> Fixes: 0f69cedc08fc ("libfdt_internal: fdt_find_string_len_()")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Ouch, should have spotted that on review, sorry.

Fix merged.

> ---
>  libfdt/libfdt_internal.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libfdt/libfdt_internal.h b/libfdt/libfdt_internal.h
> index 773bba87bc6e..b60b5456f596 100644
> --- a/libfdt/libfdt_internal.h
> +++ b/libfdt/libfdt_internal.h
> @@ -6,7 +6,6 @@
>   * Copyright (C) 2006 David Gibson, IBM Corporation.
>   */
>  #include <fdt.h>
> -#include <string.h>
>  
>  #define FDT_ALIGN(x, a)		(((x) + (a) - 1) & ~((a) - 1))
>  #define FDT_TAGALIGN(x)		(FDT_ALIGN((x), FDT_TAGSIZE))

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]