From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <joe@dama.to>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shuah@kernel.org, sdf@fomichev.me, almasrymina@google.com,
noren@nvidia.com, linux-kselftest@vger.kernel.org,
ap420073@gmail.com
Subject: Re: [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from system() calls
Date: Mon, 11 Aug 2025 16:58:56 -0700 [thread overview]
Message-ID: <20250811165856.1867eb6a@kernel.org> (raw)
In-Reply-To: <aJqDDIZxNAnZ-I8W@MacBook-Air.local>
On Mon, 11 Aug 2025 16:55:56 -0700 Joe Damato wrote:
> On Mon, Aug 11, 2025 at 04:13:31PM -0700, Jakub Kicinski wrote:
> > The general expectations for network HW selftests is that they
> > will be run as root. sudo doesn't seem to work on NIPA VMs.
> > While it's probably something solvable in the setup I think we should
> > remove the sudos. devmem is the only networking test using sudo.
>
> FWIW, it looks like:
>
> virtio_net/virtio_net_common.sh
I think there were two tests that had sudo in code comments.
But not the actual code. I may have misread..
next prev parent reply other threads:[~2025-08-11 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 23:13 [PATCH net-next 0/5] selftests: drv-net: improve zerocopy tests Jakub Kicinski
2025-08-11 23:13 ` [PATCH net-next 1/5] selftests: drv-net: add configs for zerocopy Rx Jakub Kicinski
2025-08-11 23:52 ` Joe Damato
2025-08-12 16:56 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from system() calls Jakub Kicinski
2025-08-11 23:55 ` Joe Damato
2025-08-11 23:58 ` Jakub Kicinski [this message]
2025-08-12 16:58 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 3/5] selftests: drv-net: devmem: add / correct the IPv6 support Jakub Kicinski
2025-08-12 0:07 ` Joe Damato
2025-08-12 17:00 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 4/5] selftests: net: terminate bkg() commands on exception Jakub Kicinski
2025-08-12 0:08 ` Joe Damato
2025-08-12 17:02 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 5/5] selftests: drv-net: devmem: flip the direction of Tx tests Jakub Kicinski
2025-08-12 0:15 ` Joe Damato
2025-08-12 18:32 ` Mina Almasry
2025-08-12 16:46 ` [PATCH net-next 0/5] selftests: drv-net: improve zerocopy tests Stanislav Fomichev
2025-08-13 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811165856.1867eb6a@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joe@dama.to \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.