From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
sdf@fomichev.me, almasrymina@google.com, noren@nvidia.com,
linux-kselftest@vger.kernel.org, ap420073@gmail.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 5/5] selftests: drv-net: devmem: flip the direction of Tx tests
Date: Mon, 11 Aug 2025 16:13:34 -0700 [thread overview]
Message-ID: <20250811231334.561137-6-kuba@kernel.org> (raw)
In-Reply-To: <20250811231334.561137-1-kuba@kernel.org>
The Device Under Test should always be the local system.
While the Rx test gets this right the Tx test is sending
from remote to local. So Tx of DMABUF memory happens on remote.
These tests never run in NIPA since we don't have a compatible
device so we haven't caught this.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
tools/testing/selftests/drivers/net/hw/devmem.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/testing/selftests/drivers/net/hw/devmem.py b/tools/testing/selftests/drivers/net/hw/devmem.py
index 0a2533a3d6d6..45c2d49d55b6 100755
--- a/tools/testing/selftests/drivers/net/hw/devmem.py
+++ b/tools/testing/selftests/drivers/net/hw/devmem.py
@@ -42,9 +42,9 @@ from lib.py import ksft_disruptive
port = rand_port()
listen_cmd = f"socat -U - TCP{cfg.addr_ipver}-LISTEN:{port}"
- with bkg(listen_cmd) as socat:
- wait_port_listen(port)
- cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_remote} -f {cfg.ifname} -s {cfg.addr} -p {port}", host=cfg.remote, shell=True)
+ with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as socat:
+ wait_port_listen(port, host=cfg.remote)
+ cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_local} -f {cfg.ifname} -s {cfg.remote_addr} -p {port}", shell=True)
ksft_eq(socat.stdout.strip(), "hello\nworld")
@@ -56,9 +56,9 @@ from lib.py import ksft_disruptive
port = rand_port()
listen_cmd = f"socat -U - TCP{cfg.addr_ipver}-LISTEN:{port}"
- with bkg(listen_cmd, exit_wait=True) as socat:
- wait_port_listen(port)
- cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_remote} -f {cfg.ifname} -s {cfg.addr} -p {port} -z 3", host=cfg.remote, shell=True)
+ with bkg(listen_cmd, host=cfg.remote, exit_wait=True) as socat:
+ wait_port_listen(port, host=cfg.remote)
+ cmd(f"echo -e \"hello\\nworld\"| {cfg.bin_local} -f {cfg.ifname} -s {cfg.remote_addr} -p {port} -z 3", shell=True)
ksft_eq(socat.stdout.strip(), "hello\nworld")
--
2.50.1
next prev parent reply other threads:[~2025-08-11 23:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 23:13 [PATCH net-next 0/5] selftests: drv-net: improve zerocopy tests Jakub Kicinski
2025-08-11 23:13 ` [PATCH net-next 1/5] selftests: drv-net: add configs for zerocopy Rx Jakub Kicinski
2025-08-11 23:52 ` Joe Damato
2025-08-12 16:56 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 2/5] selftests: drv-net: devmem: remove sudo from system() calls Jakub Kicinski
2025-08-11 23:55 ` Joe Damato
2025-08-11 23:58 ` Jakub Kicinski
2025-08-12 16:58 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 3/5] selftests: drv-net: devmem: add / correct the IPv6 support Jakub Kicinski
2025-08-12 0:07 ` Joe Damato
2025-08-12 17:00 ` Mina Almasry
2025-08-11 23:13 ` [PATCH net-next 4/5] selftests: net: terminate bkg() commands on exception Jakub Kicinski
2025-08-12 0:08 ` Joe Damato
2025-08-12 17:02 ` Mina Almasry
2025-08-11 23:13 ` Jakub Kicinski [this message]
2025-08-12 0:15 ` [PATCH net-next 5/5] selftests: drv-net: devmem: flip the direction of Tx tests Joe Damato
2025-08-12 18:32 ` Mina Almasry
2025-08-12 16:46 ` [PATCH net-next 0/5] selftests: drv-net: improve zerocopy tests Stanislav Fomichev
2025-08-13 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811231334.561137-6-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.