From: Luis Chamberlain <mcgrof@kernel.org>
To: Chuck Lever <cel@kernel.org>, Daniel Gomez <da.gomez@kruces.com>,
kdevops@lists.linux.dev
Cc: Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 21/23] reboot-limit: fix COUNT parameter to properly override reboot count
Date: Mon, 11 Aug 2025 15:24:48 -0700 [thread overview]
Message-ID: <20250811222452.2213071-22-mcgrof@kernel.org> (raw)
In-Reply-To: <20250811222452.2213071-1-mcgrof@kernel.org>
The COUNT parameter was not being passed to ansible-playbook, causing
it to always use the configured value from extra_vars.yaml instead of
the runtime override.
Fix by:
- Adding $(KDEVOPS_EXTRA_VARS) dependency to ensure extra_vars.yaml exists
- Passing reboot_limit_max as an additional --extra-vars parameter
which overrides the value from extra_vars.yaml
This ensures that `make reboot-limit-tests COUNT=2` properly limits
the test to 2 reboots instead of using the configured maximum.
Generated-by: Claude AI
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
workflows/demos/reboot-limit/Makefile | 21 +++++++++++++--------
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/workflows/demos/reboot-limit/Makefile b/workflows/demos/reboot-limit/Makefile
index 87b7ea10..0539720b 100644
--- a/workflows/demos/reboot-limit/Makefile
+++ b/workflows/demos/reboot-limit/Makefile
@@ -107,10 +107,11 @@ endif # CONFIG_REBOOT_LIMIT_ENABLE_LOOP
#
# The playbook reboot-limit.yml is used to run all tasks defined except those
# with tags "run_tests" or "copy_results".
-reboot-limit:
+reboot-limit: $(KDEVOPS_EXTRA_VARS)
$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
playbooks/reboot-limit.yml \
- --skip-tags run_tests,copy_results
+ --skip-tags run_tests,copy_results \
+ --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)"
# kdevops supports generic workflows such as the enabling you to then use the
# /data/ partition to git clone linux, compile linux, install it and reboot
@@ -137,17 +138,19 @@ reboot-limit:
# tags "first_run" first and then "run_tests" and "copy_results". We always
# use the vars tag to ensure we get variables defined which we construct on the
# fly.
-reboot-limit-baseline:
+reboot-limit-baseline: $(KDEVOPS_EXTRA_VARS)
$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
--limit 'baseline' \
playbooks/reboot-limit.yml \
--tags vars,first_run,reset \
- --extra-vars=@./extra_vars.yaml
+ --extra-vars=@./extra_vars.yaml \
+ --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)"
$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
--limit 'baseline' \
playbooks/reboot-limit.yml \
--tags vars,run_tests,copy_results \
- --extra-vars=@./extra_vars.yaml
+ --extra-vars=@./extra_vars.yaml \
+ --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)"
# Once you know the baseline works, you may want to run the baseline in a loop
# up to the number of times you define. We define this goal in kdevops as
@@ -172,17 +175,19 @@ reboot-limit-baseline-reset:
reboot-limit-tests: reboot-limit-baseline reboot-limit-dev
# Below are the corresponding dev targets
-reboot-limit-dev:
+reboot-limit-dev: $(KDEVOPS_EXTRA_VARS)
$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
--limit 'dev' \
playbooks/reboot-limit.yml \
--tags vars,first_run,reset \
- --extra-vars=@./extra_vars.yaml
+ --extra-vars=@./extra_vars.yaml \
+ --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)"
$(Q)ansible-playbook $(ANSIBLE_VERBOSE) \
--limit 'dev' \
playbooks/reboot-limit.yml \
--tags vars,run_tests,copy_results \
- --extra-vars=@./extra_vars.yaml
+ --extra-vars=@./extra_vars.yaml \
+ --extra-vars="reboot_limit_max=$(REBOOT_LIMIT_MAX)"
reboot-limit-dev-loop:
$(Q)$(REBOOT_LIMIT_LOOP) dev
--
2.47.2
next prev parent reply other threads:[~2025-08-11 22:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 22:24 [PATCH 00/23] remove old kernel-ci and enhance reboot-limit Luis Chamberlain
2025-08-11 22:24 ` [PATCH 01/23] fstests: remove CONFIG_KERNEL_CI support Luis Chamberlain
2025-08-11 22:24 ` [PATCH 02/23] fstests: remove kernel-ci script symlinks Luis Chamberlain
2025-08-11 22:24 ` [PATCH 03/23] blktests: remove CONFIG_KERNEL_CI support Luis Chamberlain
2025-08-11 22:24 ` [PATCH 04/23] gitr: " Luis Chamberlain
2025-08-11 22:24 ` [PATCH 05/23] ltp: " Luis Chamberlain
2025-08-11 22:24 ` [PATCH 06/23] nfstest: " Luis Chamberlain
2025-08-11 22:24 ` [PATCH 07/23] pynfs: " Luis Chamberlain
2025-08-11 22:24 ` [PATCH 08/23] reboot-limit: convert CONFIG_KERNEL_CI to internal loop feature Luis Chamberlain
2025-08-11 22:24 ` [PATCH 09/23] kconfig: remove CONFIG_KERNEL_CI infrastructure Luis Chamberlain
2025-08-11 22:24 ` [PATCH 10/23] scripts: remove kernel-ci loop infrastructure Luis Chamberlain
2025-08-11 22:24 ` [PATCH 11/23] reboot-limit: simplify what gets selected Luis Chamberlain
2025-08-11 22:24 ` [PATCH 12/23] reboot-limit: add graph visualization support for results Luis Chamberlain
2025-08-11 22:24 ` [PATCH 13/23] reboot-limit: save graphs in organized results/graphs directory Luis Chamberlain
2025-08-11 22:24 ` [PATCH 14/23] docs: add comprehensive reboot-limit workflow documentation Luis Chamberlain
2025-08-11 22:24 ` [PATCH 15/23] reboot-limit: add kexec-tools dependency installation Luis Chamberlain
2025-08-11 22:24 ` [PATCH 16/23] reboot-limit: add A/B testing support targets Luis Chamberlain
2025-08-11 22:24 ` [PATCH 17/23] reboot-limit: fix kexec and reboot connection handling Luis Chamberlain
2025-08-11 22:24 ` [PATCH 18/23] reboot-limit: add COUNT parameter to override reboot count Luis Chamberlain
2025-08-11 22:24 ` [PATCH 19/23] reboot-limit: fix wait_for tasks using wrong host reference Luis Chamberlain
2025-08-11 22:24 ` [PATCH 20/23] reboot-limit: use ansible reboot module for all reboot types Luis Chamberlain
2025-08-11 22:24 ` Luis Chamberlain [this message]
2025-08-11 22:24 ` [PATCH 22/23] reboot-limit: handle empty dev group gracefully Luis Chamberlain
2025-08-11 22:24 ` [PATCH 23/23] reboot-limit: add kexec comparison feature Luis Chamberlain
2025-08-12 15:06 ` [PATCH 00/23] remove old kernel-ci and enhance reboot-limit Chuck Lever
2025-08-13 1:28 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811222452.2213071-22-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=cel@kernel.org \
--cc=da.gomez@kruces.com \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.