From: Jakub Kicinski <kuba@kernel.org>
To: Mohsin Bashir <mohsin.bashr@gmail.com>
Cc: netdev@vger.kernel.org, alexanderduyck@fb.com,
andrew+netdev@lunn.ch, ast@kernel.org, bpf@vger.kernel.org,
corbet@lwn.net, daniel@iogearbox.net, davem@davemloft.net,
edumazet@google.com, hawk@kernel.org, horms@kernel.org,
jdamato@fastly.com, john.fastabend@gmail.com,
kernel-team@meta.com, pabeni@redhat.com, sdf@fomichev.me,
vadim.fedorenko@linux.dev, aleksander.lobakin@intel.com
Subject: Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS configuration
Date: Tue, 12 Aug 2025 07:41:48 -0700 [thread overview]
Message-ID: <20250812074148.736c6ce6@kernel.org> (raw)
In-Reply-To: <20250811211338.857992-2-mohsin.bashr@gmail.com>
On Mon, 11 Aug 2025 14:13:30 -0700 Mohsin Bashir wrote:
> Add support for configuring the header data split threshold.
> For fbnic, the tcp data split support is enabled all the time.
>
> Fbnic supports a maximum buffer size of 4KB. However, the reservation
> for the headroom, tailroom, and padding reduce the max header size
> accordingly.
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:2214:24: error: use of undeclared identifier 'FBNIC_HDR_BYTES_MIN'
2214 | if (fbn->hds_thresh < FBNIC_HDR_BYTES_MIN) {
| ^
You're adding the constant in patch 5 and use it in patch 1.
--
pw-bot: cr
next prev parent reply other threads:[~2025-08-12 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 21:13 [PATCH net-next V2 0/9] eth: fbnic: Add XDP support for fbnic Mohsin Bashir
2025-08-11 21:13 ` [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS configuration Mohsin Bashir
2025-08-12 10:47 ` Vadim Fedorenko
2025-08-12 13:52 ` Mohsin Bashir
2025-08-12 14:41 ` Jakub Kicinski [this message]
2025-08-11 21:13 ` [PATCH net-next V2 2/9] eth: fbnic: Update Headroom Mohsin Bashir
2025-08-11 21:49 ` [PATCH net-next V2 3/9] eth: fbnic: Use shinfo to track frags state on Rx Mohsin Bashir
2025-08-11 21:54 ` [PATCH net-next V2 4/9] eth: fbnic: Prefetch packet headers " Mohsin Bashir
2025-08-11 21:55 ` [PATCH net-next V2 5/9] eth: fbnic: Add XDP pass, drop, abort support Mohsin Bashir
2025-08-11 21:55 ` [PATCH net-next V2 6/9] eth: fbnic: Add support for XDP queues Mohsin Bashir
2025-08-11 21:56 ` [PATCH net-next V2 7/9] eth: fbnic: Add support for XDP_TX action Mohsin Bashir
2025-08-11 21:56 ` [PATCH net-next V2 8/9] eth: fbnic: Collect packet statistics for XDP Mohsin Bashir
2025-08-11 21:57 ` [PATCH net-next V2 9/9] eth: fbnic: Report XDP stats via ethtool Mohsin Bashir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812074148.736c6ce6@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@meta.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.