Re: [PATCH net-next V2 1/9] eth: fbnic: Add support for HDS configuration

[Mohsin Bashir <mohsin.bashr@gmail.com>]

>>       fbnic_config_drop_mode_rcq(nv, rcq);
>> +    /* Force lower bound on MAX_HEADER_BYTES. Below this, all frames 
>> should
>> +     * be split at L4. It would also result in the frames being split at
>> +     * L2/L3 depending on the frame size.
>> +     */
>> +    if (fbn->hds_thresh < FBNIC_HDR_BYTES_MIN) {
>> +        rcq_ctl = FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT;
>> +        hds_thresh = FBNIC_HDR_BYTES_MIN;
>> +    }
>> +
>>       rcq_ctl = FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PADLEN_MASK, 
>> FBNIC_RX_PAD) |
> 
> because you still unconditionally rewrite the value here. at the same
> time FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT value will be lost, so I believe
> it should be
> 
>   rcq_ctl |= FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PADLEN_MASK, FBNIC_RX_PAD) |
> 
> and then the init code above makes sense.
> 
Yes, you are right. I kinda messed up this patch in V2. Thanks for 
pointing this out.