From: Jakub Kicinski <kuba@kernel.org>
To: Parav Pandit <parav@nvidia.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 2/2] devlink/port: Simplify return checks
Date: Tue, 12 Aug 2025 07:47:32 -0700 [thread overview]
Message-ID: <20250812074732.1f76ade4@kernel.org> (raw)
In-Reply-To: <CY8PR12MB7195C1ACF298C258BB37E759DC2BA@CY8PR12MB7195.namprd12.prod.outlook.com>
On Tue, 12 Aug 2025 13:45:09 +0000 Parav Pandit wrote:
> The general guidance was to not do multiple different types of changes in single patch.
> No strong preference to me.
It would probably make more sense if the order of the patches was
inverted.
next prev parent reply other threads:[~2025-08-12 14:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 3:51 [PATCH net-next 0/2] devlink port attr cleanup Parav Pandit
2025-08-12 3:51 ` [PATCH net-next 1/2] devlink/port: Check attributes early and constify Parav Pandit
2025-08-12 12:56 ` Vadim Fedorenko
2025-08-12 14:46 ` Jakub Kicinski
2025-08-12 16:20 ` Parav Pandit
2025-08-12 3:51 ` [PATCH net-next 2/2] devlink/port: Simplify return checks Parav Pandit
2025-08-12 12:59 ` Vadim Fedorenko
2025-08-12 13:45 ` Parav Pandit
2025-08-12 14:47 ` Jakub Kicinski [this message]
2025-08-12 16:21 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250812074732.1f76ade4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.