From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Parav Pandit <parav@nvidia.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, netdev@vger.kernel.org
Cc: jiri@resnulli.us, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 2/2] devlink/port: Simplify return checks
Date: Tue, 12 Aug 2025 13:59:42 +0100 [thread overview]
Message-ID: <a3f91ab5-d9da-4ef8-aecc-8d1264b8bf6a@linux.dev> (raw)
In-Reply-To: <20250812035106.134529-3-parav@nvidia.com>
On 12/08/2025 04:51, Parav Pandit wrote:
> Drop always returning 0 from the helper routine and simplify
> its callers.
Oh, I see, you split it into 2 patches, but I'm not sure it's actually
needed, because the first patch doesn't look logical on its own...
next prev parent reply other threads:[~2025-08-12 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 3:51 [PATCH net-next 0/2] devlink port attr cleanup Parav Pandit
2025-08-12 3:51 ` [PATCH net-next 1/2] devlink/port: Check attributes early and constify Parav Pandit
2025-08-12 12:56 ` Vadim Fedorenko
2025-08-12 14:46 ` Jakub Kicinski
2025-08-12 16:20 ` Parav Pandit
2025-08-12 3:51 ` [PATCH net-next 2/2] devlink/port: Simplify return checks Parav Pandit
2025-08-12 12:59 ` Vadim Fedorenko [this message]
2025-08-12 13:45 ` Parav Pandit
2025-08-12 14:47 ` Jakub Kicinski
2025-08-12 16:21 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3f91ab5-d9da-4ef8-aecc-8d1264b8bf6a@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.