[PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

[PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

[Rosen Penev]

A port of the prior platform code to use OF.

v2: use reg instead of led-sources

Rosen Penev (3):
  dt-bindings: net: wireless: ath9k: add led bindings
  wifi: ath9k: ahb: add led pin OF support
  mips: qca: use led-sources for WMAC LED

 .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts   | 10 +++++-----
 arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts     | 10 ++++------
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts        | 10 ++++------
 drivers/net/wireless/ath/ath9k/init.c              | 11 +++++++++++
 5 files changed, 38 insertions(+), 17 deletions(-)

-- 
2.50.1

[PATCHv2 1/3] dt-bindings: net: wireless: ath9k: add led bindings

[Rosen Penev]

The ath9k driver has various pin GPIO numbers for different chipsets
which are not always correct for every device.

Add bindings to specify the correct number and if it should be
active-low.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
index d16ca8e0a25d..e701046146f2 100644
--- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
@@ -50,6 +50,17 @@ properties:
 
   ieee80211-freq-limit: true
 
+  led:
+    type: object
+    properties:
+      reg:
+        maxItems: 1
+
+      led-active-low:
+        description:
+          LED is enabled with ground signal.
+        type: boolean
+
   qca,no-eeprom:
     $ref: /schemas/types.yaml#/definitions/flag
     description:
@@ -102,5 +113,8 @@ examples:
         compatible = "qca,ar9130-wifi";
         reg = <0x180c0000 0x230000>;
         interrupts = <2>;
+        led {
+          led-sources = <0>;
+        };
       };
     };
-- 
2.50.1

Re: [PATCHv2 1/3] dt-bindings: net: wireless: ath9k: add led bindings

[Krzysztof Kozlowski]

On 12/08/2025 21:23, Rosen Penev wrote:
> The ath9k driver has various pin GPIO numbers for different chipsets
> which are not always correct for every device.
> 
> Add bindings to specify the correct number and if it should be
> active-low.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> index d16ca8e0a25d..e701046146f2 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> @@ -50,6 +50,17 @@ properties:
>  
>    ieee80211-freq-limit: true
>  
> +  led:
> +    type: object

Each node must end with additional/unevaluatedProperties: false. See
example schema and writing schema.

That will probably lead you to missing LED common binding.

> +    properties:
> +      reg:
> +        maxItems: 1
> +
> +      led-active-low:
> +        description:
> +          LED is enabled with ground signal.

Aren't you redefining existing properties?

> +        type: boolean
> +
>    qca,no-eeprom:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> @@ -102,5 +113,8 @@ examples:
>          compatible = "qca,ar9130-wifi";
>          reg = <0x180c0000 0x230000>;
>          interrupts = <2>;
> +        led {
> +          led-sources = <0>;

Totally confusing with schema. active-low in one place, different
property in the example and no source for that property at all :/


Best regards,
Krzysztof

Re: [PATCHv2 1/3] dt-bindings: net: wireless: ath9k: add led bindings

[Rosen Penev]

On Wed, Aug 13, 2025 at 1:16 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/08/2025 21:23, Rosen Penev wrote:
> > The ath9k driver has various pin GPIO numbers for different chipsets
> > which are not always correct for every device.
> >
> > Add bindings to specify the correct number and if it should be
> > active-low.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >  .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > index d16ca8e0a25d..e701046146f2 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > @@ -50,6 +50,17 @@ properties:
> >
> >    ieee80211-freq-limit: true
> >
> > +  led:
> > +    type: object
>
> Each node must end with additional/unevaluatedProperties: false. See
> example schema and writing schema.
>
> That will probably lead you to missing LED common binding.

>
> > +    properties:
> > +      reg:
> > +        maxItems: 1
> > +
> > +      led-active-low:
> > +        description:
> > +          LED is enabled with ground signal.
>
> Aren't you redefining existing properties?
I don't think led-active-low is specified in any central location:

Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml:  led-active-low:
Documentation/devicetree/bindings/leds/irled/ir-spi-led.yaml:
  led-active-low;
Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml:
 led-active-low:
Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml:
led-active-low:
Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml:
 led-active-low;
>
> > +        type: boolean
> > +
> >    qca,no-eeprom:
> >      $ref: /schemas/types.yaml#/definitions/flag
> >      description:
> > @@ -102,5 +113,8 @@ examples:
> >          compatible = "qca,ar9130-wifi";
> >          reg = <0x180c0000 0x230000>;
> >          interrupts = <2>;
> > +        led {
> > +          led-sources = <0>;
>
> Totally confusing with schema. active-low in one place, different
> property in the example and no source for that property at all :/
Ah right. Will fix.
>
>
> Best regards,
> Krzysztof

Re: [PATCHv2 1/3] dt-bindings: net: wireless: ath9k: add led bindings

[Krzysztof Kozlowski]

On Wed, Aug 13, 2025 at 04:04:27PM -0700, Rosen Penev wrote:
> On Wed, Aug 13, 2025 at 1:16 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On 12/08/2025 21:23, Rosen Penev wrote:
> > > The ath9k driver has various pin GPIO numbers for different chipsets
> > > which are not always correct for every device.
> > >
> > > Add bindings to specify the correct number and if it should be
> > > active-low.
> > >
> > > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > > ---
> > >  .../bindings/net/wireless/qca,ath9k.yaml           | 14 ++++++++++++++
> > >  1 file changed, 14 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > > index d16ca8e0a25d..e701046146f2 100644
> > > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> > > @@ -50,6 +50,17 @@ properties:
> > >
> > >    ieee80211-freq-limit: true
> > >
> > > +  led:
> > > +    type: object
> >
> > Each node must end with additional/unevaluatedProperties: false. See
> > example schema and writing schema.
> >
> > That will probably lead you to missing LED common binding.
> 
> >
> > > +    properties:
> > > +      reg:
> > > +        maxItems: 1
> > > +
> > > +      led-active-low:
> > > +        description:
> > > +          LED is enabled with ground signal.
> >
> > Aren't you redefining existing properties?
> I don't think led-active-low is specified in any central location:

True, because it is active-low which you could easily find if you opened
and read the LED binding you were already referencing here.

Best regards,
Krzysztof

[PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support

[Rosen Penev]

The old and removed platform code had support for assigning a value for
the LED pin for when the default is not correct. Effectively a fix for a
non working LED.

For setting an LED to active high, a negation of led-active-low is used,
as two drivers currently use that and no drivers use led-active-high or
something similar.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/wireless/ath/ath9k/init.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index c911b178dcc2..7826b113235d 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -662,6 +662,17 @@ static int ath9k_of_init(struct ath_softc *sc)
 	if (ret == -EPROBE_DEFER)
 		return ret;
 
+	np = of_get_child_by_name(np, "led");
+	if (np && of_device_is_available(np)) {
+		u32 led_pin;
+
+		if (!of_property_read_u32(np, "reg", &led_pin))
+			ah->led_pin = led_pin;
+
+		ah->config.led_active_high = !of_property_read_bool(np, "led-active-low");
+		of_node_put(np);
+	}
+
 	return 0;
 }
 
-- 
2.50.1

Re: [PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support

[Krzysztof Kozlowski]

On 12/08/2025 21:23, Rosen Penev wrote:
> The old and removed platform code had support for assigning a value for
> the LED pin for when the default is not correct. Effectively a fix for a
> non working LED.
> 
> For setting an LED to active high, a negation of led-active-low is used,
> as two drivers currently use that and no drivers use led-active-high or
> something similar.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/net/wireless/ath/ath9k/init.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index c911b178dcc2..7826b113235d 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -662,6 +662,17 @@ static int ath9k_of_init(struct ath_softc *sc)
>  	if (ret == -EPROBE_DEFER)
>  		return ret;
>  
> +	np = of_get_child_by_name(np, "led");
> +	if (np && of_device_is_available(np)) {

You are open-coding of_get_available_child_by_name().

> +		u32 led_pin;
> +
> +		if (!of_property_read_u32(np, "reg", &led_pin))
> +			ah->led_pin = led_pin;
> +
> +		ah->config.led_active_high = !of_property_read_bool(np, "led-active-low");
> +		of_node_put(np);
> +	}

Leaking OF node.

> +
>  	return 0;
>  }
>  


Best regards,
Krzysztof

Re: [PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support

[Rosen Penev]

On Wed, Aug 13, 2025 at 1:20 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/08/2025 21:23, Rosen Penev wrote:
> > The old and removed platform code had support for assigning a value for
> > the LED pin for when the default is not correct. Effectively a fix for a
> > non working LED.
> >
> > For setting an LED to active high, a negation of led-active-low is used,
> > as two drivers currently use that and no drivers use led-active-high or
> > something similar.
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >  drivers/net/wireless/ath/ath9k/init.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> > index c911b178dcc2..7826b113235d 100644
> > --- a/drivers/net/wireless/ath/ath9k/init.c
> > +++ b/drivers/net/wireless/ath/ath9k/init.c
> > @@ -662,6 +662,17 @@ static int ath9k_of_init(struct ath_softc *sc)
> >       if (ret == -EPROBE_DEFER)
> >               return ret;
> >
> > +     np = of_get_child_by_name(np, "led");
> > +     if (np && of_device_is_available(np)) {
>
> You are open-coding of_get_available_child_by_name().
Will fix.
>
> > +             u32 led_pin;
> > +
> > +             if (!of_property_read_u32(np, "reg", &led_pin))
> > +                     ah->led_pin = led_pin;
> > +
> > +             ah->config.led_active_high = !of_property_read_bool(np, "led-active-low");
> > +             of_node_put(np);
> > +     }
>
> Leaking OF node.

Not following here.
>
> > +
> >       return 0;
> >  }
> >
>
>
> Best regards,
> Krzysztof

Re: [PATCHv2 2/3] wifi: ath9k: ahb: add led pin OF support

[Krzysztof Kozlowski]

On 14/08/2025 00:59, Rosen Penev wrote:
>>
>>> +             u32 led_pin;
>>> +
>>> +             if (!of_property_read_u32(np, "reg", &led_pin))
>>> +                     ah->led_pin = led_pin;
>>> +
>>> +             ah->config.led_active_high = !of_property_read_bool(np, "led-active-low");
>>> +             of_node_put(np);
>>> +     }
>>
>> Leaking OF node.
> 
> Not following here.

You miss proper cleanup, leaking of node.

Best regards,
Krzysztof

[PATCHv2 3/3] mips: qca: use led-sources for WMAC LED

[Rosen Penev]

The ath9k driver creates an LED unconditionally being driven with
sometimes the wrong pin. Not only that, the current dts definitions have
LEDs for the WMAC that do not behave in response to it. Fix both issues.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 10 +++++-----
 arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts   | 10 ++++------
 arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts      | 10 ++++------
 3 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index a7901bb040ce..344e1a2ee6ea 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -56,11 +56,6 @@ led-2 {
 			label = "tp-link:green:qss";
 			gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
 		};
-
-		led-3 {
-			label = "tp-link:green:wlan";
-			gpios = <&gpio 9 GPIO_ACTIVE_LOW>;
-		};
 	};
 };
 
@@ -111,4 +106,9 @@ partition@2 {
 
 &wifi {
 	status = "okay";
+
+	led {
+		reg = <9>;
+		led-active-low;
+	};
 };
diff --git a/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts b/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
index 37a74aabe4b4..573ca7752698 100644
--- a/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
+++ b/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts
@@ -22,12 +22,6 @@ memory@0 {
 	leds {
 		compatible = "gpio-leds";
 
-		led-wlan {
-			label = "dragino2:red:wlan";
-			gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
-			default-state = "off";
-		};
-
 		led-lan {
 			label = "dragino2:red:lan";
 			gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
@@ -101,4 +95,8 @@ spiflash: w25q128@0 {
 
 &wifi {
 	status = "okay";
+
+	led {
+		reg = <0>;
+	};
 };
diff --git a/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts b/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
index a7108c803eb3..6891d9589b68 100644
--- a/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
+++ b/arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts
@@ -22,12 +22,6 @@ memory@0 {
 	leds {
 		compatible = "gpio-leds";
 
-		led-wlan {
-			label = "tp-link:green:wlan";
-			gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
-			default-state = "off";
-		};
-
 		led-lan {
 			label = "tp-link:green:lan";
 			gpios = <&gpio 17 GPIO_ACTIVE_LOW>;
@@ -117,4 +111,8 @@ spiflash: s25sl032p@0 {
 
 &wifi {
 	status = "okay";
+
+	led {
+		reg = <0>;
+	};
 };
-- 
2.50.1

Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

[Krzysztof Kozlowski]

On 12/08/2025 21:23, Rosen Penev wrote:
> A port of the prior platform code to use OF.
> 
> v2: use reg instead of led-sources

Where? Really, where? There is no reg in the binding at all. There is
led-sources, though. Also many other things got changed, the binding is
completely different and nothing in changelog explains that.

Best regards,
Krzysztof

Re: [PATCHv2 0/3] wifi: ath9k: ahb: add OF LED support

[Rosen Penev]

On Wed, Aug 13, 2025 at 1:18 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 12/08/2025 21:23, Rosen Penev wrote:
> > A port of the prior platform code to use OF.
> >
> > v2: use reg instead of led-sources
>
> Where? Really, where? There is no reg in the binding at all. There is
> led-sources, though. Also many other things got changed, the binding is
> completely different and nothing in changelog explains that.
Yeah. The initial was copy/paste from mt76 driver. But then on review
I was told to change led-sources to reg and did not completely change
that in the patchset.
>
> Best regards,
> Krzysztof

Re: [PATCHv2 3/3] mips: qca: use led-sources for WMAC LED

[kernel test robot]

:::::: 
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20250812192334.11651-4-rosenp@gmail.com>
References: <20250812192334.11651-4-rosenp@gmail.com>
TO: Rosen Penev <rosenp@gmail.com>
TO: linux-wireless@vger.kernel.org
CC: "Toke Høiland-Jørgensen" <toke@toke.dk>
CC: Johannes Berg <johannes@sipsolutions.net>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-mips@vger.kernel.org

Hi Rosen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on linus/master v6.17-rc1 next-20250815]
[cannot apply to ath/ath-next wireless/main wireless-next/main]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/dt-bindings-net-wireless-ath9k-add-led-bindings/20250813-032839
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250812192334.11651-4-rosenp%40gmail.com
patch subject: [PATCHv2 3/3] mips: qca: use led-sources for WMAC LED
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: mips-randconfig-052-20250818 (https://download.01.org/0day-ci/archive/20250818/202508180508.NnHzzIu9-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
dtschema version: 2025.6.2.dev4+g8f79ddd
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508180508.NnHzzIu9-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202508180508.NnHzzIu9-lkp@intel.com/

dtcheck warnings: (new ones prefixed by >>)
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts:111.3-13: Warning (reg_format): /ahb/wifi@180c0000/led:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts:110.6-113.4: Warning (unit_address_vs_reg): /ahb/wifi@180c0000/led: node has a reg or ranges property, but no unit name
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts:110.6-113.4: Warning (avoid_default_addr_size): /ahb/wifi@180c0000/led: Relying on default #address-cells value
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts:110.6-113.4: Warning (avoid_default_addr_size): /ahb/wifi@180c0000/led: Relying on default #size-cells value
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (avoid_unnecessary_addr_size): Failed prerequisite 'avoid_default_addr_size'
>> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: /: failed to match any schema with compatible: ['tplink,tl-wr1043nd-v1', 'qca,ar9132']
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: /: failed to match any schema with compatible: ['tplink,tl-wr1043nd-v1', 'qca,ar9132']
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: uart@18020000 (ns8250): $nodename:0: 'uart@18020000' does not match '^serial(@.*)?$'
   	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: uart@18020000 (ns8250): clock-names:0: 'core' was expected
   	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: uart@18020000 (ns8250): clock-names: ['uart'] is too short
   	from schema $id: http://devicetree.org/schemas/serial/8250.yaml#
   arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dtb: uart@18020000 (ns8250): clock-names: 'oneOf' conditional failed, one must be fixed:
   	['uart'] is too short
--
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts:100.3-13: Warning (reg_format): /ahb/wifi@18100000/led:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts:99.6-101.4: Warning (unit_address_vs_reg): /ahb/wifi@18100000/led: node has a reg or ranges property, but no unit name
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts:99.6-101.4: Warning (avoid_default_addr_size): /ahb/wifi@18100000/led: Relying on default #address-cells value
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts:99.6-101.4: Warning (avoid_default_addr_size): /ahb/wifi@18100000/led: Relying on default #size-cells value
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (avoid_unnecessary_addr_size): Failed prerequisite 'avoid_default_addr_size'
>> arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: /: failed to match any schema with compatible: ['dragino,ms14']
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: reset-controller@1806001c (qca,ar7100-reset): compatible:0: 'qca,ar7100-reset' is not one of ['qca,ar9132-reset', 'qca,ar9331-reset']
   	from schema $id: http://devicetree.org/schemas/reset/qca,ar7100-reset.yaml#
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: reset-controller@1806001c (qca,ar7100-reset): compatible: ['qca,ar7100-reset'] is too short
   	from schema $id: http://devicetree.org/schemas/reset/qca,ar7100-reset.yaml#
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: /ahb/spi@1f000000: failed to match any schema with compatible: ['qca,ar7100-spi']
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: w25q128@0 (winbond,w25q128): $nodename:0: 'w25q128@0' does not match '^(flash|.*sram|nand)(@.*)?$'
   	from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#
   arch/mips/boot/dts/qca/ar9331_dragino_ms14.dtb: w25q128@0 (winbond,w25q128): Unevaluated properties are not allowed ('#address-cells', '#size-cells' were unexpected)
   	from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#
--
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts:116.3-13: Warning (reg_format): /ahb/wifi@18100000/led:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts:115.6-117.4: Warning (unit_address_vs_reg): /ahb/wifi@18100000/led: node has a reg or ranges property, but no unit name
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts:115.6-117.4: Warning (avoid_default_addr_size): /ahb/wifi@18100000/led: Relying on default #address-cells value
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dts:115.6-117.4: Warning (avoid_default_addr_size): /ahb/wifi@18100000/led: Relying on default #size-cells value
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (avoid_unnecessary_addr_size): Failed prerequisite 'avoid_default_addr_size'
>> arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: Warning (unique_unit_address_if_enabled): Failed prerequisite 'avoid_default_addr_size'
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: /: failed to match any schema with compatible: ['tplink,tl-mr3020']
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: reset-controller@1806001c (qca,ar7100-reset): compatible:0: 'qca,ar7100-reset' is not one of ['qca,ar9132-reset', 'qca,ar9331-reset']
   	from schema $id: http://devicetree.org/schemas/reset/qca,ar7100-reset.yaml#
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: reset-controller@1806001c (qca,ar7100-reset): compatible: ['qca,ar7100-reset'] is too short
   	from schema $id: http://devicetree.org/schemas/reset/qca,ar7100-reset.yaml#
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: /ahb/spi@1f000000: failed to match any schema with compatible: ['qca,ar7100-spi']
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: s25sl032p@0 (spansion,s25sl032p): $nodename:0: 's25sl032p@0' does not match '^(flash|.*sram|nand)(@.*)?$'
   	from schema $id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#
   arch/mips/boot/dts/qca/ar9331_tl_mr3020.dtb: s25sl032p@0 (spansion,s25sl032p): compatible: 'oneOf' conditional failed, one must be fixed:
   	['spansion,s25sl032p', 'jedec,spi-nor'] is too long

vim +111 arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts

da1fe323261f6a Rosen Penev 2025-06-08  106  
da1fe323261f6a Rosen Penev 2025-06-08  107  &wifi {
da1fe323261f6a Rosen Penev 2025-06-08  108  	status = "okay";
72362f6bb15c45 Rosen Penev 2025-08-12  109  
72362f6bb15c45 Rosen Penev 2025-08-12 @110  	led {
72362f6bb15c45 Rosen Penev 2025-08-12 @111  		reg = <9>;

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki