From: Chao Yu <chao@kernel.org>
To: Zorro Lang <zlang@kernel.org>, fstests@vger.kernel.org
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net,
Chao Yu <chao@kernel.org>
Subject: [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Date: Thu, 14 Aug 2025 17:07:12 +0800 [thread overview]
Message-ID: <20250814090712.2119455-3-chao@kernel.org> (raw)
In-Reply-To: <20250814090712.2119455-1-chao@kernel.org>
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such
corruption in the file
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
v3:
- use _require_scratch_nocheck instead of _require_scratch
- add missing _require_attrs user
- add comments for why exporting MKFS_OPTIONS=""
tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++
tests/f2fs/020.out | 2 ++
2 files changed, 53 insertions(+)
create mode 100755 tests/f2fs/020
create mode 100644 tests/f2fs/020.out
diff --git a/tests/f2fs/020 b/tests/f2fs/020
new file mode 100755
index 00000000..7ce1f92f
--- /dev/null
+++ b/tests/f2fs/020
@@ -0,0 +1,51 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Chao Yu. All Rights Reserved.
+#
+# FS QA Test No. f2fs/020
+#
+# This is a regression test:
+# 1. create directory
+# 2. add a new xattr entry to create xattr node
+# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file
+# 4. check whether f2fs kernel module will detect and report such
+# corruption in the file
+#
+. ./common/preamble
+_begin_fstest auto quick rw
+
+. ./common/attr
+
+_fixed_by_kernel_commit 061cf3a84bde \
+ "f2fs: fix to do sanity check on ino and xnid"
+
+_require_scratch_nocheck
+_require_command "$F2FS_INJECT_PROG" inject.f2fs
+_require_attrs user
+
+# remove all mkfs options to avoid layout change of on-disk inode
+export MKFS_OPTIONS=""
+
+testdir=$SCRATCH_MNT/testdir
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount "-o user_xattr,noinline_xattr"
+
+mkdir $testdir
+# add a new xattr entry to create xattr node
+$SETFATTR_PROG -n user.abc -v 123 $testdir
+
+_scratch_unmount
+
+# inject i_xattr_nid w/ nid of inode node
+$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full
+
+_scratch_mount
+# may potentially trigger a deadlock w/ double inode_lock on parent's inode
+mkdir $testdir/dir >> $seqres.full 2>&1
+_scratch_unmount
+
+echo "Silence is golden"
+
+status=0
+exit
diff --git a/tests/f2fs/020.out b/tests/f2fs/020.out
new file mode 100644
index 00000000..20d7944e
--- /dev/null
+++ b/tests/f2fs/020.out
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
--
2.49.0
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Zorro Lang <zlang@kernel.org>, fstests@vger.kernel.org
Cc: jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid
Date: Thu, 14 Aug 2025 17:07:12 +0800 [thread overview]
Message-ID: <20250814090712.2119455-3-chao@kernel.org> (raw)
In-Reply-To: <20250814090712.2119455-1-chao@kernel.org>
This is a regression test:
1. create directory
2. add a new xattr entry to create xattr node
3. use inject.f2fs to inject nid of xattr node w/ ino in a file
4. check whether f2fs kernel module will detect and report such
corruption in the file
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Chao Yu <chao@kernel.org>
---
v3:
- use _require_scratch_nocheck instead of _require_scratch
- add missing _require_attrs user
- add comments for why exporting MKFS_OPTIONS=""
tests/f2fs/020 | 51 ++++++++++++++++++++++++++++++++++++++++++++++
tests/f2fs/020.out | 2 ++
2 files changed, 53 insertions(+)
create mode 100755 tests/f2fs/020
create mode 100644 tests/f2fs/020.out
diff --git a/tests/f2fs/020 b/tests/f2fs/020
new file mode 100755
index 00000000..7ce1f92f
--- /dev/null
+++ b/tests/f2fs/020
@@ -0,0 +1,51 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2025 Chao Yu. All Rights Reserved.
+#
+# FS QA Test No. f2fs/020
+#
+# This is a regression test:
+# 1. create directory
+# 2. add a new xattr entry to create xattr node
+# 3. use inject.f2fs to inject nid of xattr node w/ ino in a file
+# 4. check whether f2fs kernel module will detect and report such
+# corruption in the file
+#
+. ./common/preamble
+_begin_fstest auto quick rw
+
+. ./common/attr
+
+_fixed_by_kernel_commit 061cf3a84bde \
+ "f2fs: fix to do sanity check on ino and xnid"
+
+_require_scratch_nocheck
+_require_command "$F2FS_INJECT_PROG" inject.f2fs
+_require_attrs user
+
+# remove all mkfs options to avoid layout change of on-disk inode
+export MKFS_OPTIONS=""
+
+testdir=$SCRATCH_MNT/testdir
+
+_scratch_mkfs >> $seqres.full
+_scratch_mount "-o user_xattr,noinline_xattr"
+
+mkdir $testdir
+# add a new xattr entry to create xattr node
+$SETFATTR_PROG -n user.abc -v 123 $testdir
+
+_scratch_unmount
+
+# inject i_xattr_nid w/ nid of inode node
+$F2FS_INJECT_PROG --node --mb i_xattr_nid --nid 4 --val 4 $SCRATCH_DEV >> $seqres.full
+
+_scratch_mount
+# may potentially trigger a deadlock w/ double inode_lock on parent's inode
+mkdir $testdir/dir >> $seqres.full 2>&1
+_scratch_unmount
+
+echo "Silence is golden"
+
+status=0
+exit
diff --git a/tests/f2fs/020.out b/tests/f2fs/020.out
new file mode 100644
index 00000000..20d7944e
--- /dev/null
+++ b/tests/f2fs/020.out
@@ -0,0 +1,2 @@
+QA output created by 020
+Silence is golden
--
2.49.0
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2025-08-14 9:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:07 [PATCH v2 1/3] f2fs/018: check data eof after partial truncation on compressed cluster Chao Yu
2025-08-14 9:07 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-14 9:07 ` [PATCH v2 2/3] f2fs/019: do sanity check on mapping table Chao Yu
2025-08-14 9:07 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-14 21:15 ` Zorro Lang
2025-08-14 21:15 ` [f2fs-dev] " Zorro Lang via Linux-f2fs-devel
2025-08-14 9:07 ` Chao Yu [this message]
2025-08-14 9:07 ` [f2fs-dev] [PATCH v2 3/3] f2fs/020: do sanity check on i_xattr_nid Chao Yu via Linux-f2fs-devel
2025-08-14 21:18 ` Zorro Lang
2025-08-14 21:18 ` [f2fs-dev] " Zorro Lang via Linux-f2fs-devel
2025-08-15 8:02 ` Chao Yu
2025-08-15 8:02 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-15 15:12 ` Zorro Lang
2025-08-15 15:12 ` [f2fs-dev] " Zorro Lang via Linux-f2fs-devel
2025-08-16 7:08 ` Chao Yu
2025-08-16 7:08 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-08-14 20:53 ` [PATCH v2 1/3] f2fs/018: check data eof after partial truncation on compressed cluster Zorro Lang
2025-08-14 20:53 ` [f2fs-dev] " Zorro Lang via Linux-f2fs-devel
2025-08-15 7:24 ` Chao Yu
2025-08-15 7:24 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814090712.2119455-3-chao@kernel.org \
--to=chao@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.