All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aboorva Devarajan <aboorvad@linux.ibm.com>
To: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
	lorenzo.stoakes@oracle.com, shuah@kernel.org, pfalcato@suse.de,
	david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
	npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
	baohua@kernel.org, richard.weiyang@gmail.com
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, donettom@linux.ibm.com,
	ritesh.list@gmail.com, aboorvad@linux.ibm.com
Subject: [PATCH v4 7/7] selftests/mm: skip hugepage-mremap test if userfaultfd unavailable
Date: Sat, 16 Aug 2025 09:31:13 +0530	[thread overview]
Message-ID: <20250816040113.760010-8-aboorvad@linux.ibm.com> (raw)
In-Reply-To: <20250816040113.760010-1-aboorvad@linux.ibm.com>

Gracefully skip test if userfaultfd is not supported (ENOSYS) or not
permitted (EPERM), instead of failing.  This avoids misleading failures
with clear skip messages.

--------------
Before Patch
--------------
~ running ./hugepage-mremap
...
~ Bail out! userfaultfd: Function not implemented
~ Planned tests != run tests (1 != 0)
~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0
~ [FAIL]
not ok 4 hugepage-mremap # exit=1

--------------
After Patch
--------------
~ running ./hugepage-mremap
...
~ ok 2 # SKIP userfaultfd is not supported/not enabled.
~ 1 skipped test(s) detected.
~ Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
~ [SKIP]
ok 4 hugepage-mremap # SKIP

Co-developed-by: Donet Tom <donettom@linux.ibm.com>
Signed-off-by: Donet Tom <donettom@linux.ibm.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Zi Yan <ziy@nvidia.com>
Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
---
 tools/testing/selftests/mm/hugepage-mremap.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/hugepage-mremap.c b/tools/testing/selftests/mm/hugepage-mremap.c
index c463d1c09c9b..2bd1dac75c3f 100644
--- a/tools/testing/selftests/mm/hugepage-mremap.c
+++ b/tools/testing/selftests/mm/hugepage-mremap.c
@@ -65,10 +65,20 @@ static void register_region_with_uffd(char *addr, size_t len)
 	struct uffdio_api uffdio_api;
 
 	/* Create and enable userfaultfd object. */
-
 	uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK);
-	if (uffd == -1)
-		ksft_exit_fail_msg("userfaultfd: %s\n", strerror(errno));
+	if (uffd == -1) {
+		switch (errno) {
+		case EPERM:
+			ksft_exit_skip("Insufficient permissions, try running as root.\n");
+			break;
+		case ENOSYS:
+			ksft_exit_skip("userfaultfd is not supported/not enabled.\n");
+			break;
+		default:
+			ksft_exit_fail_msg("userfaultfd failed with %s\n", strerror(errno));
+			break;
+		}
+	}
 
 	uffdio_api.api = UFFD_API;
 	uffdio_api.features = 0;
-- 
2.47.1


  parent reply	other threads:[~2025-08-16  4:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-16  4:01 [PATCH v4 0/7] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range() Aboorva Devarajan
2025-08-16 14:05   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 2/7] selftests/mm: Add support to test 4PB VA on PPC64 Aboorva Devarajan
2025-08-16 14:06   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 3/7] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-08-16 14:07   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-08-16 14:31   ` Wei Yang
2025-08-17  7:27     ` Giant Sand Fans
2025-08-17  7:42     ` Giant Sand Fans
2025-08-17  8:07       ` David Hildenbrand
2025-08-18  2:21         ` Wei Yang
2025-08-19  7:57     ` Aboorva Devarajan
2025-08-19  4:12   ` [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test Aboorva Devarajan
2025-08-19  7:25     ` David Hildenbrand
2025-08-19  7:28       ` David Hildenbrand
2025-08-19  7:39         ` Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 5/7] selftests/mm: fix child process exit codes in ksm_functional_tests Aboorva Devarajan
2025-08-16 14:43   ` Wei Yang
2025-08-19  1:48     ` Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 6/7] selftests/mm: skip thuge-gen test if system is not setup properly Aboorva Devarajan
2025-08-16 14:46   ` Wei Yang
2025-08-16  4:01 ` Aboorva Devarajan [this message]
2025-08-16 14:46   ` [PATCH v4 7/7] selftests/mm: skip hugepage-mremap test if userfaultfd unavailable Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250816040113.760010-8-aboorvad@linux.ibm.com \
    --to=aboorvad@linux.ibm.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=donettom@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=richard.weiyang@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.