All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Aboorva Devarajan <aboorvad@linux.ibm.com>, akpm@linux-foundation.org
Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com,
	shuah@kernel.org, pfalcato@suse.de, ziy@nvidia.com,
	baolin.wang@linux.alibaba.com, npache@redhat.com,
	ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
	richard.weiyang@gmail.com, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	donettom@linux.ibm.com, ritesh.list@gmail.com
Subject: Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test
Date: Tue, 19 Aug 2025 09:28:20 +0200	[thread overview]
Message-ID: <38734ae6-012d-4630-8bf3-efefb65f0d23@redhat.com> (raw)
In-Reply-To: <8142d36d-2a0e-476c-8250-1a69c1f92913@redhat.com>

On 19.08.25 09:25, David Hildenbrand wrote:
> On 19.08.25 06:12, Aboorva Devarajan wrote:
>> Removed an extra space in split_huge_page_test that was introduced
>> by commit 4b76e221794b ("mm/selftests: fix split_huge_page_test
>> failure on systems with 64KB page size").
>>
>> Signed-off-by: Aboorva Devarajan <aboorvad@linux.ibm.com>
>> ---
>>    tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
>> index 54e86f00aabc..faf7e1f88743 100644
>> --- a/tools/testing/selftests/mm/split_huge_page_test.c
>> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
>> @@ -544,7 +544,7 @@ int main(int argc, char **argv)
>>    		ksft_exit_fail_msg("Reading PMD pagesize failed\n");
>>    
>>    	nr_pages = pmd_pagesize / pagesize;
>> -	max_order =  sz2ord(pmd_pagesize, pagesize);
>> +	max_order = sz2ord(pmd_pagesize, pagesize);
>>    	tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - 1) * 4 + 2;
>>    	ksft_set_plan(tests);
>>    
> 
> Please just comment next time one the respective patch as review comment.
> 

To clarify what I mean is something like this:

https://lkml.kernel.org/r/3dca2de4-9a6a-4efe-a86c-83f9509831fc@gmail.com

Gives more context when the subject directly highlights to which patch 
you are replying.

-- 
Cheers

David / dhildenb


  reply	other threads:[~2025-08-19  7:28 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-16  4:01 [PATCH v4 0/7] selftests/mm: Fix false positives and skip unsupported tests Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 1/7] mm/selftests: Fix incorrect pointer being passed to mark_range() Aboorva Devarajan
2025-08-16 14:05   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 2/7] selftests/mm: Add support to test 4PB VA on PPC64 Aboorva Devarajan
2025-08-16 14:06   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 3/7] selftest/mm: Fix ksm_funtional_test failures Aboorva Devarajan
2025-08-16 14:07   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 4/7] mm/selftests: Fix split_huge_page_test failure on systems with 64KB page size Aboorva Devarajan
2025-08-16 14:31   ` Wei Yang
2025-08-17  7:27     ` Giant Sand Fans
2025-08-17  7:42     ` Giant Sand Fans
2025-08-17  8:07       ` David Hildenbrand
2025-08-18  2:21         ` Wei Yang
2025-08-19  7:57     ` Aboorva Devarajan
2025-08-19  4:12   ` [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test Aboorva Devarajan
2025-08-19  7:25     ` David Hildenbrand
2025-08-19  7:28       ` David Hildenbrand [this message]
2025-08-19  7:39         ` Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 5/7] selftests/mm: fix child process exit codes in ksm_functional_tests Aboorva Devarajan
2025-08-16 14:43   ` Wei Yang
2025-08-19  1:48     ` Aboorva Devarajan
2025-08-16  4:01 ` [PATCH v4 6/7] selftests/mm: skip thuge-gen test if system is not setup properly Aboorva Devarajan
2025-08-16 14:46   ` Wei Yang
2025-08-16  4:01 ` [PATCH v4 7/7] selftests/mm: skip hugepage-mremap test if userfaultfd unavailable Aboorva Devarajan
2025-08-16 14:46   ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38734ae6-012d-4630-8bf3-efefb65f0d23@redhat.com \
    --to=david@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=aboorvad@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=dev.jain@arm.com \
    --cc=donettom@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=npache@redhat.com \
    --cc=pfalcato@suse.de \
    --cc=richard.weiyang@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.