All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/python-yarl: add missing select
@ 2025-08-16 13:01 Thomas Perale via buildroot
  2025-08-16 13:01 ` [Buildroot] [PATCH 2/2] python-yarl: bump to v1.20.1 Thomas Perale via buildroot
  2025-08-16 17:52 ` [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Petazzoni via buildroot
  0 siblings, 2 replies; 5+ messages in thread
From: Thomas Perale via buildroot @ 2025-08-16 13:01 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard

`python-yarl.mk` depends on the host-python-cython package. This patch
adds a `select BR2_PACKAGE_HOST_PYTHON_CYTHON` to correctly express this
dependency in KConfig.

Signed-off-by: Thomas Perale <thomas.perale@mind.be>
---
 package/python-yarl/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-yarl/Config.in b/package/python-yarl/Config.in
index 48ed07cfde..e14275971e 100644
--- a/package/python-yarl/Config.in
+++ b/package/python-yarl/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_PYTHON_YARL
 	bool "python-yarl"
+	select BR2_PACKAGE_HOST_PYTHON_CYTHON
 	select BR2_PACKAGE_PYTHON_IDNA # runtime
 	select BR2_PACKAGE_PYTHON_MULTIDICT # runtime
 	select BR2_PACKAGE_PYTHON_PROPCACHE # runtime
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] python-yarl: bump to v1.20.1
  2025-08-16 13:01 [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Perale via buildroot
@ 2025-08-16 13:01 ` Thomas Perale via buildroot
  2025-08-16 17:52 ` [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Petazzoni via buildroot
  1 sibling, 0 replies; 5+ messages in thread
From: Thomas Perale via buildroot @ 2025-08-16 13:01 UTC (permalink / raw)
  To: buildroot; +Cc: James Hilliard

Since the python-cython bump to v3.1.2 (see [1]), python-yarl has been
failing on the autobuilder with the following error message:

```
ERROR Missing dependencies:
	Cython~=3.0.0; python_version >= "3.12"
make: *** [package/pkg-generic.mk:273: /home/buildroot/instance-0/output-1/build/python-yarl-1.18.3/.stamp_built] Error 1
```

The cython dependency has been addressed in python-yarl v1.20.1, for
more information see the github issue [2].

For more information on the release, see:

  - https://github.com/aio-libs/yarl/releases/tag/v1.19.0
  - https://github.com/aio-libs/yarl/releases/tag/v1.20.0
  - https://github.com/aio-libs/yarl/releases/tag/v1.20.1

[1] b536caaec0 package/python-cython: bump to version 3.1.2
[2] https://github.com/aio-libs/yarl/pull/1514

Fixes: https://autobuild.buildroot.org/results/d36/d367b69b85a65fa94e923ecff3ba03723b2a6e88
Signed-off-by: Thomas Perale <thomas.perale@mind.be>
---
 package/python-yarl/python-yarl.hash | 4 ++--
 package/python-yarl/python-yarl.mk   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/python-yarl/python-yarl.hash b/package/python-yarl/python-yarl.hash
index ca2d42bf58..43ba31f81f 100644
--- a/package/python-yarl/python-yarl.hash
+++ b/package/python-yarl/python-yarl.hash
@@ -1,5 +1,5 @@
 # md5, sha256 from https://pypi.org/pypi/yarl/json
-md5  80b89d2b28be7345a38f099b2f839d7d  yarl-1.18.3.tar.gz
-sha256  ac1801c45cbf77b6c99242eeff4fffb5e4e73a800b5c4ad4fc0be5def634d2e1  yarl-1.18.3.tar.gz
+md5  23352fbc2b165825d4a33682c91788bc  yarl-1.20.1.tar.gz
+sha256  d017a4997ee50c91fd5466cef416231bb82177b93b029906cefc542ce14c35ac  yarl-1.20.1.tar.gz
 # Locally computed sha256 checksums
 sha256  cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30  LICENSE
diff --git a/package/python-yarl/python-yarl.mk b/package/python-yarl/python-yarl.mk
index 160dec8a1b..4f25394c8b 100644
--- a/package/python-yarl/python-yarl.mk
+++ b/package/python-yarl/python-yarl.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-PYTHON_YARL_VERSION = 1.18.3
+PYTHON_YARL_VERSION = 1.20.1
 PYTHON_YARL_SOURCE = yarl-$(PYTHON_YARL_VERSION).tar.gz
-PYTHON_YARL_SITE = https://files.pythonhosted.org/packages/b7/9d/4b94a8e6d2b51b599516a5cb88e5bc99b4d8d4583e468057eaa29d5f0918
+PYTHON_YARL_SITE = https://files.pythonhosted.org/packages/3c/fb/efaa23fa4e45537b827620f04cf8f3cd658b76642205162e072703a5b963
 PYTHON_YARL_LICENSE = Apache-2.0
 PYTHON_YARL_LICENSE_FILES = LICENSE
 PYTHON_YARL_SETUP_TYPE = setuptools
-- 
2.50.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/python-yarl: add missing select
  2025-08-16 13:01 [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Perale via buildroot
  2025-08-16 13:01 ` [Buildroot] [PATCH 2/2] python-yarl: bump to v1.20.1 Thomas Perale via buildroot
@ 2025-08-16 17:52 ` Thomas Petazzoni via buildroot
  2025-08-16 20:21   ` Thomas Perale via buildroot
  1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-08-16 17:52 UTC (permalink / raw)
  To: Thomas Perale via buildroot; +Cc: Thomas Perale, James Hilliard

On Sat, 16 Aug 2025 15:01:04 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> `python-yarl.mk` depends on the host-python-cython package. This patch
> adds a `select BR2_PACKAGE_HOST_PYTHON_CYTHON` to correctly express this
> dependency in KConfig.

This is not quite needed, nor required. We do not enforce adding select
for host packages. When a package needs host-pkgconf, we do not select
BR2_PACKAGE_HOST_PKGCONF for example. I'm sure you will find tons of
other packages that have host-python-cython in their <pkg>_DEPENDENCIES
but that don't select BR2_PACKAGE_HOST_PYTHON_CYTHON.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/python-yarl: add missing select
  2025-08-16 17:52 ` [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Petazzoni via buildroot
@ 2025-08-16 20:21   ` Thomas Perale via buildroot
  2025-08-16 20:52     ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Perale via buildroot @ 2025-08-16 20:21 UTC (permalink / raw)
  To: Thomas Petazzoni
  Cc: Thomas Perale, Thomas Perale via buildroot, James Hilliard

Good Evening,

In reply of:
> On Sat, 16 Aug 2025 15:01:04 +0200
> Thomas Perale via buildroot <buildroot@buildroot.org> wrote:
> 
> > `python-yarl.mk` depends on the host-python-cython package. This patch
> > adds a `select BR2_PACKAGE_HOST_PYTHON_CYTHON` to correctly express this
> > dependency in KConfig.
> 
> This is not quite needed, nor required. We do not enforce adding select
> for host packages. When a package needs host-pkgconf, we do not select
> BR2_PACKAGE_HOST_PKGCONF for example. I'm sure you will find tons of
> other packages that have host-python-cython in their <pkg>_DEPENDENCIES
> but that don't select BR2_PACKAGE_HOST_PYTHON_CYTHON.

Good to know, my reasoning was that other package in that same case seemed to
select `BR2_PACKAGE_HOST_PYTHON_CYTHON`:

- python-kmod/Config.in
- python-dbus-fast/Config.in
- python-rgbmatrix/Config.in

So, if you prefer to not include the 'select' I will send a v2 and remove my
series that did the same for python-propcache
(https://lore.kernel.org/r/<20250813201639.2443921-1-thomas.perale@mind.be>).

Best regards.

> Thomas
> -- 
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Buildroot] [PATCH 1/2] package/python-yarl: add missing select
  2025-08-16 20:21   ` Thomas Perale via buildroot
@ 2025-08-16 20:52     ` Thomas Petazzoni via buildroot
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2025-08-16 20:52 UTC (permalink / raw)
  To: Thomas Perale; +Cc: Thomas Perale via buildroot, James Hilliard

On Sat, 16 Aug 2025 22:21:53 +0200
Thomas Perale <thomas.perale@mind.be> wrote:

> Good to know, my reasoning was that other package in that same case seemed to
> select `BR2_PACKAGE_HOST_PYTHON_CYTHON`:
> 
> - python-kmod/Config.in
> - python-dbus-fast/Config.in
> - python-rgbmatrix/Config.in
> 
> So, if you prefer to not include the 'select' I will send a v2 and remove my
> series that did the same for python-propcache
> (https://lore.kernel.org/r/<20250813201639.2443921-1-thomas.perale@mind.be>).

Indeed to me right now the consensus has been to _not_ add those
selects for host packages. The Config.in.host option is only to allow a
user to explicitly enable a host package through "make menuconfig".

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-08-16 20:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-16 13:01 [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Perale via buildroot
2025-08-16 13:01 ` [Buildroot] [PATCH 2/2] python-yarl: bump to v1.20.1 Thomas Perale via buildroot
2025-08-16 17:52 ` [Buildroot] [PATCH 1/2] package/python-yarl: add missing select Thomas Petazzoni via buildroot
2025-08-16 20:21   ` Thomas Perale via buildroot
2025-08-16 20:52     ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.