Re: [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT

[SeongJae Park <sj@kernel.org>]

On Sun, 17 Aug 2025 18:20:31 +0800 Enze Li <lienze@kylinos.cn> wrote:

> Hi SJ,
> 
> On Fri, Aug 15 2025 at 09:59:03 AM -0700, SeongJae Park wrote:
> 
> > On Fri, 15 Aug 2025 17:21:10 +0800 Enze Li <lienze@kylinos.cn> wrote:
> >
> >> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
> >> option -- enabling it alone is meaningless.  This patch makes
> >> DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional
> >
> > s/depend/depends/ ?
> 
> I'm not well-versed in grammar, but using 'depends on' here feels a bit
> weird to me.  After consulting grammar references, it seems to me that
> I've found the answer.
> 
> In *Collins COBUILD English Grammar 4th* (Section 3.210, titled
> transitive verbs with an infinitive without _to_), it says:
> 
> > A few verbs are followed by an object and an infinitive without to,
> > not an -ing participle or a to-infinitive.  They are let, make, and
> > have in the sense of cause to happen or experience.
> 
> It's somewhat like what we often call 'make the machine *work*'.  This
> is my understanding.  If I misunderstood or missed something, please let
> me know, I would be happy to submit v3 of the patch to fix the typo.

My English is really poor, so I believe you're right.  Thank you for correcting
me! :)


Thanks,
SJ

[...]