From: Enze Li <lienze@kylinos.cn>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, enze.li@gmx.com
Subject: Re: [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT
Date: Sun, 17 Aug 2025 18:20:31 +0800 [thread overview]
Message-ID: <bjoel05s.fsf@kylinos.cn> (raw)
In-Reply-To: <20250815165903.13330-1-sj@kernel.org> (SeongJae Park's message of "Fri, 15 Aug 2025 09:59:03 -0700")
Hi SJ,
On Fri, Aug 15 2025 at 09:59:03 AM -0700, SeongJae Park wrote:
> On Fri, 15 Aug 2025 17:21:10 +0800 Enze Li <lienze@kylinos.cn> wrote:
>
>> The DAMON_STAT_ENABLED_DEFAULT option is strongly tied to DAMON_STAT
>> option -- enabling it alone is meaningless. This patch makes
>> DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT, ensuring functional
>
> s/depend/depends/ ?
I'm not well-versed in grammar, but using 'depends on' here feels a bit
weird to me. After consulting grammar references, it seems to me that
I've found the answer.
In *Collins COBUILD English Grammar 4th* (Section 3.210, titled
transitive verbs with an infinitive without _to_), it says:
> A few verbs are followed by an object and an infinitive without to,
> not an -ing participle or a to-infinitive. They are let, make, and
> have in the sense of cause to happen or experience.
It's somewhat like what we often call 'make the machine *work*'. This
is my understanding. If I misunderstood or missed something, please let
me know, I would be happy to submit v3 of the patch to fix the typo.
Best Regards,
Enze
[...]
next prev parent reply other threads:[~2025-08-17 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 9:21 [PATCH v2] mm/damon/Kconfig: make DAMON_STAT_ENABLED_DEFAULT depend on DAMON_STAT Enze Li
2025-08-15 16:59 ` SeongJae Park
2025-08-17 10:20 ` Enze Li [this message]
2025-08-17 17:04 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bjoel05s.fsf@kylinos.cn \
--to=lienze@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=enze.li@gmx.com \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.