[isilence:zcrx/large-buffers-v3 17/25] drivers/net/ethernet/broadcom/bnxt/bnxt.c:3839:30: error: assignment of read-only variable 'agg_size_fac'

[isilence:zcrx/large-buffers-v3 17/25] drivers/net/ethernet/broadcom/bnxt/bnxt.c:3839:30: error: assignment of read-only variable 'agg_size_fac'

[kernel test robot]

tree:   https://github.com/isilence/linux zcrx/large-buffers-v3
head:   15b55cf15dc11c9fafb9aea322713d3c85471946
commit: a3e6f9d865d26748a16676302d02bc64f7bf3849 [17/25] eth: bnxt: adjust the fill level of agg queues with larger buffers
config: arc-randconfig-001-20250818 (https://download.01.org/0day-ci/archive/20250818/202508180935.x3gDoHxB-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250818/202508180935.x3gDoHxB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508180935.x3gDoHxB-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/bnxt/bnxt.c: In function 'bnxt_alloc_rx_page_pool':
>> drivers/net/ethernet/broadcom/bnxt/bnxt.c:3839:30: error: assignment of read-only variable 'agg_size_fac'
    3839 |                 agg_size_fac = 1;
         |                              ^


vim +/agg_size_fac +3839 drivers/net/ethernet/broadcom/bnxt/bnxt.c

  3828	
  3829	static int bnxt_alloc_rx_page_pool(struct bnxt *bp,
  3830					   struct bnxt_rx_ring_info *rxr,
  3831					   int numa_node)
  3832	{
  3833		const unsigned int agg_size_fac = rxr->rx_page_size / BNXT_RX_PAGE_SIZE;
  3834		const unsigned int rx_size_fac = PAGE_SIZE / SZ_4K;
  3835		struct page_pool_params pp = { 0 };
  3836		struct page_pool *pool;
  3837	
  3838		if (WARN_ON_ONCE(agg_size_fac == 0))
> 3839			agg_size_fac = 1;
  3840	
  3841		pp.pool_size = bnxt_rx_agg_ring_fill_level(bp, rxr) / agg_size_fac;
  3842		if (BNXT_RX_PAGE_MODE(bp))
  3843			pp.pool_size += bp->rx_ring_size / rx_size_fac;
  3844	
  3845		pp.order = get_order(rxr->rx_page_size);
  3846		pp.nid = numa_node;
  3847		pp.netdev = bp->dev;
  3848		pp.dev = &bp->pdev->dev;
  3849		pp.dma_dir = bp->rx_dir;
  3850		pp.max_len = PAGE_SIZE << pp.order;
  3851		pp.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV |
  3852			   PP_FLAG_ALLOW_UNREADABLE_NETMEM;
  3853		pp.queue_idx = rxr->bnapi->index;
  3854	
  3855		pool = page_pool_create(&pp);
  3856		if (IS_ERR(pool))
  3857			return PTR_ERR(pool);
  3858		rxr->page_pool = pool;
  3859	
  3860		rxr->need_head_pool = page_pool_is_unreadable(pool);
  3861		rxr->need_head_pool |= !!pp.order;
  3862		if (bnxt_separate_head_pool(rxr)) {
  3863			pp.order = 0;
  3864			pp.max_len = PAGE_SIZE;
  3865			pp.pool_size = min(bp->rx_ring_size / rx_size_fac, 1024);
  3866			pp.flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV;
  3867			pool = page_pool_create(&pp);
  3868			if (IS_ERR(pool))
  3869				goto err_destroy_pp;
  3870		}
  3871		rxr->head_pool = pool;
  3872	
  3873		return 0;
  3874	
  3875	err_destroy_pp:
  3876		page_pool_destroy(rxr->page_pool);
  3877		rxr->page_pool = NULL;
  3878		return PTR_ERR(pool);
  3879	}
  3880	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki