From: Petr Vorel <pvorel@suse.cz>
To: Pedro Falcato <pfalcato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] sigrelse01: Select signals based on SIGRTMIN/SIGRTMAX for musl compat
Date: Mon, 18 Aug 2025 22:02:10 +0200 [thread overview]
Message-ID: <20250818200210.GA178161@pevik> (raw)
In-Reply-To: <wfecvwzibjekda24wzhou5ppngxhptrmn4ks4kg4adwwiizefz@z2ddqcqhr6pd>
Hi Florian, Pedro,
> On Mon, Aug 18, 2025 at 03:00:38PM +0200, Petr Vorel wrote:
> > Hi Florian, Pedro,
> > > This avoids selecting signal 34 when the test is run using
> > > musl. Signal 34 is used internally by musl as SIGSYNCCALL.
> > > Consequently, musl's signal() will return with an error status and
> > > errno set to EINVAL when trying to setup a signal handler for signal
> > > 34, causing the sigrelse01 test to fail.
> > +1, now it works on both glibc and musl (and hopefully in the rest of libc).
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Tested-by: Petr Vorel <pvorel@suse.cz>
> > > Thanks to Pedro Falcato for suggesting using SIGRTMIN and SIGRTMAX for
> > > this check.
> > nit: @Florian instead of the above I'll add:
> > Suggested-by: Pedro Falcato <pfalcato@suse.de>
> > @Pedro Can I merge with your RBT?
> Assuming you mean Reviewed-by, yep, all fine by me.
Thank you both! Patch merged.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2025-08-18 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 15:26 [LTP] [PATCH v3] sigrelse01: Select signals based on SIGRTMIN/SIGRTMAX for musl compat Florian Schmaus via ltp
2025-08-18 13:00 ` Petr Vorel
2025-08-18 15:35 ` Pedro Falcato
2025-08-18 20:02 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818200210.GA178161@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pfalcato@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.