* arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1378 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented
@ 2025-08-19 0:39 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-08-19 0:39 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Maxim Levitsky <mlevitsk@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: be48bcf004f9d0c9207ff21d0edb3b42f253829e
commit: e4a454ced74c0ac97c8bd32f086ee3ad74528780 KVM: add kvm_lock_all_vcpus and kvm_trylock_all_vcpus
date: 3 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 3 months ago
config: loongarch-randconfig-r073-20250818 (https://download.01.org/0day-ci/archive/20250819/202508190853.WCSkhkog-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508190853.WCSkhkog-lkp@intel.com/
New smatch warnings:
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1378 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1384 kvm_trylock_all_vcpus() warn: iterator 'j' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1401 kvm_lock_all_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1409 kvm_lock_all_vcpus() warn: iterator 'j' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1425 kvm_unlock_all_vcpus() warn: iterator 'i' not incremented
Old smatch warnings:
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:283 kvm_make_all_cpus_request() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:487 kvm_destroy_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1721 kvm_commit_memory_region() error: we previously assumed 'old' could be null (see line 1714)
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1723 kvm_commit_memory_region() error: we previously assumed 'new' could be null (see line 1715)
include/linux/kvm_host.h:1010 kvm_get_vcpu_by_id() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:4961 kvm_vm_ioctl_reset_dirty_pages() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:6092 kvm_get_stat_per_vcpu() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:6103 kvm_clear_stat_per_vcpu() warn: iterator 'i' not incremented
vim +/i +1378 arch/loongarch/kvm/../../../virt/kvm/kvm_main.c
6aa8b732ca01c3 drivers/kvm/kvm_main.c Avi Kivity 2006-12-10 1370
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1371 int kvm_trylock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1372 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1373 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1374 unsigned long i, j;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1375
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1376 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1377
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1378 kvm_for_each_vcpu(i, vcpu, kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1379 if (!mutex_trylock_nest_lock(&vcpu->mutex, &kvm->lock))
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1380 goto out_unlock;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1381 return 0;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1382
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1383 out_unlock:
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1384 kvm_for_each_vcpu(j, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1385 if (i == j)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1386 break;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1387 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1388 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1389 return -EINTR;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1390 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1391 EXPORT_SYMBOL_GPL(kvm_trylock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1392
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1393 int kvm_lock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1394 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1395 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1396 unsigned long i, j;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1397 int r;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1398
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1399 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1400
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1401 kvm_for_each_vcpu(i, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1402 r = mutex_lock_killable_nest_lock(&vcpu->mutex, &kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1403 if (r)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1404 goto out_unlock;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1405 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1406 return 0;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1407
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1408 out_unlock:
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1409 kvm_for_each_vcpu(j, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1410 if (i == j)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1411 break;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1412 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1413 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1414 return r;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1415 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1416 EXPORT_SYMBOL_GPL(kvm_lock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1417
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1418 void kvm_unlock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1419 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1420 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1421 unsigned long i;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1422
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1423 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1424
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1425 kvm_for_each_vcpu(i, vcpu, kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1426 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1427 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1428 EXPORT_SYMBOL_GPL(kvm_unlock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1429
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1378 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented
@ 2025-12-25 14:59 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2025-12-25 14:59 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Maxim Levitsky <mlevitsk@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: ccd1cdca5cd433c8a5dff78b69a79b31d9b77ee1
commit: e4a454ced74c0ac97c8bd32f086ee3ad74528780 KVM: add kvm_lock_all_vcpus and kvm_trylock_all_vcpus
date: 7 months ago
:::::: branch date: 22 hours ago
:::::: commit date: 7 months ago
config: loongarch-randconfig-r071-20251225 (https://download.01.org/0day-ci/archive/20251225/202512252219.X41v9csT-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.5.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202512252219.X41v9csT-lkp@intel.com/
New smatch warnings:
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1378 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1384 kvm_trylock_all_vcpus() warn: iterator 'j' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1401 kvm_lock_all_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1409 kvm_lock_all_vcpus() warn: iterator 'j' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1425 kvm_unlock_all_vcpus() warn: iterator 'i' not incremented
Old smatch warnings:
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:283 kvm_make_all_cpus_request() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:487 kvm_destroy_vcpus() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1721 kvm_commit_memory_region() error: we previously assumed 'old' could be null (see line 1714)
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1723 kvm_commit_memory_region() error: we previously assumed 'new' could be null (see line 1715)
include/linux/kvm_host.h:1010 kvm_get_vcpu_by_id() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:4961 kvm_vm_ioctl_reset_dirty_pages() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:6092 kvm_get_stat_per_vcpu() warn: iterator 'i' not incremented
arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:6103 kvm_clear_stat_per_vcpu() warn: iterator 'i' not incremented
vim +/i +1378 arch/loongarch/kvm/../../../virt/kvm/kvm_main.c
6aa8b732ca01c3 drivers/kvm/kvm_main.c Avi Kivity 2006-12-10 1370
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1371 int kvm_trylock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1372 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1373 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1374 unsigned long i, j;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1375
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1376 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1377
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1378 kvm_for_each_vcpu(i, vcpu, kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1379 if (!mutex_trylock_nest_lock(&vcpu->mutex, &kvm->lock))
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1380 goto out_unlock;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1381 return 0;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1382
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1383 out_unlock:
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1384 kvm_for_each_vcpu(j, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1385 if (i == j)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1386 break;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1387 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1388 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1389 return -EINTR;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1390 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1391 EXPORT_SYMBOL_GPL(kvm_trylock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1392
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1393 int kvm_lock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1394 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1395 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1396 unsigned long i, j;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1397 int r;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1398
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1399 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1400
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1401 kvm_for_each_vcpu(i, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1402 r = mutex_lock_killable_nest_lock(&vcpu->mutex, &kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1403 if (r)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1404 goto out_unlock;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1405 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1406 return 0;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1407
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1408 out_unlock:
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1409 kvm_for_each_vcpu(j, vcpu, kvm) {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1410 if (i == j)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1411 break;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1412 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1413 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1414 return r;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1415 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1416 EXPORT_SYMBOL_GPL(kvm_lock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1417
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1418 void kvm_unlock_all_vcpus(struct kvm *kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1419 {
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1420 struct kvm_vcpu *vcpu;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1421 unsigned long i;
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1422
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1423 lockdep_assert_held(&kvm->lock);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1424
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 @1425 kvm_for_each_vcpu(i, vcpu, kvm)
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1426 mutex_unlock(&vcpu->mutex);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1427 }
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1428 EXPORT_SYMBOL_GPL(kvm_unlock_all_vcpus);
e4a454ced74c0a virt/kvm/kvm_main.c Maxim Levitsky 2025-05-12 1429
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-25 14:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 0:39 arch/loongarch/kvm/../../../virt/kvm/kvm_main.c:1378 kvm_trylock_all_vcpus() warn: iterator 'i' not incremented kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2025-12-25 14:59 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.