All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	andrew+netdev@lunn.ch, horms@kernel.org, almasrymina@google.com,
	michael.chan@broadcom.com, tariqt@nvidia.com,
	dtatulea@nvidia.com, hawk@kernel.org,
	ilias.apalodimas@linaro.org, alexanderduyck@fb.com,
	sdf@fomichev.me, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 00/15] eth: fbnic: support queue API and zero-copy Rx
Date: Tue, 19 Aug 2025 19:56:49 -0700	[thread overview]
Message-ID: <20250820025704.166248-1-kuba@kernel.org> (raw)

Add support for queue API to fbnic, enable zero-copy Rx.

The first patch adds page_pool_get(), I alluded to this
new helper when dicussing commit 64fdaa94bfe0 ("net: page_pool:
allow enabling recycling late, fix false positive warning").
For page pool-oriented reviewers another patch of interest
is patch 11, which adds a helper to test whether rxq wants
to create a unreadable page pool. mlx5 already has this
sort of a check, we said we will add a helper when more
drivers need it (IIRC), so I guess now is the time.

Patches 2-4 reshuffle the Rx init/allocation path to better
align structures and functions which operate on them. Notably
patch 2 moves the page pool pointer to the queue struct (from
NAPI).

Patch 5 converts the driver to use netmem_ref. The driver has
separate and explicit buffer queue for scatter / payloads,
so only references to those are converted.

Next 5 patches are more boring code shifts.

Patch 12 adds unreadable memory support to page pool allocation.

Patch 15 finally adds the support for queue API.

  $ ./tools/testing/selftests/drivers/net/hw/iou-zcrx.py
  TAP version 13
  1..3
  ok 1 iou-zcrx.test_zcrx
  ok 2 iou-zcrx.test_zcrx_oneshot
  ok 3 iou-zcrx.test_zcrx_rss
  # Totals: pass:3 fail:0 xfail:0 xpass:0 skip:0 error:0

Jakub Kicinski (15):
  net: page_pool: add page_pool_get()
  eth: fbnic: move page pool pointer from NAPI to the ring struct
  eth: fbnic: move xdp_rxq_info_reg() to resource alloc
  eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources()
  eth: fbnic: use netmem_ref where applicable
  eth: fbnic: request ops lock
  eth: fbnic: split fbnic_disable()
  eth: fbnic: split fbnic_flush()
  eth: fbnic: split fbnic_enable()
  eth: fbnic: split fbnic_fill()
  net: page_pool: add helper to pre-check if PP will be unreadable
  eth: fbnic: allocate unreadable page pool for the payloads
  eth: fbnic: defer page pool recycling activation to queue start
  eth: fbnic: don't pass NAPI into pp alloc
  eth: fbnic: support queue ops / zero-copy Rx

 drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  |  20 +-
 include/net/page_pool/helpers.h               |  14 +
 drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  11 +-
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  10 +-
 .../net/ethernet/meta/fbnic/fbnic_netdev.c    |   1 +
 drivers/net/ethernet/meta/fbnic/fbnic_pci.c   |   9 +-
 drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 621 ++++++++++++------
 net/core/page_pool.c                          |   8 +
 8 files changed, 459 insertions(+), 235 deletions(-)

-- 
2.50.1


             reply	other threads:[~2025-08-20  2:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20  2:56 Jakub Kicinski [this message]
2025-08-20  2:56 ` [PATCH net-next 01/15] net: page_pool: add page_pool_get() Jakub Kicinski
2025-08-20 10:35   ` Jesper Dangaard Brouer
2025-08-20 10:58   ` Dragos Tatulea
2025-08-20 23:11   ` Mina Almasry
2025-08-20  2:56 ` [PATCH net-next 02/15] eth: fbnic: move page pool pointer from NAPI to the ring struct Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 03/15] eth: fbnic: move xdp_rxq_info_reg() to resource alloc Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 04/15] eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources() Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 05/15] eth: fbnic: use netmem_ref where applicable Jakub Kicinski
2025-08-20 23:22   ` Mina Almasry
2025-08-20  2:56 ` [PATCH net-next 06/15] eth: fbnic: request ops lock Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 07/15] eth: fbnic: split fbnic_disable() Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 08/15] eth: fbnic: split fbnic_flush() Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 09/15] eth: fbnic: split fbnic_enable() Jakub Kicinski
2025-08-20  2:56 ` [PATCH net-next 10/15] eth: fbnic: split fbnic_fill() Jakub Kicinski
2025-08-20  2:57 ` [PATCH net-next 11/15] net: page_pool: add helper to pre-check if PP will be unreadable Jakub Kicinski
2025-08-20 11:30   ` Dragos Tatulea
2025-08-20 14:52     ` Jakub Kicinski
2025-08-20 17:45       ` Dragos Tatulea
2025-08-20  2:57 ` [PATCH net-next 12/15] eth: fbnic: allocate unreadable page pool for the payloads Jakub Kicinski
2025-08-20 23:33   ` Mina Almasry
2025-08-21  0:45     ` Jakub Kicinski
2025-08-20  2:57 ` [PATCH net-next 13/15] eth: fbnic: defer page pool recycling activation to queue start Jakub Kicinski
2025-08-20  2:57 ` [PATCH net-next 14/15] eth: fbnic: don't pass NAPI into pp alloc Jakub Kicinski
2025-08-20  2:57 ` [PATCH net-next 15/15] eth: fbnic: support queue ops / zero-copy Rx Jakub Kicinski
2025-08-21  7:51 ` [PATCH net-next 00/15] eth: fbnic: support queue API and " Paolo Abeni
2025-08-21 14:28   ` Jakub Kicinski
2025-08-21 14:53     ` Taehee Yoo
2025-08-21 15:03       ` Jakub Kicinski
2025-08-21 15:22         ` Mina Almasry
2025-08-21 15:42           ` Jakub Kicinski
2025-08-21 15:02     ` Paolo Abeni
2025-08-21 15:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250820025704.166248-1-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexanderduyck@fb.com \
    --cc=almasrymina@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dtatulea@nvidia.com \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.