From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
michael.chan@broadcom.com, tariqt@nvidia.com,
dtatulea@nvidia.com, hawk@kernel.org,
ilias.apalodimas@linaro.org, alexanderduyck@fb.com,
sdf@fomichev.me
Subject: Re: [PATCH net-next 12/15] eth: fbnic: allocate unreadable page pool for the payloads
Date: Wed, 20 Aug 2025 17:45:21 -0700 [thread overview]
Message-ID: <20250820174521.41251949@kernel.org> (raw)
In-Reply-To: <CAHS8izMEwmcMQ7Z53Z6uV6NJyVQ40ew+CMmCBMHjwYNC3QtdMA@mail.gmail.com>
On Wed, 20 Aug 2025 16:33:18 -0700 Mina Almasry wrote:
> > + if (page_pool_rxq_wants_unreadable(&pp_params)) {
> > + pp_params.flags |= PP_FLAG_ALLOW_UNREADABLE_NETMEM;
> > + pp_params.dma_dir = DMA_FROM_DEVICE;
> > +
>
> Although I'm not sure why the dma_dir needed to change specifically
> for unreadable.
Driver defaults to BIDIR AFAIU to avoid having to reset the
datapath when XDP is bound. But BIDIR is not compatible with
unreadable mem, and for good reason.
Will add to the commit msg.
next prev parent reply other threads:[~2025-08-21 0:45 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 2:56 [PATCH net-next 00/15] eth: fbnic: support queue API and zero-copy Rx Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 01/15] net: page_pool: add page_pool_get() Jakub Kicinski
2025-08-20 10:35 ` Jesper Dangaard Brouer
2025-08-20 10:58 ` Dragos Tatulea
2025-08-20 23:11 ` Mina Almasry
2025-08-20 2:56 ` [PATCH net-next 02/15] eth: fbnic: move page pool pointer from NAPI to the ring struct Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 03/15] eth: fbnic: move xdp_rxq_info_reg() to resource alloc Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 04/15] eth: fbnic: move page pool alloc to fbnic_alloc_rx_qt_resources() Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 05/15] eth: fbnic: use netmem_ref where applicable Jakub Kicinski
2025-08-20 23:22 ` Mina Almasry
2025-08-20 2:56 ` [PATCH net-next 06/15] eth: fbnic: request ops lock Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 07/15] eth: fbnic: split fbnic_disable() Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 08/15] eth: fbnic: split fbnic_flush() Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 09/15] eth: fbnic: split fbnic_enable() Jakub Kicinski
2025-08-20 2:56 ` [PATCH net-next 10/15] eth: fbnic: split fbnic_fill() Jakub Kicinski
2025-08-20 2:57 ` [PATCH net-next 11/15] net: page_pool: add helper to pre-check if PP will be unreadable Jakub Kicinski
2025-08-20 11:30 ` Dragos Tatulea
2025-08-20 14:52 ` Jakub Kicinski
2025-08-20 17:45 ` Dragos Tatulea
2025-08-20 2:57 ` [PATCH net-next 12/15] eth: fbnic: allocate unreadable page pool for the payloads Jakub Kicinski
2025-08-20 23:33 ` Mina Almasry
2025-08-21 0:45 ` Jakub Kicinski [this message]
2025-08-20 2:57 ` [PATCH net-next 13/15] eth: fbnic: defer page pool recycling activation to queue start Jakub Kicinski
2025-08-20 2:57 ` [PATCH net-next 14/15] eth: fbnic: don't pass NAPI into pp alloc Jakub Kicinski
2025-08-20 2:57 ` [PATCH net-next 15/15] eth: fbnic: support queue ops / zero-copy Rx Jakub Kicinski
2025-08-21 7:51 ` [PATCH net-next 00/15] eth: fbnic: support queue API and " Paolo Abeni
2025-08-21 14:28 ` Jakub Kicinski
2025-08-21 14:53 ` Taehee Yoo
2025-08-21 15:03 ` Jakub Kicinski
2025-08-21 15:22 ` Mina Almasry
2025-08-21 15:42 ` Jakub Kicinski
2025-08-21 15:02 ` Paolo Abeni
2025-08-21 15:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820174521.41251949@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.