From: Christoph Hellwig <hch@lst.de>
To: Kanchan Joshi <joshi.k@samsung.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
sagi@grimberg.me, linux-nvme@lists.infradead.org,
martin.petersen@oracle.com
Subject: Re: [PATCH] nvme: fix PI insert on write
Date: Thu, 21 Aug 2025 10:33:01 +0200 [thread overview]
Message-ID: <20250821083301.GA29224@lst.de> (raw)
In-Reply-To: <c78a7ce0-1bee-4773-9f29-45f68c9fb5ff@samsung.com>
On Thu, Aug 21, 2025 at 10:32:13AM +0530, Kanchan Joshi wrote:
> On 8/20/2025 8:09 PM, Keith Busch wrote:
> >> @@ -1039,6 +1039,7 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns,
> >> if (WARN_ON_ONCE(!nvme_ns_has_pi(ns->head)))
> >> return BLK_STS_NOTSUPP;
> >> control |= NVME_RW_PRINFO_PRACT;
> >> + nvme_set_ref_tag(ns, cmnd, req);
> >> }
> > Do we need to check that it's type 1 or 2 before setting this?
>
> Seems so.
> And if the check moves inside nvme_set_ref_tag(), it will keep
> current/future call-sites simple.
Yes, that was my thought as well when reading Keith' reply.
prev parent reply other threads:[~2025-08-21 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:11 [PATCH] nvme: fix PI insert on write Christoph Hellwig
2025-08-20 14:39 ` Keith Busch
2025-08-21 5:02 ` Kanchan Joshi
2025-08-21 8:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821083301.GA29224@lst.de \
--to=hch@lst.de \
--cc=joshi.k@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.