From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org,
martin.petersen@oracle.com
Subject: Re: [PATCH] nvme: fix PI insert on write
Date: Wed, 20 Aug 2025 08:39:06 -0600 [thread overview]
Message-ID: <aKXeCrrvy_0crpmn@kbusch-mbp> (raw)
In-Reply-To: <20250820081150.2463767-1-hch@lst.de>
On Wed, Aug 20, 2025 at 10:11:47AM +0200, Christoph Hellwig wrote:
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 9707a0e8c431..3bd6ffd1f809 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1039,6 +1039,7 @@ static inline blk_status_t nvme_setup_rw(struct nvme_ns *ns,
> if (WARN_ON_ONCE(!nvme_ns_has_pi(ns->head)))
> return BLK_STS_NOTSUPP;
> control |= NVME_RW_PRINFO_PRACT;
> + nvme_set_ref_tag(ns, cmnd, req);
> }
Do we need to check that it's type 1 or 2 before setting this?
next prev parent reply other threads:[~2025-08-20 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 8:11 [PATCH] nvme: fix PI insert on write Christoph Hellwig
2025-08-20 14:39 ` Keith Busch [this message]
2025-08-21 5:02 ` Kanchan Joshi
2025-08-21 8:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKXeCrrvy_0crpmn@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.