All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH nvmetcli] nvmet: store DHCHAP attributes
@ 2025-08-22 11:51 hare
  2025-09-30 11:55 ` Hannes Reinecke
  0 siblings, 1 reply; 2+ messages in thread
From: hare @ 2025-08-22 11:51 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: Keith Busch, Sagi Grimberg, linux-nvme, Hannes Reinecke

From: Hannes Reinecke <hare@kernel.org>

The DHCHAP authentication is stored under hosts/, and are starting
with 'dhchap_'. So add a 'dhchap' attribute group for the host object
to correctly save and restore DHCHAP values.

Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
 nvmet/nvme.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 59efdb5..679116e 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -892,6 +892,7 @@ class Host(CFSNode):
         '''
         super(Host, self).__init__()
 
+        self.attr_groups = ['dhchap']
         self.nqn = nqn
         self._path = "%s/hosts/%s" % (self.configfs_dir, nqn)
         self._create_in_cfs(mode)
-- 
2.43.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH nvmetcli] nvmet: store DHCHAP attributes
  2025-08-22 11:51 [PATCH nvmetcli] nvmet: store DHCHAP attributes hare
@ 2025-09-30 11:55 ` Hannes Reinecke
  0 siblings, 0 replies; 2+ messages in thread
From: Hannes Reinecke @ 2025-09-30 11:55 UTC (permalink / raw)
  To: hare, Christoph Hellwig; +Cc: Keith Busch, Sagi Grimberg, linux-nvme

On 8/22/25 13:51, hare@kernel.org wrote:
> From: Hannes Reinecke <hare@kernel.org>
> 
> The DHCHAP authentication is stored under hosts/, and are starting
> with 'dhchap_'. So add a 'dhchap' attribute group for the host object
> to correctly save and restore DHCHAP values.
> 
> Signed-off-by: Hannes Reinecke <hare@kernel.org>
> ---
>   nvmet/nvme.py | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/nvmet/nvme.py b/nvmet/nvme.py
> index 59efdb5..679116e 100644
> --- a/nvmet/nvme.py
> +++ b/nvmet/nvme.py
> @@ -892,6 +892,7 @@ class Host(CFSNode):
>           '''
>           super(Host, self).__init__()
>   
> +        self.attr_groups = ['dhchap']
>           self.nqn = nqn
>           self._path = "%s/hosts/%s" % (self.configfs_dir, nqn)
>           self._create_in_cfs(mode)

Christoph?
Ping?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-09-30 11:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 11:51 [PATCH nvmetcli] nvmet: store DHCHAP attributes hare
2025-09-30 11:55 ` Hannes Reinecke

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.