[PATCH nvmetcli] 'discovery_nqn' configfs attribute

[PATCH nvmetcli] 'discovery_nqn' configfs attribute

[hare]

From: Hannes Reinecke <hare@kernel.org>

Implement support for the 'discovery_nqn' configfs attribute to
allow the user to read or modify the persistent discovery NQN.

Signed-off-by: Hannes Reinecke <hare@kernel.org>
---
 nvmet/nvme.py | 1 +
 nvmetcli      | 8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/nvmet/nvme.py b/nvmet/nvme.py
index 59efdb5..5111db7 100644
--- a/nvmet/nvme.py
+++ b/nvmet/nvme.py
@@ -234,6 +234,7 @@ class Root(CFSNode):
     def __init__(self):
         super(Root, self).__init__()
 
+        self.attr_groups = ['discovery']
         if not os.path.isdir(self.configfs_dir):
             self._modprobe('nvmet')
 
diff --git a/nvmetcli b/nvmetcli
index d949891..9df6e89 100755
--- a/nvmetcli
+++ b/nvmetcli
@@ -94,10 +94,18 @@ class UINode(configshell.node.ConfigNode):
 
 
 class UIRootNode(UINode):
+    ui_desc_discovery = {
+        'nqn': ('string', 'Discovery NQN'),
+    }
     def __init__(self, shell):
         UINode.__init__(self, '/', parent=None, cfnode=nvme.Root(),
                         shell=shell)
 
+    def summary(self):
+        info = []
+        info.append("discovery=" + self.cfnode.get_attr("discovery", "nqn"))
+        return (", ".join(info), True)
+
     def refresh(self):
         self._children = set([])
         UISubsystemsNode(self)
-- 
2.43.0

Re: [PATCH nvmetcli] 'discovery_nqn' configfs attribute

[Hannes Reinecke]

On 8/22/25 13:54, hare@kernel.org wrote:
> From: Hannes Reinecke <hare@kernel.org>
> 
> Implement support for the 'discovery_nqn' configfs attribute to
> allow the user to read or modify the persistent discovery NQN.
> 
Christoph,

ping?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@suse.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich