From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/gpu/drm/msm/msm_iommu.c:778 msm_iommu_gpu_new() error: we previously assumed 'adreno_smmu' could be null (see line 767)
Date: Sat, 23 Aug 2025 00:56:30 +0800 [thread overview]
Message-ID: <202508230010.dMoERmOs-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Rob Clark <robdclark@chromium.org>
CC: Antonino Maniscalco <antomani103@gmail.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cf6fc5eefc5bbbbff92a085039ff74cdbd065c29
commit: e601ea31d66ba83d565cae9cfa45cbbcdd8286dd drm/msm: Support pgtable preallocation
date: 7 weeks ago
:::::: branch date: 3 hours ago
:::::: commit date: 7 weeks ago
config: arm64-randconfig-r071-20250822 (https://download.01.org/0day-ci/archive/20250823/202508230010.dMoERmOs-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202508230010.dMoERmOs-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/msm/msm_iommu.c:778 msm_iommu_gpu_new() error: we previously assumed 'adreno_smmu' could be null (see line 767)
vim +/adreno_smmu +778 drivers/gpu/drm/msm/msm_iommu.c
c37d9f0b1a1873 Abhinav Kumar 2025-02-19 755
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 756 struct msm_mmu *msm_iommu_gpu_new(struct device *dev, struct msm_gpu *gpu, unsigned long quirks)
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 757 {
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 758 struct adreno_smmu_priv *adreno_smmu = dev_get_drvdata(dev);
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 759 struct msm_iommu *iommu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 760 struct msm_mmu *mmu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 761
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 762 mmu = msm_iommu_new(dev, quirks);
db40d2928d245f Luca Weiss 2023-05-08 763 if (IS_ERR_OR_NULL(mmu))
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 764 return mmu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 765
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 766 iommu = to_msm_iommu(mmu);
e601ea31d66ba8 Rob Clark 2025-06-29 @767 if (adreno_smmu && adreno_smmu->cookie) {
e601ea31d66ba8 Rob Clark 2025-06-29 768 const struct io_pgtable_cfg *cfg =
e601ea31d66ba8 Rob Clark 2025-06-29 769 adreno_smmu->get_ttbr1_cfg(adreno_smmu->cookie);
e601ea31d66ba8 Rob Clark 2025-06-29 770 size_t tblsz = get_tblsz(cfg);
e601ea31d66ba8 Rob Clark 2025-06-29 771
e601ea31d66ba8 Rob Clark 2025-06-29 772 iommu->pt_cache =
e601ea31d66ba8 Rob Clark 2025-06-29 773 kmem_cache_create("msm-mmu-pt", tblsz, tblsz, 0, NULL);
e601ea31d66ba8 Rob Clark 2025-06-29 774 }
f66f3cf6bc42ab Abhinav Kumar 2025-02-19 775 iommu_set_fault_handler(iommu->domain, msm_gpu_fault_handler, iommu);
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 776
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 777 /* Enable stall on iommu fault: */
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 @778 if (adreno_smmu->set_stall)
:::::: The code at line 778 was first introduced by commit
:::::: 8cceb773f565f3a6e3c6c09198aef5a394154ca9 drm/msm/adreno: stall translation on fault for all GPU families
:::::: TO: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
:::::: CC: Rob Clark <robdclark@chromium.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Rob Clark <robdclark@chromium.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org,
Antonino Maniscalco <antomani103@gmail.com>
Subject: drivers/gpu/drm/msm/msm_iommu.c:778 msm_iommu_gpu_new() error: we previously assumed 'adreno_smmu' could be null (see line 767)
Date: Fri, 22 Aug 2025 20:17:25 +0300 [thread overview]
Message-ID: <202508230010.dMoERmOs-lkp@intel.com> (raw)
Message-ID: <20250822171725.D_xP4dPbChpBc1Lk-EEID-jJ82ssG82z4LTul6EDz1o@z> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: cf6fc5eefc5bbbbff92a085039ff74cdbd065c29
commit: e601ea31d66ba83d565cae9cfa45cbbcdd8286dd drm/msm: Support pgtable preallocation
config: arm64-randconfig-r071-20250822 (https://download.01.org/0day-ci/archive/20250823/202508230010.dMoERmOs-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202508230010.dMoERmOs-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/msm/msm_iommu.c:778 msm_iommu_gpu_new() error: we previously assumed 'adreno_smmu' could be null (see line 767)
vim +/adreno_smmu +778 drivers/gpu/drm/msm/msm_iommu.c
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 756 struct msm_mmu *msm_iommu_gpu_new(struct device *dev, struct msm_gpu *gpu, unsigned long quirks)
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 757 {
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 758 struct adreno_smmu_priv *adreno_smmu = dev_get_drvdata(dev);
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 759 struct msm_iommu *iommu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 760 struct msm_mmu *mmu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 761
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 762 mmu = msm_iommu_new(dev, quirks);
db40d2928d245f Luca Weiss 2023-05-08 763 if (IS_ERR_OR_NULL(mmu))
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 764 return mmu;
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 765
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 766 iommu = to_msm_iommu(mmu);
e601ea31d66ba8 Rob Clark 2025-06-29 @767 if (adreno_smmu && adreno_smmu->cookie) {
^^^^^^^^^^^
Check for NULL. Hopefully this can be removed.
e601ea31d66ba8 Rob Clark 2025-06-29 768 const struct io_pgtable_cfg *cfg =
e601ea31d66ba8 Rob Clark 2025-06-29 769 adreno_smmu->get_ttbr1_cfg(adreno_smmu->cookie);
e601ea31d66ba8 Rob Clark 2025-06-29 770 size_t tblsz = get_tblsz(cfg);
e601ea31d66ba8 Rob Clark 2025-06-29 771
e601ea31d66ba8 Rob Clark 2025-06-29 772 iommu->pt_cache =
e601ea31d66ba8 Rob Clark 2025-06-29 773 kmem_cache_create("msm-mmu-pt", tblsz, tblsz, 0, NULL);
e601ea31d66ba8 Rob Clark 2025-06-29 774 }
f66f3cf6bc42ab Abhinav Kumar 2025-02-19 775 iommu_set_fault_handler(iommu->domain, msm_gpu_fault_handler, iommu);
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 776
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 777 /* Enable stall on iommu fault: */
8cceb773f565f3 Dmitry Baryshkov 2023-02-14 @778 if (adreno_smmu->set_stall)
^^^^^^^^^^^^^^^^^^^^^^
Because otherwise we are toasted.
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-08-22 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 16:56 kernel test robot [this message]
2025-08-22 17:17 ` drivers/gpu/drm/msm/msm_iommu.c:778 msm_iommu_gpu_new() error: we previously assumed 'adreno_smmu' could be null (see line 767) Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508230010.dMoERmOs-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.