From: Stephen Hemminger <stephen@networkplumber.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
dsahern@gmail.com, netdev@vger.kernel.org,
haiyangz@microsoft.com, shradhagupta@linux.microsoft.com,
ssengar@microsoft.com, dipayanroy@microsoft.com,
ernis@microsoft.com
Subject: Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping
Date: Sun, 24 Aug 2025 07:23:14 -0700 [thread overview]
Message-ID: <20250824072314.01f35db8@hermes.local> (raw)
In-Reply-To: <20250824134017.GA2917@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Sun, 24 Aug 2025 06:40:17 -0700
Erni Sri Satya Vennela <ernis@linux.microsoft.com> wrote:
> On Thu, Aug 21, 2025 at 07:12:59AM -0700, Jakub Kicinski wrote:
> > On Thu, 21 Aug 2025 04:06:07 -0700 Erni Sri Satya Vennela wrote:
> > > > Somewhat related -- what's your take on integrating / vendoring in YNL?
> > > > mnl doesn't provide any extack support..
> > >
> > > I have done some tests and found that if we install pkg-config and
> > > libmnl packages beforehand. The extack error messages from the kernel
> > > are being printed to the stdout.
> >
> > Sorry, I wasn't very precise, it supports printing the string messages.
> > But nothing that requires actually understanding the message.
> > No bad attribute errors, no missing attribute errors, no policy errors.
>
> Are you referring to the following error logs from the ynl tool?
>
> $./tools/net/ynl/pyynl/cli.py
> --spec Documentation/netlink/specs/net_shaper.yaml
> --do set
> --json '{"ifindex":'3',
> "handle":{"scope": "netdev", "id":'1' },
> "bw-max": 200001000 }'
>
> Netlink error: Invalid argument
> nl_len = 92 (76) nl_flags = 0x300 nl_type = 2
> error: -22
> extack: {'msg': 'mana: Please use multiples of 100Mbps for
> bandwidth'}
>
> If yes, would it be reasonable to add support in iproute2 itself for
> displaying such error logs?
other parts of iproute2 already use libmnl to display extack messages.
next prev parent reply other threads:[~2025-08-24 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 7:05 [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping Erni Sri Satya Vennela
2025-08-11 20:16 ` Haiyang Zhang
2025-08-16 18:05 ` Stephen Hemminger
2025-08-21 10:45 ` Erni Sri Satya Vennela
2025-08-16 22:55 ` Stephen Hemminger
2025-08-18 15:36 ` Jakub Kicinski
2025-08-18 15:41 ` David Ahern
2025-08-18 16:00 ` Jakub Kicinski
2025-08-19 15:27 ` David Ahern
2025-08-21 12:31 ` Erni Sri Satya Vennela
2025-08-21 11:06 ` Erni Sri Satya Vennela
2025-08-21 14:12 ` Jakub Kicinski
2025-08-24 13:40 ` Erni Sri Satya Vennela
2025-08-24 14:23 ` Stephen Hemminger [this message]
2025-08-25 15:52 ` Jakub Kicinski
2025-08-25 16:16 ` Stephen Hemminger
2025-09-01 5:47 ` Erni Sri Satya Vennela
2025-08-21 10:49 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250824072314.01f35db8@hermes.local \
--to=stephen@networkplumber.org \
--cc=dipayanroy@microsoft.com \
--cc=dsahern@gmail.com \
--cc=ernis@linux.microsoft.com \
--cc=ernis@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shradhagupta@linux.microsoft.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.