All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	dsahern@gmail.com, netdev@vger.kernel.org,
	haiyangz@microsoft.com, shradhagupta@linux.microsoft.com,
	ssengar@microsoft.com, dipayanroy@microsoft.com,
	ernis@microsoft.com
Subject: Re: [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping
Date: Mon, 25 Aug 2025 08:52:35 -0700	[thread overview]
Message-ID: <20250825085235.47b430ed@kernel.org> (raw)
In-Reply-To: <20250824134017.GA2917@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>

On Sun, 24 Aug 2025 06:40:17 -0700 Erni Sri Satya Vennela wrote:
> > Sorry, I wasn't very precise, it supports printing the string messages.
> > But nothing that requires actually understanding the message.
> > No bad attribute errors, no missing attribute errors, no policy errors.  
> 
> Are you referring to the following error logs from the ynl tool?
> 
> $./tools/net/ynl/pyynl/cli.py
>  --spec Documentation/netlink/specs/net_shaper.yaml
>  --do set 
>  --json '{"ifindex":'3',
> 	  "handle":{"scope": "netdev", "id":'1' },
> 	  "bw-max": 200001000 }'
> 
> Netlink error: Invalid argument
> nl_len = 92 (76) nl_flags = 0x300 nl_type = 2
>         error: -22
>         extack: {'msg': 'mana: Please use multiples of 100Mbps for
> bandwidth'}

Not 'msg', the other types, for example miss-type, bad-attr:

$ ynl --family net_shaper --do get
Netlink error: Invalid argument
nl_len = 44 (28) nl_flags = 0x300 nl_type = 2
	error: -22
	extack: {'miss-type': 'ifindex', 'miss-type-doc': 'Interface index owning the specified shaper.'}

$ ynl --family net_shaper --do get --json '{"ifindex": 1}'
Netlink error: Operation not supported
nl_len = 44 (28) nl_flags = 0x300 nl_type = 2
	error: -95
	extack: {'bad-attr': '.ifindex'}

> If yes, would it be reasonable to add support in iproute2 itself for
> displaying such error logs?

  parent reply	other threads:[~2025-08-25 15:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11  7:05 [PATCH iproute2-next v3] iproute2: Add 'netshaper' command to 'ip link' for netdev shaping Erni Sri Satya Vennela
2025-08-11 20:16 ` Haiyang Zhang
2025-08-16 18:05 ` Stephen Hemminger
2025-08-21 10:45   ` Erni Sri Satya Vennela
2025-08-16 22:55 ` Stephen Hemminger
2025-08-18 15:36   ` Jakub Kicinski
2025-08-18 15:41     ` David Ahern
2025-08-18 16:00       ` Jakub Kicinski
2025-08-19 15:27         ` David Ahern
2025-08-21 12:31         ` Erni Sri Satya Vennela
2025-08-21 11:06     ` Erni Sri Satya Vennela
2025-08-21 14:12       ` Jakub Kicinski
2025-08-24 13:40         ` Erni Sri Satya Vennela
2025-08-24 14:23           ` Stephen Hemminger
2025-08-25 15:52           ` Jakub Kicinski [this message]
2025-08-25 16:16       ` Stephen Hemminger
2025-09-01  5:47         ` Erni Sri Satya Vennela
2025-08-21 10:49   ` Erni Sri Satya Vennela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825085235.47b430ed@kernel.org \
    --to=kuba@kernel.org \
    --cc=dipayanroy@microsoft.com \
    --cc=dsahern@gmail.com \
    --cc=ernis@linux.microsoft.com \
    --cc=ernis@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=shradhagupta@linux.microsoft.com \
    --cc=ssengar@microsoft.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.