All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
	Kory Maincent <kory.maincent@bootlin.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	kernel@pengutronix.de,
	Dent Project <dentproject@linuxfoundation.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Kyle Swenson <kyle.swenson@est.tech>
Subject: Re: [PATCH net-next 2/2] net: pse-pd: pd692x0: Add sysfs interface for configuration save/reset
Date: Mon, 25 Aug 2025 15:14:22 -0700	[thread overview]
Message-ID: <20250825151422.4cd1ea72@kernel.org> (raw)
In-Reply-To: <6317ad1e-7507-4a61-92d0-865c52736b1a@lunn.ch>

On Mon, 25 Aug 2025 14:18:25 +0200 Andrew Lunn wrote:
> On Mon, Aug 25, 2025 at 11:14:03AM +0200, Oleksij Rempel wrote:
> > On Mon, Aug 25, 2025 at 10:47:21AM +0200, Kory Maincent wrote:  
> > > > I've not looked at the sysfs documentation. Are there other examples
> > > > of such a property?  
> > > 
> > > Not sure for that particular save/reset configuration case.
> > > Have you another implementation idea in mind?  
> > 
> > My personal preference would be to use devlink (netlink based)
> > interface.  
> 
> Yes, devlink also crossed my mind, probably devlink params. Although
> saving the current configuration to non-volatile memory is more a meta
> parameter.

This is a bit of a perennial topic. Most datacenter NIC vendors have 
a way to save link settings and alike to flash. None bothered with
adding upstream APIs tho. If the configs are fully within ethtool
I think we should be able to add an ethtool header flag that says 
"this config request is to be written to flash". And vice versa 
(get should read from flash)?

Resetting would work either via devlink reload, or ethtool --reset,
don't think we even need any API addition there.

  reply	other threads:[~2025-08-25 22:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 15:37 [PATCH net-next 0/2] net: pse-pd: pd692x0: Add permanent configuration management support Kory Maincent
2025-08-22 15:37 ` [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Kory Maincent
2025-08-25 22:10   ` Jakub Kicinski
2025-08-28  8:46     ` Kory Maincent
2025-08-28 22:12       ` Jakub Kicinski
2025-08-29  8:26         ` Kory Maincent
2025-08-29 23:58           ` Jakub Kicinski
2025-08-22 15:37 ` [PATCH net-next 2/2] net: pse-pd: pd692x0: Add sysfs interface for configuration save/reset Kory Maincent
2025-08-22 17:17   ` Andrew Lunn
2025-08-25  8:47     ` Kory Maincent
2025-08-25  9:14       ` Oleksij Rempel
2025-08-25 12:18         ` Andrew Lunn
2025-08-25 22:14           ` Jakub Kicinski [this message]
2025-08-28 11:29             ` Kory Maincent
2025-08-28 22:15               ` Jakub Kicinski
2025-08-25 12:20         ` Kory Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825151422.4cd1ea72@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dentproject@linuxfoundation.org \
    --cc=edumazet@google.com \
    --cc=kernel@pengutronix.de \
    --cc=kory.maincent@bootlin.com \
    --cc=kyle.swenson@est.tech \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.