From: Jakub Kicinski <kuba@kernel.org>
To: Kory Maincent <kory.maincent@bootlin.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de,
Dent Project <dentproject@linuxfoundation.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>
Subject: Re: [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup
Date: Fri, 29 Aug 2025 16:58:46 -0700 [thread overview]
Message-ID: <20250829165846.1cee2798@kernel.org> (raw)
In-Reply-To: <20250829102624.1d959943@kmaincent-XPS-13-7390>
On Fri, 29 Aug 2025 10:26:24 +0200 Kory Maincent wrote:
> > > I don't think so, as manager is declared like the following it should not.
> > > struct pd692x0_manager *manager __free(kfree) = NULL;
> >
> > Please consult documentation on the user of __free() within networking.
>
> Oh, I didn't know about this net policy.
> I didn't follow the maintainer-netdev doc changes. Maybe I should.
> Ok, I will add a patch to the series to remove the __free macro.
Up to you on existing code, but maybe avoid using it in the future?
next prev parent reply other threads:[~2025-08-29 23:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 15:37 [PATCH net-next 0/2] net: pse-pd: pd692x0: Add permanent configuration management support Kory Maincent
2025-08-22 15:37 ` [PATCH net-next 1/2] net: pse-pd: pd692x0: Separate configuration parsing from hardware setup Kory Maincent
2025-08-25 22:10 ` Jakub Kicinski
2025-08-28 8:46 ` Kory Maincent
2025-08-28 22:12 ` Jakub Kicinski
2025-08-29 8:26 ` Kory Maincent
2025-08-29 23:58 ` Jakub Kicinski [this message]
2025-08-22 15:37 ` [PATCH net-next 2/2] net: pse-pd: pd692x0: Add sysfs interface for configuration save/reset Kory Maincent
2025-08-22 17:17 ` Andrew Lunn
2025-08-25 8:47 ` Kory Maincent
2025-08-25 9:14 ` Oleksij Rempel
2025-08-25 12:18 ` Andrew Lunn
2025-08-25 22:14 ` Jakub Kicinski
2025-08-28 11:29 ` Kory Maincent
2025-08-28 22:15 ` Jakub Kicinski
2025-08-25 12:20 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829165846.1cee2798@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.