From: Jakub Kicinski <kuba@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: pratheesh@ti.com, vigneshr@ti.com, praneeth@ti.com,
edumazet@google.com, glaroque@baylibre.com, pmohan@couthit.com,
diogo.ivo@siemens.com, robh@kernel.org,
javier.carrasco.cruz@gmail.com, saikrishnag@marvell.com,
m-karicheri2@ti.com, bastien.curutchet@bootlin.com,
mohan@couthit.com, jacob.e.keller@intel.com, pabeni@redhat.com,
s.hauer@pengutronix.de, devicetree@vger.kernel.org,
conor+dt@kernel.org, alok.a.tiwari@oracle.com,
richardcochran@gmail.com, johan@kernel.org, prajith@ti.com,
rogerq@kernel.org, basharath@couthit.com, ssantosh@kernel.org,
vadim.fedorenko@linux.dev, linux-arm-kernel@lists.infradead.org,
rogerq@ti.com, srk@ti.com, kory.maincent@bootlin.com,
m-malladi@ti.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, danishanwar@ti.com, afd@ti.com,
andrew+netdev@lunn.ch, horms@kernel.org, krishna@couthit.com,
krzk+dt@kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link detection, RX and TX support.
Date: Wed, 27 Aug 2025 09:08:20 -0700 [thread overview]
Message-ID: <20250827090820.12a58d22@kernel.org> (raw)
In-Reply-To: <20250822144023.2772544-5-parvathi@couthit.com>
On Fri, 22 Aug 2025 20:09:16 +0530 Parvathi Pudi wrote:
> + struct net_device_stats *ndevstats;
> + ndevstats = &emac->ndev->stats;
Please don't use netdev stats, quoting the header:
struct net_device_stats stats; /* not used by modern drivers */
Store the counters you need in driver's private struct and implement
.ndo_get_stats64
> + if (!pkt_info->sv_frame) {
sv_frame seems to always be false at this stage?
Maybe delete this diff if that's the case, otherwise it feels like
the skb_free below should be accompanied by some stat increment.
> + skb_put(skb, actual_pkt_len);
> +
> + /* send packet up the stack */
> + skb->protocol = eth_type_trans(skb, ndev);
> + netif_receive_skb(skb);
> + } else {
> + dev_kfree_skb_any(skb);
> + }
The rest LGTM.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Parvathi Pudi <parvathi@couthit.com>
Cc: danishanwar@ti.com, rogerq@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
ssantosh@kernel.org, richardcochran@gmail.com, m-malladi@ti.com,
s.hauer@pengutronix.de, afd@ti.com, jacob.e.keller@intel.com,
horms@kernel.org, johan@kernel.org, m-karicheri2@ti.com,
s-anna@ti.com, glaroque@baylibre.com, saikrishnag@marvell.com,
kory.maincent@bootlin.com, diogo.ivo@siemens.com,
javier.carrasco.cruz@gmail.com, basharath@couthit.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
vadim.fedorenko@linux.dev, alok.a.tiwari@oracle.com,
bastien.curutchet@bootlin.com, pratheesh@ti.com, prajith@ti.com,
vigneshr@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com,
krishna@couthit.com, pmohan@couthit.com, mohan@couthit.com
Subject: Re: [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link detection, RX and TX support.
Date: Wed, 27 Aug 2025 09:08:20 -0700 [thread overview]
Message-ID: <20250827090820.12a58d22@kernel.org> (raw)
In-Reply-To: <20250822144023.2772544-5-parvathi@couthit.com>
On Fri, 22 Aug 2025 20:09:16 +0530 Parvathi Pudi wrote:
> + struct net_device_stats *ndevstats;
> + ndevstats = &emac->ndev->stats;
Please don't use netdev stats, quoting the header:
struct net_device_stats stats; /* not used by modern drivers */
Store the counters you need in driver's private struct and implement
.ndo_get_stats64
> + if (!pkt_info->sv_frame) {
sv_frame seems to always be false at this stage?
Maybe delete this diff if that's the case, otherwise it feels like
the skb_free below should be accompanied by some stat increment.
> + skb_put(skb, actual_pkt_len);
> +
> + /* send packet up the stack */
> + skb->protocol = eth_type_trans(skb, ndev);
> + netif_receive_skb(skb);
> + } else {
> + dev_kfree_skb_any(skb);
> + }
The rest LGTM.
next prev parent reply other threads:[~2025-08-27 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 13:25 [PATCH net-next v14 0/5] PRU-ICSSM Ethernet Driver Parvathi Pudi
2025-08-22 13:25 ` [PATCH net-next v14 1/5] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx, AM43xx and AM33xx SOCs Parvathi Pudi
2025-08-22 13:25 ` [PATCH net-next v14 2/5] net: ti: icssm-prueth: Adds ICSSM Ethernet driver Parvathi Pudi
2025-09-01 14:48 ` Anwar, Md Danish
2025-09-03 6:23 ` Parvathi Pudi
2025-09-03 6:23 ` Parvathi Pudi
2025-08-22 14:39 ` [PATCH net-next v14 3/5] net: ti: icssm-prueth: Adds PRUETH HW and SW configuration Parvathi Pudi
2025-08-22 14:39 ` [PATCH net-next v14 4/5] net: ti: icssm-prueth: Adds link detection, RX and TX support Parvathi Pudi
2025-08-27 16:08 ` Jakub Kicinski [this message]
2025-08-27 16:08 ` Jakub Kicinski
2025-08-28 17:12 ` Parvathi Pudi
2025-08-28 17:12 ` Parvathi Pudi
2025-08-22 14:39 ` [PATCH net-next v14 5/5] net: ti: icssm-prueth: Adds IEP support for PRUETH on AM33x, AM43x and AM57x SOCs Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827090820.12a58d22@kernel.org \
--to=kuba@kernel.org \
--cc=afd@ti.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=bastien.curutchet@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=glaroque@baylibre.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=johan@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=saikrishnag@marvell.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.