Re: [PATCH 00/19] ALSA: firewire: Use auto-cleanup macros

[Takashi Sakamoto <o-takashi@sakamocchi.jp>]

Hi,

On Wed, Aug 27, 2025 at 11:19:54AM +0200, Takashi Iwai wrote:
> This is another patch set for cleaning up the code with the recent
> auto-cleanup macros like guard() & co, applied to FireWire sound
> drivers.
> 
> Only code refactoring, and no behavior changes intended.
> 
> 
> Takashi
 
Thanks for the patchset. I have the similar series in my local, but not
yet completed. The patchset mostly looks good to me, but I can find
some nitpickings.

> ===
> 
> Takashi Iwai (19):
>   ALSA: firewire: bebob: Use guard() for mutex locks
>   ALSA: firewire: dice: Use guard() for mutex locks
>   ALSA: firewire: Use guard() for mutex locks

The patch title misses 'digi00x: '.

>   ALSA: firewire: fireworks: Use guard() for mutex locks
>   ALSA: firewire: motu: Use guard() for mutex locks
>   ALSA: firewire: oxfw: Use guard() for mutex locks
>   ALSA: firewire: tascam: Use guard() for mutex locks
>   ALSA: firewire: fireface: Use guard() for mutex locks
>   ALSA: firewire: isight: Use guard() for mutex locks
>   ALSA: firewire: lib: Use guard() for mutex locks
>   ALSA: firewire: bebob: Use guard() for spin locks
>   ALSA: firewire: dice: Use guard() for spin locks
>   ALSA: firewire: digi00x: Use guard() for spin locks
>   ALSA: firewire: fireface: Use guard() for spin locks
>   ALSA: firewire: fireworks: Use guard() for spin locks
>   ALSA: firewire: motu: Use guard() for spin locks
>   ALSA: firewire: oxfw: Use guard() for spin locks
>   ALSA: firewire: tascam: Use guard() for spin locks
>   ALSA: firewire: lib: Use guard() for spin locks

In my opinion, 'scoped_guard()' is available without blaces when the
inner component is just one line, however the above patches include
such lines. Additionally, some parts of scoped_guard() are followed by
useless blank line.

$ git grep -n -A2 scoped_guard sound/firewire/dice/dice-pcm.c
sound/firewire/dice/dice-pcm.c:199:     scoped_guard(mutex, &dice->mutex) {
sound/firewire/dice/dice-pcm.c-200-
sound/firewire/dice/dice-pcm.c-201-             // When source of clock is not internal or any stream is reserved for
--
sound/firewire/dice/dice-pcm.c:302:     scoped_guard(mutex, &dice->mutex) {
sound/firewire/dice/dice-pcm.c-303-             err = snd_dice_stream_start_duplex(dice);
sound/firewire/dice/dice-pcm.c-304-     }
--
sound/firewire/dice/dice-pcm.c:316:     scoped_guard(mutex, &dice->mutex) {
sound/firewire/dice/dice-pcm.c-317-             err = snd_dice_stream_start_duplex(dice);
sound/firewire/dice/dice-pcm.c-318-     }


Thanks

Takashi Sakamoto