Re: [PATCH 00/19] ALSA: firewire: Use auto-cleanup macros

[Takashi Iwai <tiwai@suse.de>]

On Thu, 28 Aug 2025 14:56:23 +0200,
Takashi Sakamoto wrote:
> 
> > Takashi Iwai (19):
> >   ALSA: firewire: bebob: Use guard() for mutex locks
> >   ALSA: firewire: dice: Use guard() for mutex locks
> >   ALSA: firewire: Use guard() for mutex locks
> 
> The patch title misses 'digi00x: '.

OK, will fix.

> >   ALSA: firewire: fireworks: Use guard() for mutex locks
> >   ALSA: firewire: motu: Use guard() for mutex locks
> >   ALSA: firewire: oxfw: Use guard() for mutex locks
> >   ALSA: firewire: tascam: Use guard() for mutex locks
> >   ALSA: firewire: fireface: Use guard() for mutex locks
> >   ALSA: firewire: isight: Use guard() for mutex locks
> >   ALSA: firewire: lib: Use guard() for mutex locks
> >   ALSA: firewire: bebob: Use guard() for spin locks
> >   ALSA: firewire: dice: Use guard() for spin locks
> >   ALSA: firewire: digi00x: Use guard() for spin locks
> >   ALSA: firewire: fireface: Use guard() for spin locks
> >   ALSA: firewire: fireworks: Use guard() for spin locks
> >   ALSA: firewire: motu: Use guard() for spin locks
> >   ALSA: firewire: oxfw: Use guard() for spin locks
> >   ALSA: firewire: tascam: Use guard() for spin locks
> >   ALSA: firewire: lib: Use guard() for spin locks
> 
> In my opinion, 'scoped_guard()' is available without blaces when the
> inner component is just one line, however the above patches include
> such lines. Additionally, some parts of scoped_guard() are followed by
> useless blank line.

OK, will fix in v2, too.


thanks,

Takashi