From: Simon Horman <horms@kernel.org>
To: Carolina Jubran <cjubran@nvidia.com>
Cc: Shuah Khan <shuah@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Gal Pressman <gal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Nimrod Oren <noren@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] selftests: drv-net: Fix tolerance calculation in devlink_rate_tc_bw.py
Date: Mon, 1 Sep 2025 16:45:57 +0100 [thread overview]
Message-ID: <20250901154557.GI15473@horms.kernel.org> (raw)
In-Reply-To: <20250831080641.1828455-3-cjubran@nvidia.com>
On Sun, Aug 31, 2025 at 11:06:40AM +0300, Carolina Jubran wrote:
> Currently, tolerance is computed against the TC’s expected percentage,
> making TC3 (20%) validation overly strict and TC4 (80%) overly loose.
>
> Update BandwidthValidator to take a dict of shares and compute bounds
> relative to the overall total, so that all shares are validated
> consistently.
>
> Fixes: 23ca32e4ead4 ("selftests: drv-net: Add test for devlink-rate traffic class bandwidth distribution")
> Tested-by: Carolina Jubran <cjubran@nvidia.com>
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Reviewed-by: Nimrod Oren <noren@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-09-01 15:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 8:06 [PATCH 0/3] selftests: drv-net: Fix issues in devlink_rate_tc_bw.py Carolina Jubran
2025-08-31 8:06 ` [PATCH 1/3] selftests: drv-net: Fix and clarify TC bandwidth split " Carolina Jubran
2025-09-01 15:45 ` Simon Horman
2025-08-31 8:06 ` [PATCH 2/3] selftests: drv-net: Fix tolerance calculation " Carolina Jubran
2025-09-01 15:45 ` Simon Horman [this message]
2025-08-31 8:06 ` [PATCH 3/3] selftests: drv-net: Relax total BW check " Carolina Jubran
2025-09-01 15:46 ` Simon Horman
2025-09-02 23:21 ` Jakub Kicinski
2025-09-05 22:32 ` Jakub Kicinski
2025-09-08 19:16 ` Carolina Jubran
2025-09-08 20:19 ` Jakub Kicinski
2025-09-09 10:06 ` Carolina Jubran
2025-09-09 21:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250901154557.GI15473@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=noren@nvidia.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.