From: Lee Jones <lee@kernel.org>
To: Daniel Thompson <daniel@riscstar.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Flavio Suligoi" <f.suligoi@asem.it>,
"Daniel Thompson" <danielt@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/2] backlight: mp3309c: Initialize backlight properties without memset
Date: Tue, 2 Sep 2025 11:36:32 +0100 [thread overview]
Message-ID: <20250902103632.GH2163762@google.com> (raw)
In-Reply-To: <aKLvaP55PIVhyFSc@aspen.lan>
On Mon, 18 Aug 2025, Daniel Thompson wrote:
> On Tue, Jul 01, 2025 at 11:22:37AM +0200, Uwe Kleine-König wrote:
> > Assigning values to a struct using a compound literal (since C99) also
> > guarantees that all unspecified struct members are empty-initialized, so
> > it properly replaces the memset to zero.
> >
> > The code looks a bit nicer and more idiomatic (though that might be
> > subjective?). The resulting binary is a bit smaller. On ARCH=arm with
> > an allnoconfig + minimal changes to enable the mp3309c driver the
> > difference is 12 bytes.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
>
> Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Looks like you cannot send tags from non-related email accounts:
NOTE: some trailers ignored due to from/email mismatches:
! Trailer: Reviewed-by: "Daniel Thompson (RISCstar)" <danielt@kernel.org>
Msg From: Daniel Thompson <daniel@riscstar.com>
I'll add the tags manually this time.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-09-02 10:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:22 [PATCH 0/2] backlight: mp3309c: Drop pwm_apply_args() Uwe Kleine-König
2025-07-01 9:22 ` [PATCH 1/2] " Uwe Kleine-König
2025-07-07 15:48 ` EXTERNAL: " FLAVIO SULIGOI
2025-08-18 9:15 ` Daniel Thompson
2025-07-01 9:22 ` [PATCH 2/2] backlight: mp3309c: Initialize backlight properties without memset Uwe Kleine-König
2025-07-07 15:49 ` EXTERNAL: " FLAVIO SULIGOI
2025-08-18 9:16 ` Daniel Thompson
2025-09-02 10:36 ` Lee Jones [this message]
2025-09-09 13:16 ` Uwe Kleine-König
2025-07-07 15:44 ` EXTERNAL: [PATCH 0/2] backlight: mp3309c: Drop pwm_apply_args() FLAVIO SULIGOI
2025-07-29 20:17 ` Uwe Kleine-König
2025-08-18 8:54 ` Uwe Kleine-König
2025-09-02 10:35 ` Lee Jones
2025-09-09 13:43 ` Uwe Kleine-König
2025-09-11 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902103632.GH2163762@google.com \
--to=lee@kernel.org \
--cc=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.