From: Daniel Thompson <daniel@riscstar.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Flavio Suligoi <f.suligoi@asem.it>, Lee Jones <lee@kernel.org>,
Daniel Thompson <danielt@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH 1/2] backlight: mp3309c: Drop pwm_apply_args()
Date: Mon, 18 Aug 2025 10:15:28 +0100 [thread overview]
Message-ID: <aKLvMLgZJ4fVLjph@aspen.lan> (raw)
In-Reply-To: <2d1075f5dd45c7c135e4326e279468de699f9d17.1751361465.git.u.kleine-koenig@baylibre.com>
On Tue, Jul 01, 2025 at 11:22:36AM +0200, Uwe Kleine-König wrote:
> pwm_apply_args() sole purpose is to initialize all parameters specified
> in the device tree for consumers that rely on pwm_config() and
> pwm_enable(). The mp3309c backlight driver uses pwm_apply_might_sleep()
> which gets passed the full configuration and so doesn't rely on the
> default being explicitly applied.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Sorry for the delay. I lost track of the review on this one so Lee didn't
hoover it up!
Daniel.
next prev parent reply other threads:[~2025-08-18 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 9:22 [PATCH 0/2] backlight: mp3309c: Drop pwm_apply_args() Uwe Kleine-König
2025-07-01 9:22 ` [PATCH 1/2] " Uwe Kleine-König
2025-07-07 15:48 ` EXTERNAL: " FLAVIO SULIGOI
2025-08-18 9:15 ` Daniel Thompson [this message]
2025-07-01 9:22 ` [PATCH 2/2] backlight: mp3309c: Initialize backlight properties without memset Uwe Kleine-König
2025-07-07 15:49 ` EXTERNAL: " FLAVIO SULIGOI
2025-08-18 9:16 ` Daniel Thompson
2025-09-02 10:36 ` Lee Jones
2025-09-09 13:16 ` Uwe Kleine-König
2025-07-07 15:44 ` EXTERNAL: [PATCH 0/2] backlight: mp3309c: Drop pwm_apply_args() FLAVIO SULIGOI
2025-07-29 20:17 ` Uwe Kleine-König
2025-08-18 8:54 ` Uwe Kleine-König
2025-09-02 10:35 ` Lee Jones
2025-09-09 13:43 ` Uwe Kleine-König
2025-09-11 8:21 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKLvMLgZJ4fVLjph@aspen.lan \
--to=daniel@riscstar.com \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=f.suligoi@asem.it \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.