Re: [Buildroot] [PATCH 1/1] package/bat: fix build with GCC 15

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 2 Sep 2025 16:56:59 +0200
El Mehdi YOUNES <elmehdi.younes@smile.fr> wrote:

> > This link doesn't make sense as it can contain failures unrelated to
> > this one, especially in the future. You need to include the link to one
> > specific build result.  
> I can fix this in a v2 if needed.

👍️

> >> +Upstream: not submitted  
> > Why?  
> 
> Do you mean why we are switching from 'regex-onig' to 'regex-fancy',
> 
> or why the patch has not been submitted upstream?

Why the patch was not submitted upstream.

> In this patch, I switched the feature from 'regex-onig' to 'regex-fancy'.
> This does not affect vendoring in our case, since vendoring is based on
> Cargo.lock. In the current Cargo.lock, 'syntect' already lists both
> 'fancy-regex' and 'onig' as dependencies. Therefore, the set of crates
> included in vendoring remains exactly the same before and after the patch
> (I tested this locally).
> 
> What really changes is only at compile time: after the patch, Cargo builds
> with 'fancy-regex' instead of 'onig'/'onig_sys'.
> 
> Do you think I should avoid this approach? If so, I can look into another
> ways to fix this

Aaah, makes sense. I was not aware of this mechanism. Sounds good.
Could you submit a v2 to fix the other minor issues?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot