Re: [Buildroot] [PATCH 1/1] package/bat: fix build with GCC 15

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 2 Sep 2025 17:28:41 +0200
El Mehdi YOUNES <elmehdi.younes@smile.fr> wrote:

> The patch was not submitted upstream because there is already an ongoing
> discussion about removing Oniguruma from bat altogether, since Oniguruma
> has been declared archived:
> 
>    https://github.com/sharkdp/bat/issues/3285
> 
> For now, some features in bat still depend on Oniguruma by default, so
> upstream keeps 'regex-onig' as the default engine. That’s why I did not
> propose this patch upstream.

Would be good to have this extensive explanation in the patch, instead
of just "Upstream: not submitted".

> According to the upstream discussion, it still makes sense for bat to
> keep Oniguruma as the default engine for now. So before sending a v2, I
> would like to take a step back and explore another approach.
> 
> I know that 'onig_sys' can sometimes link against a system-provided
> Oniguruma library instead of compiling it. In Buildroot we
> already have 'oniguruma' available as a package, so we could consider
> using that system library rather than patching bat to switch to
> 'regex-fancy'. This way, we could keep bat aligned with upstream while
> still fixing the GCC 15 build issue. What do you think about this?
> 
> see
> 
> https://crates.io/crates/onig/6.5.1

That would work with me as well. What's important is that we have a GCC
15.x build fix available in the short term. Another option is to take
your quick fix as-is, and later on improve to use again Oniguruma.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot