All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jean-François Lessard" <jefflessard3@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: [PATCH v4 2/2] i2c: core: Use fwnode_for_each_child_node_scoped()
Date: Tue,  2 Sep 2025 15:04:40 -0400	[thread overview]
Message-ID: <20250902190443.3252-3-jefflessard3@gmail.com> (raw)
In-Reply-To: <20250902190443.3252-1-jefflessard3@gmail.com>

Replace the manual __free(fwnode_handle) iterator declaration with the
new scoped iterator macro for cleaner, less error-prone code.

This eliminates the need for explicit iterator variable declaration with
the cleanup attribute, making the code more consistent with other scoped
iterator usage patterns in the kernel.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jean-François Lessard <jefflessard3@gmail.com>
---
 drivers/i2c/i2c-core-slave.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
index 7ee6b992b..02ca55c22 100644
--- a/drivers/i2c/i2c-core-slave.c
+++ b/drivers/i2c/i2c-core-slave.c
@@ -112,10 +112,9 @@ bool i2c_detect_slave_mode(struct device *dev)
 	struct fwnode_handle *fwnode = dev_fwnode(dev);
 
 	if (is_of_node(fwnode)) {
-		struct fwnode_handle *child __free(fwnode_handle) = NULL;
 		u32 reg;
 
-		fwnode_for_each_child_node(fwnode, child) {
+		fwnode_for_each_child_node_scoped(fwnode, child) {
 			fwnode_property_read_u32(child, "reg", &reg);
 			if (reg & I2C_OWN_SLAVE_ADDRESS)
 				return true;
-- 
2.43.0


  parent reply	other threads:[~2025-09-02 19:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 19:04 [PATCH v4 0/2] device property: Add scoped fwnode child node iterators Jean-François Lessard
2025-09-02 19:04 ` [PATCH v4 1/2] " Jean-François Lessard
2025-09-02 19:11   ` Danilo Krummrich
2025-09-03 10:29   ` Andy Shevchenko
2025-09-03 13:18   ` Sakari Ailus
2025-09-03 16:43     ` Jean-François Lessard
2025-09-03 17:22     ` Danilo Krummrich
2025-09-04  5:56       ` Sakari Ailus
2025-09-04  7:03         ` Danilo Krummrich
2025-09-04  7:43           ` Sakari Ailus
2025-09-04  8:51             ` Danilo Krummrich
2025-09-04 11:54               ` Sakari Ailus
2025-09-04 12:39                 ` Sakari Ailus
2025-09-04 16:14                 ` Danilo Krummrich
2025-09-16 16:18                   ` Sakari Ailus
2025-09-25 20:43   ` Wolfram Sang
2025-09-02 19:04 ` Jean-François Lessard [this message]
2025-09-03 13:19   ` [PATCH v4 2/2] i2c: core: Use fwnode_for_each_child_node_scoped() Sakari Ailus
2025-09-25 20:43   ` Wolfram Sang
2025-09-03 10:30 ` [PATCH v4 0/2] device property: Add scoped fwnode child node iterators Andy Shevchenko
2025-09-04  9:49   ` Wolfram Sang
2025-09-04  9:59     ` Andy Shevchenko
2025-09-04 10:13       ` Danilo Krummrich
2025-09-04 10:38         ` Sakari Ailus
2025-09-10 12:53       ` Wolfram Sang
2025-09-12 22:28         ` Wolfram Sang
2025-09-15  6:27           ` Andy Shevchenko
2025-09-25 10:54             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250902190443.3252-3-jefflessard3@gmail.com \
    --to=jefflessard3@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dakr@kernel.org \
    --cc=djrscally@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.